Implement bssl::TrustStore::GetTrustedMTCIssuerOf [chromium/src : main]

0 views
Skip to first unread message

Nick Harper (Gerrit)

unread,
Dec 19, 2025, 6:24:49 PM12/19/25
to chromium...@chromium.org, net-r...@chromium.org, mac-r...@chromium.org

Nick Harper has uploaded the change for review

Commit message

Implement bssl::TrustStore::GetTrustedMTCIssuerOf

The base class bssl::TrustStore should have GetTrustedMTCIssuerOf be a
pure virtual function. This change implements GetTrustedMTCIssuerOf for
all chromium subclasses of bssl::TrustStore to allow removing the
default implementation in bssl::TrustStore.
Change-Id: I8ff039314c48269a1a6556e7297364fabb062f6b

Change diff


Change information

Files:
  • M net/cert/cert_verify_proc_builtin_unittest.cc
  • M net/cert/internal/trust_store_android.cc
  • M net/cert/internal/trust_store_android.h
  • M net/cert/internal/trust_store_mac.cc
  • M net/cert/internal/trust_store_mac.h
  • M net/cert/internal/trust_store_nss.cc
  • M net/cert/internal/trust_store_nss.h
  • M net/cert/internal/trust_store_win.cc
  • M net/cert/internal/trust_store_win.h
  • M net/cert/test_root_certs.cc
  • M net/cert/test_root_certs.h
Change size: S
Delta: 11 files changed, 46 insertions(+), 0 deletions(-)
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I8ff039314c48269a1a6556e7297364fabb062f6b
Gerrit-Change-Number: 7275048
Gerrit-PatchSet: 1
Gerrit-Owner: Nick Harper <nha...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

Nick Harper (Gerrit)

unread,
Dec 19, 2025, 6:25:09 PM12/19/25
to chromium...@chromium.org, mac-r...@chromium.org, net-r...@chromium.org

Nick Harper voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I8ff039314c48269a1a6556e7297364fabb062f6b
Gerrit-Change-Number: 7275048
Gerrit-PatchSet: 1
Gerrit-Owner: Nick Harper <nha...@chromium.org>
Gerrit-Reviewer: Nick Harper <nha...@chromium.org>
Gerrit-Comment-Date: Fri, 19 Dec 2025 23:24:59 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Nick Harper (Gerrit)

unread,
Dec 19, 2025, 7:26:38 PM12/19/25
to Matt Mueller, Chromium LUCI CQ, chromium...@chromium.org, mac-r...@chromium.org, net-r...@chromium.org
Attention needed from Matt Mueller

Nick Harper voted Auto-Submit+1

Auto-Submit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Matt Mueller
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I8ff039314c48269a1a6556e7297364fabb062f6b
Gerrit-Change-Number: 7275048
Gerrit-PatchSet: 1
Gerrit-Owner: Nick Harper <nha...@chromium.org>
Gerrit-Reviewer: Matt Mueller <ma...@chromium.org>
Gerrit-Reviewer: Nick Harper <nha...@chromium.org>
Gerrit-Attention: Matt Mueller <ma...@chromium.org>
Gerrit-Comment-Date: Sat, 20 Dec 2025 00:26:28 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Matt Mueller (Gerrit)

unread,
Jan 9, 2026, 7:47:02 PM (20 hours ago) Jan 9
to Nick Harper, Matt Mueller, Chromium LUCI CQ, chromium...@chromium.org, mac-r...@chromium.org, net-r...@chromium.org
Attention needed from Nick Harper

Matt Mueller voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Nick Harper
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I8ff039314c48269a1a6556e7297364fabb062f6b
    Gerrit-Change-Number: 7275048
    Gerrit-PatchSet: 1
    Gerrit-Owner: Nick Harper <nha...@chromium.org>
    Gerrit-Reviewer: Matt Mueller <ma...@chromium.org>
    Gerrit-Reviewer: Nick Harper <nha...@chromium.org>
    Gerrit-Attention: Nick Harper <nha...@chromium.org>
    Gerrit-Comment-Date: Sat, 10 Jan 2026 00:46:50 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Jan 9, 2026, 9:31:36 PM (19 hours ago) Jan 9
    to Nick Harper, Matt Mueller, chromium...@chromium.org, mac-r...@chromium.org, net-r...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Implement bssl::TrustStore::GetTrustedMTCIssuerOf

    The base class bssl::TrustStore should have GetTrustedMTCIssuerOf be a
    pure virtual function. This change implements GetTrustedMTCIssuerOf for
    all chromium subclasses of bssl::TrustStore to allow removing the
    default implementation in bssl::TrustStore.
    Change-Id: I8ff039314c48269a1a6556e7297364fabb062f6b
    Reviewed-by: Matt Mueller <ma...@chromium.org>
    Commit-Queue: Matt Mueller <ma...@chromium.org>
    Auto-Submit: Nick Harper <nha...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1567330}
    Files:
    • M net/cert/cert_verify_proc_builtin_unittest.cc
    • M net/cert/internal/trust_store_android.cc
    • M net/cert/internal/trust_store_android.h
    • M net/cert/internal/trust_store_mac.cc
    • M net/cert/internal/trust_store_mac.h
    • M net/cert/internal/trust_store_nss.cc
    • M net/cert/internal/trust_store_nss.h
    • M net/cert/internal/trust_store_win.cc
    • M net/cert/internal/trust_store_win.h
    • M net/cert/test_root_certs.cc
    • M net/cert/test_root_certs.h
    Change size: S
    Delta: 11 files changed, 46 insertions(+), 0 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Matt Mueller
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I8ff039314c48269a1a6556e7297364fabb062f6b
    Gerrit-Change-Number: 7275048
    Gerrit-PatchSet: 2
    Gerrit-Owner: Nick Harper <nha...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Matt Mueller <ma...@chromium.org>
    Gerrit-Reviewer: Nick Harper <nha...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages