Actor: Differentiate paused and active tasks for tabs [chromium/src : main]
0 views
Skip to first unread message
David Bokan (Gerrit)
Sep 25, 2025, 11:44:35 AM (17 hours ago) Sep 25
to Erik Chen, Kevin McNee, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, milicau+watchlis...@google.com, gcasto+w...@chromium.org, vasilii+watchlis...@chromium.org, permissio...@chromium.org, aashna...@google.com, boujan...@google.com, chrstn...@google.com, kenok...@google.com, kmg+...@google.com, mfoltz+wa...@chromium.org
Attention needed from Erik Chen and Kevin McNee
David Bokan added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 6 (Latest):
David Bokan . resolved
+erikchen@ preemptively for c/b/{password_manager|permissions|ui}/* OWNER (will still wait for mcnee@ to stamp the rest)
Related details
Attention is currently required from:
- Erik Chen
- Kevin McNee
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kevin McNee (Gerrit)
Sep 25, 2025, 12:32:49 PM (16 hours ago) Sep 25
to David Bokan, Erik Chen, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, milicau+watchlis...@google.com, gcasto+w...@chromium.org, vasilii+watchlis...@chromium.org, permissio...@chromium.org, aashna...@google.com, boujan...@google.com, chrstn...@google.com, kenok...@google.com, kmg+...@google.com, mfoltz+wa...@chromium.org
Attention needed from David Bokan and Erik Chen
Kevin McNee voted and added 3 comments![]( "Open in Gerrit")
Votes added by Kevin McNee
| Code-Review | +1 |
3 comments
Patchset-level comments
File chrome/browser/actor/actor_keyed_service_unittest.cc
Line 238, Patchset 7 (Latest):
// Stop the task and try to add a tab.Kevin McNee . unresolved
nit: Comment is incorrect.
File chrome/browser/actor/actor_task.cc
Line 314, Patchset 7 (Latest):
if (GetState() == State::kPausedByActor ||Kevin McNee . unresolved
nit: This could use IsPaused and IsStopped.
Related details
Attention is currently required from:
- David Bokan
- Erik Chen
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
David Bokan (Gerrit)
Sep 25, 2025, 1:20:30 PM (16 hours ago) Sep 25
to Kevin McNee, Erik Chen, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, milicau+watchlis...@google.com, gcasto+w...@chromium.org, vasilii+watchlis...@chromium.org, permissio...@chromium.org, aashna...@google.com, boujan...@google.com, chrstn...@google.com, kenok...@google.com, kmg+...@google.com, mfoltz+wa...@chromium.org
Attention needed from Erik Chen
David Bokan added 2 comments![]( "Open in Gerrit")
File chrome/browser/actor/actor_keyed_service_unittest.cc
Line 238, Patchset 7:
// Stop the task and try to add a tab.Kevin McNee . resolved
David Bokannit: Comment is incorrect.
Done
File chrome/browser/actor/actor_task.cc
nit: This could use IsPaused and IsStopped.
Attention is currently required from:
- Erik Chen
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
David Bokan (Gerrit)
Sep 25, 2025, 4:41:40 PM (12 hours ago) Sep 25
to Kevin McNee, Erik Chen, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, milicau+watchlis...@google.com, gcasto+w...@chromium.org, vasilii+watchlis...@chromium.org, permissio...@chromium.org, aashna...@google.com, boujan...@google.com, chrstn...@google.com, kenok...@google.com, kmg+...@google.com, mfoltz+wa...@chromium.org
Attention needed from Erik Chen
David Bokan voted Auto-Submit+1![]( "Open in Gerrit")
| Auto-Submit | +1 |
Related details
Attention is currently required from:
- Erik Chen
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Erik Chen (Gerrit)
Sep 25, 2025, 4:55:53 PM (12 hours ago) Sep 25
to David Bokan, Kevin McNee, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, milicau+watchlis...@google.com, gcasto+w...@chromium.org, vasilii+watchlis...@chromium.org, permissio...@chromium.org, aashna...@google.com, boujan...@google.com, chrstn...@google.com, kenok...@google.com, kmg+...@google.com, mfoltz+wa...@chromium.org
Attention needed from David Bokan
Erik Chen voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- David Bokan
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages