[UFS] Clear dynamic recovery properties on DUT during CreateDUT [infra/infra : main]
0 views
Skip to first unread message
Otabek Kasimov (Gerrit)
2:49 PM (3 hours ago) 2:49 PM
to chromium...@chromium.org, infra-rev...@chromium.org
Otabek Kasimov has uploaded the change for review![]( "Open in Gerrit")
Commit message
[UFS] Clear dynamic recovery properties on DUT during CreateDUT
Ensure all dynamic recovery-populated LabData properties on MachineLSE (keyed by hostname) are reset to clean/empty values when a new DUT is created (add dut). This guarantees that whenever a DUT is re-added or created for a lab slot, residual Cbi, RoVpdMap, and dynamic peripheral states from previous deployments do not persist on the MachineLSE.
BUG=b:532209965
TEST=go test ./app/controller/... -run TestCreateDUT
TAG=agy
CONV=86aeb3cb-256b-4dcb-8fd1-25ebe0a7952d
Change-Id: Ie51d3ee59f13bb50a54170f3a9fe1a1949254ecf
Change diff
Change information
Files:
- M go/src/infra/unifiedfleet/app/controller/dut.go
- M go/src/infra/unifiedfleet/app/controller/dut_test.go
Change size: M
Delta: 2 files changed, 50 insertions(+), 1 deletion(-)
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Otabek Kasimov (Gerrit)
3:02 PM (2 hours ago) 3:02 PM
to chromium...@chromium.org, infra-rev...@chromium.org
Otabek Kasimov added 4 comments![]( "Open in Gerrit")
File go/src/infra/unifiedfleet/app/controller/dut.go
Line 497, Patchset 1 (Latest):
func cleanPreDeployFields(servo *chromeosLab.Servo) {Otabek Kasimov . unresolved
create a test for this function.
Line 507, Patchset 1 (Latest):
func cleanPreDeployDUTFields(dut *chromeosLab.DeviceUnderTest) {Otabek Kasimov . unresolved
create a test for this function.
Line 522, Patchset 1 (Latest):
cleanPreDeployFields(peri.GetServo())Otabek Kasimov . unresolved
why do we need this call as it called independenctly.
File go/src/infra/unifiedfleet/app/controller/dut_test.go
Line 486, Patchset 1 (Latest):
BuildTarget: "test",
Model: "test",Otabek Kasimov . unresolved
add field with nil values to specify that values are expecetd to be cleared.
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Otabek Kasimov (Gerrit)
5:14 PM (14 minutes ago) 5:14 PM
to Anushruth Sasivehalli, chromium...@chromium.org, infra-rev...@chromium.org
Attention needed from Anushruth Sasivehalli
Otabek Kasimov voted![]( "Open in Gerrit")
| Auto-Submit | +1 |
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Anushruth Sasivehalli
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages