Speculation rules: move hover heuristics to renderer [chromium/src : main]

0 views

Skip to first unread message

Hiroki Nakagawa (Gerrit)

unread,

Jul 17, 2026, 5:40:41 AM (8 days ago) Jul 17

to Yoav Weiss (@Shopify), chromium...@chromium.org, Nate Chapin, prerendering-reviews, blink-...@chromium.org, gavinp...@chromium.org, gavinp+p...@chromium.org, loading...@chromium.org

Attention needed from Yoav Weiss (@Shopify)

Hiroki Nakagawa added 2 comments

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Hiroki Nakagawa . unresolved

Can you run the git rebase to see the latest shape?

File third_party/blink/renderer/core/loader/anchor_element_interaction_tracker.cc

Line 580, Patchset 1 (Latest): interaction_host_->OnPointerHoverModerate(

Hiroki Nakagawa . unresolved

`OnPointerHoverModerate()` runs the disk cache warmup and searvice worker warmup:
https://source.chromium.org/chromium/chromium/src/+/main:content/browser/preloading/anchor_element_interaction_host_impl.cc;l=158-168;drc=b9ff62bb6ff2143fc168dff0e3392e4335de1b8a

The current implementation loses them when the feature flag is enabled.

Open in Gerrit

Related details

Attention is currently required from:

Yoav Weiss (@Shopify)

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Yoav Weiss (@Shopify) (Gerrit)

unread,

8:27 AM (7 hours ago) 8:27 AM

to android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, Hiroki Nakagawa, chromium...@chromium.org, Nate Chapin, prerendering-reviews, kinuko...@chromium.org, blink-re...@chromium.org, tburkar...@chromium.org, gavin...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org, gavinp+p...@chromium.org, loading...@chromium.org

Attention needed from Hiroki Nakagawa

Yoav Weiss (@Shopify) added 2 comments

Patchset-level comments

File-level comment, Patchset 1:

Hiroki Nakagawa . resolved

Can you run the git rebase to see the latest shape?

Yoav Weiss (@Shopify)

Done