updater: remove trailing decltype return from lambda [chromium/src : main]

0 views
Skip to first unread message

Sorin Jianu (Gerrit)

unread,
6:35 PM (2 hours ago) 6:35 PM
to S Ganesh, chromium...@chromium.org
Attention needed from S Ganesh

Sorin Jianu voted and added 1 comment

Votes added by Sorin Jianu

Auto-Submit+1
Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Sorin Jianu . resolved

PTAL TY

Open in Gerrit

Related details

Attention is currently required from:
  • S Ganesh
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I9e66b8510eccacc5375d04974b5f270aadb4cd4b
Gerrit-Change-Number: 7486605
Gerrit-PatchSet: 1
Gerrit-Owner: Sorin Jianu <so...@chromium.org>
Gerrit-Reviewer: S Ganesh <gan...@chromium.org>
Gerrit-Reviewer: Sorin Jianu <so...@chromium.org>
Gerrit-Attention: S Ganesh <gan...@chromium.org>
Gerrit-Comment-Date: Thu, 15 Jan 2026 23:35:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

S Ganesh (Gerrit)

unread,
6:37 PM (2 hours ago) 6:37 PM
to Sorin Jianu, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Sorin Jianu

S Ganesh voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Sorin Jianu
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I9e66b8510eccacc5375d04974b5f270aadb4cd4b
    Gerrit-Change-Number: 7486605
    Gerrit-PatchSet: 1
    Gerrit-Owner: Sorin Jianu <so...@chromium.org>
    Gerrit-Reviewer: S Ganesh <gan...@chromium.org>
    Gerrit-Reviewer: Sorin Jianu <so...@chromium.org>
    Gerrit-Attention: Sorin Jianu <so...@chromium.org>
    Gerrit-Comment-Date: Thu, 15 Jan 2026 23:37:04 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    8:13 PM (1 hour ago) 8:13 PM
    to Sorin Jianu, S Ganesh, chromium...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    updater: remove trailing decltype return from lambda

    This is trying to work around a clang bug in a future CL
    Change-Id: I9e66b8510eccacc5375d04974b5f270aadb4cd4b
    Commit-Queue: S Ganesh <gan...@chromium.org>
    Auto-Submit: Sorin Jianu <so...@chromium.org>
    Reviewed-by: S Ganesh <gan...@chromium.org>
    Commit-Queue: Sorin Jianu <so...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1570124}
    Files:
    • M chrome/updater/util/win_util.cc
    Change size: XS
    Delta: 1 file changed, 5 insertions(+), 4 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by S Ganesh
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I9e66b8510eccacc5375d04974b5f270aadb4cd4b
    Gerrit-Change-Number: 7486605
    Gerrit-PatchSet: 2
    Gerrit-Owner: Sorin Jianu <so...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: S Ganesh <gan...@chromium.org>
    Gerrit-Reviewer: Sorin Jianu <so...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages