Sam Davis Omekara (Gerrit)

unread,

Sep 22, 2025, 7:20:08 PM (3 days ago) Sep 22

to Chromium LUCI CQ, Olga Gerchikov, AyeAye, Alexis Menard, Chromium Metrics Reviews, chromium...@chromium.org, chromium-a...@chromium.org, rouslan+au...@chromium.org, extension...@chromium.org, peilinwa...@google.com, asvitki...@chromium.org, dtapuska+...@chromium.org, mfoltz...@chromium.org, browser-comp...@chromium.org, blink-revi...@chromium.org, zol...@webkit.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, apavlo...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, bmcquad...@chromium.org, csharris...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org

Attention needed from Sam Davis Omekara

Message from Sam Davis Omekara

Set Ready For Review

Open in Gerrit

Related details

Attention is currently required from:

Sam Davis Omekara

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Alison Maher (Gerrit)

unread,

Sep 23, 2025, 2:09:05 PM (2 days ago) Sep 23

to Sam Davis Omekara, Kevin Babbitt, Chromium LUCI CQ, Olga Gerchikov, AyeAye, Alexis Menard, Chromium Metrics Reviews, chromium...@chromium.org, chromium-a...@chromium.org, rouslan+au...@chromium.org, extension...@chromium.org, peilinwa...@google.com, asvitki...@chromium.org, dtapuska+...@chromium.org, mfoltz...@chromium.org, browser-comp...@chromium.org, blink-revi...@chromium.org, zol...@webkit.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, apavlo...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, bmcquad...@chromium.org, csharris...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org

Attention needed from Kevin Babbitt and Sam Davis Omekara

Alison Maher added 1 comment

File third_party/blink/renderer/core/css/properties/longhands/longhands_custom.cc

Line 2807, Patchset 14 (Latest):

  bool is_legacy_column_rule =
      style.ColumnRuleWidthInternal().HasSingleValue() &&
      style.ColumnRuleStyle().HasSingleValue();

  // Record use counter for the `column-rule-width` property if its resolved
  // value is non-zero and the corresponding style is "none" or "hidden". This
  // is to evaluate web compat risk in changing the behavior of
  // `column-rule-width` to be independent of the `column-rule-style`.
  //
  // https://github.com/w3c/csswg-drafts/issues/11494#issuecomment-2675800489
  if (is_legacy_column_rule && value_phase == CSSValuePhase::kResolvedValue &&
      layout_object) {
    int width_value = style.ColumnRuleWidthInternal().GetLegacyValue();
    EBorderStyle style_value = style.ColumnRuleStyle().GetLegacyValue();
    if (width_value != 0 && (style_value == EBorderStyle::kNone ||
                             style_value == EBorderStyle::kHidden)) {
      layout_object->GetDocument().CountUse(
          WebFeature::kResolvedColumnRuleWidthWithNoneOrHiddenStyle);
    }
  }

Alison Maher . unresolved

It thought this only had web compat risk if it was queried, not just if it resolved to the legacy value. Will this only be kResolvedValue if an author queries this themselves?

Open in Gerrit

Related details

Attention is currently required from:

Kevin Babbitt
Sam Davis Omekara

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

No-Unresolved-Comments

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Kevin Babbitt (Gerrit)

unread,

Sep 24, 2025, 5:09:58 PM (yesterday) Sep 24

to Sam Davis Omekara, Alison Maher, Chromium LUCI CQ, Olga Gerchikov, AyeAye, Alexis Menard, Chromium Metrics Reviews, chromium...@chromium.org, chromium-a...@chromium.org, rouslan+au...@chromium.org, extension...@chromium.org, peilinwa...@google.com, asvitki...@chromium.org, dtapuska+...@chromium.org, mfoltz...@chromium.org, browser-comp...@chromium.org, blink-revi...@chromium.org, zol...@webkit.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, apavlo...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, bmcquad...@chromium.org, csharris...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org

Attention needed from Sam Davis Omekara

Kevin Babbitt voted and added 1 comment

Votes added by Kevin Babbitt

Code-Review

+1

1 comment

File third_party/blink/renderer/core/css/properties/longhands/longhands_custom.cc

Line 2807, Patchset 14 (Latest):

  bool is_legacy_column_rule =
      style.ColumnRuleWidthInternal().HasSingleValue() &&
      style.ColumnRuleStyle().HasSingleValue();

  // Record use counter for the `column-rule-width` property if its resolved
  // value is non-zero and the corresponding style is "none" or "hidden". This
  // is to evaluate web compat risk in changing the behavior of
  // `column-rule-width` to be independent of the `column-rule-style`.
  //
  // https://github.com/w3c/csswg-drafts/issues/11494#issuecomment-2675800489
  if (is_legacy_column_rule && value_phase == CSSValuePhase::kResolvedValue &&
      layout_object) {
    int width_value = style.ColumnRuleWidthInternal().GetLegacyValue();
    EBorderStyle style_value = style.ColumnRuleStyle().GetLegacyValue();
    if (width_value != 0 && (style_value == EBorderStyle::kNone ||
                             style_value == EBorderStyle::kHidden)) {
      layout_object->GetDocument().CountUse(
          WebFeature::kResolvedColumnRuleWidthWithNoneOrHiddenStyle);
    }
  }

Alison Maher . unresolved

It thought this only had web compat risk if it was queried, not just if it resolved to the legacy value. Will this only be kResolvedValue if an author queries this themselves?

Kevin Babbitt

It thought this only had web compat risk if it was queried, not just if it resolved to the legacy value.

That should be the case. When the style is `none` or `hidden`, the rendering will be the same either with or without the behavior change, since column-rule and outline don't affect layout. The only observable difference is the value queried via getComputedStyle().

Will this only be kResolvedValue if an author queries this themselves?

Sam Davis can answer for sure, but I'd expect the answer to be "yes." Resolved values are intended specifically for getComputedStyle(). Internal codepaths that need the used value should be asking the ComputedStyle object for values rather than coming through here.

Open in Gerrit

Related details

Attention is currently required from:

Sam Davis Omekara

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review

No-Unresolved-Comments

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Sam Davis Omekara (Gerrit)

unread,

3:56 AM (16 hours ago) 3:56 AM

to Kevin Babbitt, Alison Maher, Chromium LUCI CQ, Olga Gerchikov, AyeAye, Alexis Menard, Chromium Metrics Reviews, chromium...@chromium.org, chromium-a...@chromium.org, rouslan+au...@chromium.org, extension...@chromium.org, peilinwa...@google.com, asvitki...@chromium.org, dtapuska+...@chromium.org, mfoltz...@chromium.org, browser-comp...@chromium.org, blink-revi...@chromium.org, zol...@webkit.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, apavlo...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, bmcquad...@chromium.org, csharris...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org

Attention needed from Alison Maher

Sam Davis Omekara added 1 comment

File third_party/blink/renderer/core/css/properties/longhands/longhands_custom.cc

Sam Davis Omekara

Yes, like Kevin mentioned, the observable difference will be when the value is queried via getComputedStyle() since there's no rendering difference.

In terms of the `value_phase` being kResolved value, the primary place where this is css_computed_style_declaration.cc (which I'm guessing corresponds to what powers getComputedStyle).

That's not the *only* path though, there are some others that seem like one offs like:

* html/forms/internal_popup_menu.cc in:
  * SerializeComputedStyleForProperty

* inspector/inspector_dom_snapshot_agent.cc in:
  * InspectorDOMSnapshotAgent::BuildStylesForNode

* inspector/legacy_dom_snapshot_agent.cc in:
  * LegacyDOMSnapshotAgent::GetStyleIndexForNode

* svg/svg_animate_element.cc in:
  * ComputeCSSPropertyValue
 
* view_transition/view_transition_style_tracker.cc in:
  * capture_property lamda. 
  * This one is only used for something called "border copying" and I checked with the VT folks that this is the right behavior.
  
Some of this need a closer look to determine if we should pass kComputedValue or kResolvedValue, the two suspects are the html_forms and svg_animate ones. But that's outside the scope of this change.

Open in Gerrit

Related details

Attention is currently required from:

Alison Maher

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Alison Maher (Gerrit)

unread,

12:36 PM (8 hours ago) 12:36 PM

to Sam Davis Omekara, Kevin Babbitt, Chromium LUCI CQ, Olga Gerchikov, AyeAye, Alexis Menard, Chromium Metrics Reviews, chromium...@chromium.org, chromium-a...@chromium.org, rouslan+au...@chromium.org, extension...@chromium.org, peilinwa...@google.com, asvitki...@chromium.org, dtapuska+...@chromium.org, mfoltz...@chromium.org, browser-comp...@chromium.org, blink-revi...@chromium.org, zol...@webkit.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, apavlo...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, bmcquad...@chromium.org, csharris...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org

Attention needed from Sam Davis Omekara

Alison Maher voted and added 1 comment

Votes added by Alison Maher

Code-Review

+1

1 comment

File third_party/blink/renderer/core/css/properties/longhands/longhands_custom.cc

Line 2807, Patchset 14: bool is_legacy_column_rule =

Alison Maher

Hmm ok as long as this is tracking the cases we care about, that's fine by me

Open in Gerrit

Related details

Attention is currently required from:

Sam Davis Omekara

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Sam Davis Omekara (Gerrit)

unread,

12:39 PM (8 hours ago) 12:39 PM

to Alison Maher, Kevin Babbitt, Chromium LUCI CQ, Olga Gerchikov, AyeAye, Alexis Menard, Chromium Metrics Reviews, chromium...@chromium.org, chromium-a...@chromium.org, rouslan+au...@chromium.org, extension...@chromium.org, peilinwa...@google.com, asvitki...@chromium.org, dtapuska+...@chromium.org, mfoltz...@chromium.org, browser-comp...@chromium.org, blink-revi...@chromium.org, zol...@webkit.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, apavlo...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, bmcquad...@chromium.org, csharris...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org

Sam Davis Omekara voted and added 1 comment

Votes added by Sam Davis Omekara

Commit-Queue

+2

1 comment

File third_party/blink/renderer/core/css/properties/longhands/longhands_custom.cc

Line 2807, Patchset 14:

  bool is_legacy_column_rule =
      style.ColumnRuleWidthInternal().HasSingleValue() &&
      style.ColumnRuleStyle().HasSingleValue();

  // Record use counter for the `column-rule-width` property if its resolved
  // value is non-zero and the corresponding style is "none" or "hidden". This
  // is to evaluate web compat risk in changing the behavior of
  // `column-rule-width` to be independent of the `column-rule-style`.
  //
  // https://github.com/w3c/csswg-drafts/issues/11494#issuecomment-2675800489
  if (is_legacy_column_rule && value_phase == CSSValuePhase::kResolvedValue &&
      layout_object) {
    int width_value = style.ColumnRuleWidthInternal().GetLegacyValue();
    EBorderStyle style_value = style.ColumnRuleStyle().GetLegacyValue();
    if (width_value != 0 && (style_value == EBorderStyle::kNone ||
                             style_value == EBorderStyle::kHidden)) {
      layout_object->GetDocument().CountUse(
          WebFeature::kResolvedColumnRuleWidthWithNoneOrHiddenStyle);
    }
  }

Alison Maher . resolved

It thought this only had web compat risk if it was queried, not just if it resolved to the legacy value. Will this only be kResolvedValue if an author queries this themselves?

Kevin Babbitt

It thought this only had web compat risk if it was queried, not just if it resolved to the legacy value.
That should be the case. When the style is `none` or `hidden`, the rendering will be the same either with or without the behavior change, since column-rule and outline don't affect layout. The only observable difference is the value queried via getComputedStyle().
Will this only be kResolvedValue if an author queries this themselves?
Sam Davis can answer for sure, but I'd expect the answer to be "yes." Resolved values are intended specifically for getComputedStyle(). Internal codepaths that need the used value should be asking the ComputedStyle object for values rather than coming through here.

Sam Davis Omekara

Yes, like Kevin mentioned, the observable difference will be when the value is queried via getComputedStyle() since there's no rendering difference.
In terms of the `value_phase` being kResolved value, the primary place where this is css_computed_style_declaration.cc (which I'm guessing corresponds to what powers getComputedStyle).
That's not the *only* path though, there are some others that seem like one offs like:
* html/forms/internal_popup_menu.cc in:
  * SerializeComputedStyleForProperty                                              
* inspector/inspector_dom_snapshot_agent.cc in:
  * InspectorDOMSnapshotAgent::BuildStylesForNode
* inspector/legacy_dom_snapshot_agent.cc in:
  * LegacyDOMSnapshotAgent::GetStyleIndexForNode
* svg/svg_animate_element.cc in:
  * ComputeCSSPropertyValue
 
* view_transition/view_transition_style_tracker.cc in:
  * capture_property lamda. 
  * This one is only used for something called "border copying" and I checked with the VT folks that this is the right behavior.
  
Some of this need a closer look to determine if we should pass kComputedValue or kResolvedValue, the two suspects are the html_forms and svg_animate ones. But that's outside the scope of this change.

Alison Maher

Hmm ok as long as this is tracking the cases we care about, that's fine by me

Sam Davis Omekara

Done

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Sam Davis Omekara (Gerrit)

unread,

12:42 PM (8 hours ago) 12:42 PM

to Nicolás Peña, Alison Maher, Kevin Babbitt, Chromium LUCI CQ, Olga Gerchikov, AyeAye, Alexis Menard, Chromium Metrics Reviews, chromium...@chromium.org, chromium-a...@chromium.org, rouslan+au...@chromium.org, extension...@chromium.org, peilinwa...@google.com, asvitki...@chromium.org, dtapuska+...@chromium.org, mfoltz...@chromium.org, browser-comp...@chromium.org, blink-revi...@chromium.org, zol...@webkit.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, apavlo...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, bmcquad...@chromium.org, csharris...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org

Attention needed from Nicolás Peña

Sam Davis Omekara added 1 comment

Patchset-level comments

File-level comment, Patchset 15 (Latest):

Sam Davis Omekara . resolved

@n...@chromium.org: For chrome/browser/page_load_metrics/*

Open in Gerrit

Related details

Attention is currently required from:

Nicolás Peña

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Nicolás Peña (Gerrit)

unread,

1:47 PM (6 hours ago) 1:47 PM

to Sam Davis Omekara, Alison Maher, Kevin Babbitt, Chromium LUCI CQ, Olga Gerchikov, AyeAye, Alexis Menard, Chromium Metrics Reviews, chromium...@chromium.org, chromium-a...@chromium.org, rouslan+au...@chromium.org, extension...@chromium.org, peilinwa...@google.com, asvitki...@chromium.org, dtapuska+...@chromium.org, mfoltz...@chromium.org, browser-comp...@chromium.org, blink-revi...@chromium.org, zol...@webkit.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, apavlo...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, bmcquad...@chromium.org, csharris...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org

Attention needed from Sam Davis Omekara

Nicolás Peña voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Sam Davis Omekara

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Sam Davis Omekara (Gerrit)

unread,

1:50 PM (6 hours ago) 1:50 PM

to Nicolás Peña, Alison Maher, Kevin Babbitt, Chromium LUCI CQ, Olga Gerchikov, AyeAye, Alexis Menard, Chromium Metrics Reviews, chromium...@chromium.org, chromium-a...@chromium.org, rouslan+au...@chromium.org, extension...@chromium.org, peilinwa...@google.com, asvitki...@chromium.org, dtapuska+...@chromium.org, mfoltz...@chromium.org, browser-comp...@chromium.org, blink-revi...@chromium.org, zol...@webkit.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, apavlo...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, bmcquad...@chromium.org, csharris...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org

Sam Davis Omekara voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

2:10 PM (6 hours ago) 2:10 PM

to Sam Davis Omekara, Nicolás Peña, Alison Maher, Kevin Babbitt, Olga Gerchikov, AyeAye, Alexis Menard, Chromium Metrics Reviews, chromium...@chromium.org, chromium-a...@chromium.org, rouslan+au...@chromium.org, extension...@chromium.org, peilinwa...@google.com, asvitki...@chromium.org, dtapuska+...@chromium.org, mfoltz...@chromium.org, browser-comp...@chromium.org, blink-revi...@chromium.org, zol...@webkit.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, apavlo...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, bmcquad...@chromium.org, csharris...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

Add use counter for disengangling resolved values change

This CL introduces granular use counters for the ouline-width and
column-rule-width CSS properties affected by the disentanglement work in
crrev.com/c/6909751. These counters are property-specific to accurately
measure usage and assess potential web compatibility risks resulting
from the CSS issue resolution [1], which led to decoupling the
outline-width and column-rule-width resolved values from their
corresponding style values.

[1]:
https://github.com/w3c/csswg-drafts/issues/11494#issuecomment-2675800489

Bug: 393631108

Change-Id: Ie5b46a47d34647d386e65097e49c6b914901e3ba

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6932565

Commit-Queue: Sam Davis Omekara <samome...@microsoft.com>

Reviewed-by: Alison Maher <alm...@microsoft.com>

Reviewed-by: Kevin Babbitt <kbab...@microsoft.com>

Reviewed-by: Nicolás Peña <n...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1520755}

Files:

M chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc
M third_party/blink/public/mojom/use_counter/metrics/web_feature.mojom
M third_party/blink/renderer/core/css/properties/longhands/longhands_custom.cc
M third_party/blink/renderer/platform/runtime_enabled_features.json5
M tools/metrics/histograms/metadata/blink/enums.xml

Change size: M

Delta: 5 files changed, 107 insertions(+), 6 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Nicolás Peña, +1 by Alison Maher, +1 by Kevin Babbitt

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

Add use counter for disengangling resolved values change [chromium/src : main]

Sam Davis Omekara (Gerrit)

Message from Sam Davis Omekara

Related details

Alison Maher (Gerrit)

Alison Maher added 1 comment

Related details

Kevin Babbitt (Gerrit)

Kevin Babbitt voted and added 1 comment

Votes added by Kevin Babbitt

1 comment

Related details

Sam Davis Omekara (Gerrit)

Sam Davis Omekara added 1 comment

Related details

Alison Maher (Gerrit)

Alison Maher voted and added 1 comment

Votes added by Alison Maher

1 comment

Related details

Sam Davis Omekara (Gerrit)

Sam Davis Omekara voted and added 1 comment

Votes added by Sam Davis Omekara

1 comment

Related details

Sam Davis Omekara (Gerrit)

Sam Davis Omekara added 1 comment

Related details

Nicolás Peña (Gerrit)

Nicolás Peña voted Code-Review+1

Related details

Sam Davis Omekara (Gerrit)

Sam Davis Omekara voted Commit-Queue+2

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change

Change information