Use heuristic predictions over server for loyalty cards. [chromium/src : main]
0 views
Skip to first unread message
Piotr Wrótniak (Gerrit)
Jun 12, 2025, 6:09:46 AM6/12/25
to Norge Vizcay, chromium...@chromium.org, browser-comp...@chromium.org, rouslan+au...@chromium.org
Attention needed from Norge Vizcay
Piotr Wrótniak voted Auto-Submit+1![]( "Open in Gerrit")
| Auto-Submit | +1 |
Related details
Attention is currently required from:
- Norge Vizcay
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Norge Vizcay (Gerrit)
Jun 12, 2025, 6:25:17 AM6/12/25
to Piotr Wrótniak, chromium...@chromium.org, browser-comp...@chromium.org, rouslan+au...@chromium.org
Attention needed from Piotr Wrótniak
Norge Vizcay added 2 comments![]( "Open in Gerrit")
Patchset-level comments
Commit Message
Line 12, Patchset 1 (Latest):
Norge Vizcay . unresolved
Can you create a card for american airlines and show how it's displayed? Chrome should display the matching UI.
Related details
Attention is currently required from:
- Piotr Wrótniak
Submit Requirements:
Code-Coverage
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Piotr Wrótniak (Gerrit)
Jun 12, 2025, 7:39:49 AM6/12/25
to Norge Vizcay, chromium...@chromium.org, browser-comp...@chromium.org, rouslan+au...@chromium.org
Attention needed from Norge Vizcay
Piotr Wrótniak voted and added 2 comments![]( "Open in Gerrit")
Votes added by Piotr Wrótniak
| Auto-Submit | +1 |
Should we add some tests?
Piotr Wrótniak
Noone did that before I think looking at couple other CLs but added.
Commit Message
Can you create a card for american airlines and show how it's displayed? Chrome should display the matching UI.
Piotr Wrótniak
It doesn't work as the merchant domains are empty: https://screenshot.googleplex.com/8Kwd6wVqDvfbF3z looking into whether we have a bug or it doesn't come at all, but this is not blocking this.
Related details
Attention is currently required from:
- Norge Vizcay
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Norge Vizcay (Gerrit)
Jun 12, 2025, 8:58:20 AM6/12/25
to Piotr Wrótniak, Chromium LUCI CQ, chromium...@chromium.org, browser-comp...@chromium.org, rouslan+au...@chromium.org
Attention needed from Piotr Wrótniak
Norge Vizcay voted![]( "Open in Gerrit")
Attention is currently required from:
- Piotr Wrótniak
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Norge Vizcay (Gerrit)
Jun 12, 2025, 8:59:31 AM6/12/25
to Piotr Wrótniak, Chromium LUCI CQ, chromium...@chromium.org, browser-comp...@chromium.org, rouslan+au...@chromium.org
Attention needed from Piotr Wrótniak
Norge Vizcay voted![]( "Open in Gerrit")
| Code-Review | +0 |
| Commit-Queue | +0 |
Related details
Attention is currently required from:
- Piotr Wrótniak
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Norge Vizcay (Gerrit)
Jun 12, 2025, 9:02:26 AM6/12/25
to Piotr Wrótniak, Chromium LUCI CQ, chromium...@chromium.org, browser-comp...@chromium.org, rouslan+au...@chromium.org
Attention needed from Piotr Wrótniak
Norge Vizcay added 1 comment![]( "Open in Gerrit")
File components/autofill/core/browser/autofill_field.cc
Line 549, Patchset 2 (Latest):
believe_server =
believe_server && (heuristic_type_local != LOYALTY_MEMBERSHIP_ID);Norge Vizcay . unresolved
Will this override all server predictions? Or just those where the server type is unknown? I am not entirely sure we want to override **all** server predictions.
Related details
Attention is currently required from:
- Piotr Wrótniak
Submit Requirements:
Code-Coverage
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Piotr Wrótniak (Gerrit)
Jun 12, 2025, 9:11:35 AM6/12/25
to Norge Vizcay, Chromium LUCI CQ, chromium...@chromium.org, browser-comp...@chromium.org, rouslan+au...@chromium.org
Attention needed from Norge Vizcay
Piotr Wrótniak voted and added 1 comment![]( "Open in Gerrit")
Votes added by Piotr Wrótniak
| Auto-Submit | +1 |
1 comment
File components/autofill/core/browser/autofill_field.cc
Line 549, Patchset 2:
believe_server =
believe_server && (heuristic_type_local != LOYALTY_MEMBERSHIP_ID);Norge Vizcay . resolved
Will this override all server predictions? Or just those where the server type is unknown? I am not entirely sure we want to override **all** server predictions.
Piotr Wrótniak
I'd guess that we're confident with regexps like `Loyalty card` enough (and so similarly 5 fields above override all server predictions) but sure - changed.
Related details
Attention is currently required from:
- Norge Vizcay
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Piotr Wrótniak (Gerrit)
Jun 12, 2025, 9:12:59 AM6/12/25
to Norge Vizcay, Chromium LUCI CQ, chromium...@chromium.org, browser-comp...@chromium.org, rouslan+au...@chromium.org
Attention needed from Norge Vizcay
Piotr Wrótniak voted Auto-Submit+0![]( "Open in Gerrit")
| Auto-Submit | +0 |
Related details
Attention is currently required from:
- Norge Vizcay
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages