Remove unused PageContentAnnotationsWebContentsObserver members [chromium/src : main]

0 views
Skip to first unread message

Mike Wittman (Gerrit)

unread,
Jan 13, 2026, 2:08:28 PMJan 13
to Mike Wittman, Steven Holte, chromium...@chromium.org, AyeAye, Chromium LUCI CQ, mfoltz+wa...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com
Attention needed from Steven Holte

Mike Wittman voted and added 1 comment

Votes added by Mike Wittman

Auto-Submit+1

1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Mike Wittman . resolved

PTAL

Open in Gerrit

Related details

Attention is currently required from:
  • Steven Holte
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I5c36b514b130c1d5eaf4d5197b47701d6ae727d7
Gerrit-Change-Number: 7454827
Gerrit-PatchSet: 2
Gerrit-Owner: Mike Wittman <wit...@chromium.org>
Gerrit-Reviewer: Mike Wittman <wit...@chromium.org>
Gerrit-Reviewer: Steven Holte <ho...@chromium.org>
Gerrit-Attention: Steven Holte <ho...@chromium.org>
Gerrit-Comment-Date: Tue, 13 Jan 2026 19:08:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Steven Holte (Gerrit)

unread,
Jan 13, 2026, 2:49:24 PMJan 13
to Mike Wittman, Steven Holte, chromium...@chromium.org, AyeAye, Chromium LUCI CQ, mfoltz+wa...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com
Attention needed from Mike Wittman

Steven Holte voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Mike Wittman
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I5c36b514b130c1d5eaf4d5197b47701d6ae727d7
    Gerrit-Change-Number: 7454827
    Gerrit-PatchSet: 2
    Gerrit-Owner: Mike Wittman <wit...@chromium.org>
    Gerrit-Reviewer: Mike Wittman <wit...@chromium.org>
    Gerrit-Reviewer: Steven Holte <ho...@chromium.org>
    Gerrit-Attention: Mike Wittman <wit...@chromium.org>
    Gerrit-Comment-Date: Tue, 13 Jan 2026 19:48:57 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Mike Wittman (Gerrit)

    unread,
    Jan 13, 2026, 2:52:15 PMJan 13
    to Mike Wittman, Steven Holte, chromium...@chromium.org, AyeAye, Chromium LUCI CQ, mfoltz+wa...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com

    Mike Wittman voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I5c36b514b130c1d5eaf4d5197b47701d6ae727d7
    Gerrit-Change-Number: 7454827
    Gerrit-PatchSet: 2
    Gerrit-Owner: Mike Wittman <wit...@chromium.org>
    Gerrit-Reviewer: Mike Wittman <wit...@chromium.org>
    Gerrit-Reviewer: Steven Holte <ho...@chromium.org>
    Gerrit-Comment-Date: Tue, 13 Jan 2026 19:52:04 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Jan 13, 2026, 2:55:26 PMJan 13
    to Mike Wittman, Steven Holte, chromium...@chromium.org, AyeAye, mfoltz+wa...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Remove unused PageContentAnnotationsWebContentsObserver members
    Bug: 469120965
    Change-Id: I5c36b514b130c1d5eaf4d5197b47701d6ae727d7
    Reviewed-by: Steven Holte <ho...@chromium.org>
    Commit-Queue: Mike Wittman <wit...@chromium.org>
    Auto-Submit: Mike Wittman <wit...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1568607}
    Files:
    • M chrome/browser/page_content_annotations/page_content_annotations_web_contents_observer.cc
    • M chrome/browser/page_content_annotations/page_content_annotations_web_contents_observer.h
    Change size: S
    Delta: 2 files changed, 0 insertions(+), 19 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Steven Holte
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I5c36b514b130c1d5eaf4d5197b47701d6ae727d7
    Gerrit-Change-Number: 7454827
    Gerrit-PatchSet: 3
    Gerrit-Owner: Mike Wittman <wit...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Mike Wittman <wit...@chromium.org>
    Gerrit-Reviewer: Steven Holte <ho...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages