[XDeviceSignin] Fix CrossDeviceSigninQrBubble auto-resizing and visibility [chromium/src : main]
David Roger (Gerrit)
New activity on the change![]( "Open in Gerrit")
Related details
- Pâris Meuleman
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Pâris Meuleman (Gerrit)
Pâris Meuleman voted and added 1 comment![]( "Open in Gerrit")
Votes added by Pâris Meuleman
| Code-Review | +1 |
1 comment
Overall LGTM % the few test fixes
I'm just wondering if we should just notify the UI is ready (i.e. UpdateViewHeight becomes just "Show[...]" )
Keeping EnableSizingFromWebContents letting the web_view doing the resizing by itself?
Related details
- David Roger
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
David Roger (Gerrit)
David Roger added 1 comment![]( "Open in Gerrit")
Overall LGTM % the few test fixes
I'm just wondering if we should just notify the UI is ready (i.e. UpdateViewHeight becomes just "Show[...]" )
Keeping EnableSizingFromWebContents letting the web_view doing the resizing by itself?
That's a good idea. Unfortunately I tried this approach and it did not work (it does not change the behavior compared to ToT).
I will keep the current approach and fix the tests.
Related details
- Pâris Meuleman
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Pâris Meuleman (Gerrit)
Pâris Meuleman added 1 comment![]( "Open in Gerrit")
David RogerOverall LGTM % the few test fixes
I'm just wondering if we should just notify the UI is ready (i.e. UpdateViewHeight becomes just "Show[...]" )
Keeping EnableSizingFromWebContents letting the web_view doing the resizing by itself?
That's a good idea. Unfortunately I tried this approach and it did not work (it does not change the behavior compared to ToT).
I will keep the current approach and fix the tests.
Even with ```SetPreferredSize``` ? too bad, thanks for trying!
Related details
- David Roger
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
David Roger (Gerrit)
David Roger added 1 comment![]( "Open in Gerrit")
- Chromium IPC Reviews
- Pâris Meuleman
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
gwsq (Gerrit)
Message from gwsq![]( "Open in Gerrit")
From googleclient/chrome/chromium_gwsq/ipc/config.gwsq:
IPC: mk...@chromium.org
📎 It looks like you’re making a possibly security-sensitive change! 📎 IPC security review isn’t a rubberstamp, so your friendly security reviewer will need a fair amount of context to review your CL effectively. Please review your CL description and code comments to make sure they provide context for someone unfamiliar with your project/area. Pay special attention to where data comes from and which processes it flows between (and their privilege levels). Feel free to point your security reviewer at design docs, bugs, or other links if you can’t reasonably make a self-contained CL description. (Also see https://cbea.ms/git-commit/).
IPC reviewer(s): mk...@chromium.org
Reviewer source(s):
mk...@chromium.org is from context(googleclient/chrome/chromium_gwsq/ipc/config.gwsq)
Related details
- Mike West
- Pâris Meuleman
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
David Roger (Gerrit)
David Roger added 1 comment![]( "Open in Gerrit")
Paris: PTAL (lost the +1 due to test changes)