[FilesTrash] Return kSuccess when no sources supplied [chromium/src : main]
Ben Reich (Gerrit)
Attention is currently required from: Luciano Pacheco.
To view, visit change 3818044. To unsubscribe, or for help writing mail filters, visit settings.
Luciano Pacheco (Gerrit)
Attention is currently required from: Ben Reich.
Patch set 1:Code-Review +1
1 comment:
Patchset:
But I'd recommend 2 new unittest to make sure these aren't removed by accident.
To view, visit change 3818044. To unsubscribe, or for help writing mail filters, visit settings.
Ben Reich (Gerrit)
Attention is currently required from: Luciano Pacheco.
Patch set 2:Auto-Submit +1Commit-Queue +1
2 comments:
Patchset:
But I'd recommend 2 new unittest to make sure these aren't removed by accident.
Done.
Patchset:
... and now my +1 has been revoked 😞
To view, visit change 3818044. To unsubscribe, or for help writing mail filters, visit settings.
Luciano Pacheco (Gerrit)
Attention is currently required from: Ben Reich.
Patch set 2:Code-Review +1Commit-Queue +2
1 comment:
Patchset:
... […]
Here have another one.
To view, visit change 3818044. To unsubscribe, or for help writing mail filters, visit settings.
Chromium LUCI CQ (Gerrit)
Chromium LUCI CQ submitted this change.
[FilesTrash] Return kSuccess when no sources supplied
In Both TrashIOTask and RestoreIOTask the task can be called with empty
sources. At the moment we immediately try to validate the first index of
progress_.sources which (if empty) crashes. Avoid this by doing a size
check first and exiting early in that case.
Bug: b:241517469
Test: unit_tests --gtest_filter=*TrashIOTask*:*RestoreIOTask*
Change-Id: I91d7e7a83039aa3fff7ca9af582bc0a258132fa3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3818044
Auto-Submit: Ben Reich <benr...@chromium.org>
Commit-Queue: Luciano Pacheco <luc...@chromium.org>
Commit-Queue: Ben Reich <benr...@chromium.org>
Reviewed-by: Luciano Pacheco <luc...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1032887}
---
M chrome/browser/ash/file_manager/restore_io_task.cc
M chrome/browser/ash/file_manager/restore_io_task_unittest.cc
M chrome/browser/ash/file_manager/trash_io_task.cc
M chrome/browser/ash/file_manager/trash_io_task_unittest.cc
4 files changed, 70 insertions(+), 0 deletions(-)