[TreesInViz] Align GetHasDamageData() in renderer and viz. [chromium/src : main]
0 views
Skip to first unread message
Zhenyao Mo (Gerrit)
6:35 PM (2 hours ago) 6:35 PM
to Victor Miura, Vikas Soni, Tzarial, Chromium LUCI CQ, chromium...@chromium.org, cc-...@chromium.org, ipc-securi...@chromium.org
Attention needed from Victor Miura
Zhenyao Mo voted and added 1 comment![]( "Open in Gerrit")
Votes added by Zhenyao Mo
| Auto-Submit | +1 |
Related details
Attention is currently required from:
- Victor Miura
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Victor Miura (Gerrit)
7:23 PM (1 hour ago) 7:23 PM
to Zhenyao Mo, Vikas Soni, Tzarial, Chromium LUCI CQ, chromium...@chromium.org, cc-...@chromium.org, ipc-securi...@chromium.org
Attention needed from Zhenyao Mo
Victor Miura voted and added 2 comments![]( "Open in Gerrit")
Votes added by Victor Miura
| Code-Review | +1 |
2 comments
Patchset-level comments
Victor Miura . resolved
LGTM % nit
File cc/trees/layer_tree_impl.h
Line 829, Patchset 2 (Latest):
bool is_animating_hud_contents() const { return is_animating_hud_contents_; }Victor Miura . unresolved
nit: This implementation is fine, but it might be a little confusing that is_animating_hud_contents() doesn't do anything in the client mode.
What do you think about removing is_animating_hud_contents, and adding a IsAnimatingHudContents() method on LayerTreeImpl, and moving the logic there?
Related details
Attention is currently required from:
- Zhenyao Mo
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Zhenyao Mo (Gerrit)
8:44 PM (now) 8:44 PM
to Victor Miura, Vikas Soni, Tzarial, Chromium LUCI CQ, chromium...@chromium.org, cc-...@chromium.org, ipc-securi...@chromium.org
Attention needed from Victor Miura
Zhenyao Mo voted and added 1 comment![]( "Open in Gerrit")
Votes added by Zhenyao Mo
| Auto-Submit | +1 |
| Commit-Queue | +1 |
1 comment
File cc/trees/layer_tree_impl.h
Line 829, Patchset 2:
bool is_animating_hud_contents() const { return is_animating_hud_contents_; }Victor Miura . resolved
nit: This implementation is fine, but it might be a little confusing that is_animating_hud_contents() doesn't do anything in the client mode.
What do you think about removing is_animating_hud_contents, and adding a IsAnimatingHudContents() method on LayerTreeImpl, and moving the logic there?
Attention is currently required from:
- Victor Miura
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages