[Autofill] Remove AtMemory preview [chromium/src : main]

0 views
Skip to first unread message

Christoph Schwering (Gerrit)

unread,
7:10 PM (1 hour ago) 7:10 PM
to Jan Keitel, Chromium LUCI CQ, chromium...@chromium.org, browser-comp...@chromium.org
Attention needed from Jan Keitel

Christoph Schwering added 1 comment

File components/autofill/content/renderer/autofill_agent.cc
Line 1558, Patchset 2 (Parent): form_control.SetSuggestedValue(WebString::FromUtf16(preview_value));
Christoph Schwering . unresolved

I'm aware the discussion about preview is still going on, but to reduce the code duplication and unblock the following CLs I suggest to remove it for now.

Open in Gerrit

Related details

Attention is currently required from:
  • Jan Keitel
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I2cd04e1de9faae665f12e724a9027378a5464778
Gerrit-Change-Number: 8224404
Gerrit-PatchSet: 2
Gerrit-Owner: Christoph Schwering <schw...@google.com>
Gerrit-Reviewer: Christoph Schwering <schw...@google.com>
Gerrit-Reviewer: Jan Keitel <jke...@google.com>
Gerrit-Attention: Jan Keitel <jke...@google.com>
Gerrit-Comment-Date: Sun, 09 Aug 2026 23:10:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages