Brian Sheedy (Gerrit)

unread,

Sep 24, 2025, 7:45:09 PM (22 hours ago) Sep 24

to Struan Shrimpton, chromium...@chromium.org, estaab...@chromium.org

Attention needed from Struan Shrimpton

Brian Sheedy voted and added 2 comments

Votes added by Brian Sheedy

Auto-Submit	+1
Commit-Queue	+1

2 comments

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Brian Sheedy . resolved

PTAL

Feel free to punt on reviewing if you want to see other follow-up CLs for more context.

File agents/testing/eval_prompts.py

Line 24, Patchset 1 (Parent):EXTENSIONS_TO_INSTALL = [

Brian Sheedy . resolved

Unused.

Open in Gerrit

Related details

Attention is currently required from:

Struan Shrimpton

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Struan Shrimpton (Gerrit)

unread,

12:10 PM (6 hours ago) 12:10 PM

to Brian Sheedy, Chromium LUCI CQ, chromium...@chromium.org, estaab...@chromium.org

Attention needed from Brian Sheedy

Struan Shrimpton voted

Code-Review	+1
Commit-Queue	+2

Open in Gerrit

Related details

Attention is currently required from:

Brian Sheedy

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

12:13 PM (6 hours ago) 12:13 PM

to Brian Sheedy, Struan Shrimpton, chromium...@chromium.org, estaab...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

[3/?] Move WorkDir to new file

This is part of a chain of CLs to add support for multiple parallel
workers to //agents/testing/eval_prompts.py.

This CL moves the WorkDir class into a new workers.py file. This does
not currently provide any real benefit other than making eval_prompts.py
less monolithic, but additional worker-related code will be added to
this file in follow-up CLs.

Also performs two drive-by improvements:
1. Makes the result thread daemonic so that it does not block the
   Python process from exiting.
2. Updates the moved tests for WorkDir to share mock setup between tests
   instead of using repeated mock.patch annotations.

Bug: 445459870

Change-Id: I37562b2e31577972ec61d8e24dd6e2309aa773ab

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6981947

Auto-Submit: Brian Sheedy <bsh...@chromium.org>

Commit-Queue: Struan Shrimpton <ssh...@google.com>

Reviewed-by: Struan Shrimpton <ssh...@google.com>

Cr-Commit-Position: refs/heads/main@{#1520664}

Files:

M agents/testing/eval_prompts.py
M agents/testing/eval_prompts_unittest.py
M agents/testing/results.py
A agents/testing/workers.py
A agents/testing/workers_unittest.py

Change size: L

Delta: 5 files changed, 264 insertions(+), 246 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Struan Shrimpton

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

[3/?] Move WorkDir to new file [chromium/src : main]

Brian Sheedy (Gerrit)

Brian Sheedy voted and added 2 comments

Votes added by Brian Sheedy

2 comments

Related details

Struan Shrimpton (Gerrit)

Struan Shrimpton voted

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change

Change information