[ozone/wayland] Add support for wl_fixes.ack_global_remove [chromium/src : main]
0 views
Skip to first unread message
Vlad Zahorodnii (Gerrit)
Jul 16, 2026, 5:15:42 PM (5 days ago) Jul 16
to Thomas Anderson, Kramer Ge, Nick Yamane, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Kramer Ge, Nick Yamane and Thomas Anderson
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Kramer Ge
- Nick Yamane
- Thomas Anderson
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Vlad Zahorodnii (Gerrit)
Jul 16, 2026, 5:16:14 PM (5 days ago) Jul 16
to Thomas Anderson, Kramer Ge, Nick Yamane, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Kramer Ge, Nick Yamane and Thomas Anderson
Vlad Zahorodnii added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Vlad Zahorodnii . resolved
You can also find more information about the race here https://blog.vladzahorodnii.com/2026/03/24/addressing-global-removal-race-in-wayland/
Thomas Anderson (Gerrit)
Jul 20, 2026, 5:17:05 PM (yesterday) Jul 20
to Vlad Zahorodnii, Kramer Ge, Nick Yamane, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Kramer Ge, Nick Yamane and Vlad Zahorodnii
Thomas Anderson voted and added 2 comments![]( "Open in Gerrit")
Votes added by Thomas Anderson
| Code-Review | +1 |
2 comments
Patchset-level comments
Thomas Anderson . resolved
lgtm, please wait for Kramer's secondary approval before submitting this change
File ui/ozone/platform/wayland/host/wayland_connection.cc
Line 592, Patchset 2 (Latest):
if (self->fixes_ && wl_fixes_get_version(self->fixes_.get()) >=Thomas Anderson . unresolved
nit: use wl::get_version_of_object:
```
if (self->fixes_ && wl::get_version_of_object(self->fixes_.get()) >=
WL_FIXES_ACK_GLOBAL_REMOVE_SINCE_VERSION) {
```
Related details
Attention is currently required from:
- Kramer Ge
- Nick Yamane
- Vlad Zahorodnii
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Vlad Zahorodnii (Gerrit)
1:48 AM (17 hours ago) 1:48 AM
to Thomas Anderson, Kramer Ge, Nick Yamane, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Kramer Ge, Nick Yamane and Thomas Anderson
Vlad Zahorodnii added 1 comment![]( "Open in Gerrit")
File ui/ozone/platform/wayland/host/wayland_connection.cc
Line 592, Patchset 2:
if (self->fixes_ && wl_fixes_get_version(self->fixes_.get()) >=Thomas Anderson . resolved
nit: use wl::get_version_of_object:
```
if (self->fixes_ && wl::get_version_of_object(self->fixes_.get()) >=
WL_FIXES_ACK_GLOBAL_REMOVE_SINCE_VERSION) {
```
Attention is currently required from:
- Kramer Ge
- Nick Yamane
- Thomas Anderson
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kramer Ge (Gerrit)
4:13 PM (3 hours ago) 4:13 PM
to Vlad Zahorodnii, Thomas Anderson, Nick Yamane, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Nick Yamane, Thomas Anderson and Vlad Zahorodnii
Kramer Ge voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Nick Yamane
- Thomas Anderson
- Vlad Zahorodnii
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages