[Blink] Implement CRC::PaintRenderingResultsToSnapshot() in subclasses [chromium/src : main]

0 views

Skip to first unread message

Vasiliy Telezhnikov (Gerrit)

unread,

Jun 12, 2025, 9:21:04 AM6/12/25

to Colin Blundell, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, cwalle...@chromium.org, kainin...@chromium.org

Attention needed from Colin Blundell

Vasiliy Telezhnikov voted and added 1 comment

Votes added by Vasiliy Telezhnikov

Code-Review

1 comment

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Vasiliy Telezhnikov . resolved

lgtm, thanks.

Open in Gerrit

Related details

Attention is currently required from:

Colin Blundell

Submit Requirements:

Code-Coverage
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Jun 13, 2025, 5:18:33 AM6/13/25

to Colin Blundell, Vasiliy Telezhnikov, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, cwalle...@chromium.org, kainin...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

[Blink] Implement CRC::PaintRenderingResultsToSnapshot() in subclasses

Rather than providing a default implementation, make this method pure
virtual. This will allow for moving the non-2D implementations away
from using the canvas' CanvasResourceProvider (or potentially *any*
CanvasResourceProvider) in followup.

Bug: 352263194

Change-Id: I562bebfcb8b887f23bea2be11a5ab49dabf6fdb5

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6633970

Reviewed-by: Vasiliy Telezhnikov <vas...@chromium.org>

Commit-Queue: Colin Blundell <blun...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1473431}

Files:

M third_party/blink/renderer/core/html/canvas/canvas_rendering_context.cc
M third_party/blink/renderer/core/html/canvas/canvas_rendering_context.h
M third_party/blink/renderer/modules/canvas/canvas2d/base_rendering_context_2d.cc
M third_party/blink/renderer/modules/canvas/canvas2d/base_rendering_context_2d.h
M third_party/blink/renderer/modules/canvas/imagebitmap/image_bitmap_rendering_context_base.cc
M third_party/blink/renderer/modules/canvas/imagebitmap/image_bitmap_rendering_context_base.h
M third_party/blink/renderer/modules/webgl/webgl_rendering_context_base.cc
M third_party/blink/renderer/modules/webgl/webgl_rendering_context_base.h
M third_party/blink/renderer/modules/webgl/webgl_rendering_context_webgpu_base.cc
M third_party/blink/renderer/modules/webgl/webgl_rendering_context_webgpu_base.h
M third_party/blink/renderer/modules/webgpu/gpu_canvas_context.cc
M third_party/blink/renderer/modules/webgpu/gpu_canvas_context.h

Change size: M

Delta: 12 files changed, 68 insertions(+), 16 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Vasiliy Telezhnikov

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages