Reverting r133134 - Make sure that base::MessagePumpForUI from different modules are isolated from … (issue 10384209)
0 views
Skip to first unread message
alex...@chromium.org
May 16, 2012, 4:22:36 PM5/16/12
to alex...@chromium.org, j...@chromium.org, w...@chromium.org, chromium...@chromium.org, erikw...@chromium.org, sad...@chromium.org, bret...@chromium.org
Reviewers: alexeypa, jar, Wez,
Message:
Please take a look.
Description:
Reverting r133134 - Make sure that base::MessagePumpForUI from different
modules
are isolated from each other and add protection from shatter attacks by
placing
|this| pointer to the used data associated with the message-only window
(instead
of blindly trusting the value of WPARAM).
We suspect that r133134 might be causing issues like 124091, so it needs to
be
reworked.
BUG=124091,127933
TBR=alex...@chromium.org
Please review this at https://chromiumcodereview.appspot.com/10384209/
SVN Base: svn://svn.chromium.org/chrome/trunk/src
Affected files:
M base/message_pump_win.h
M base/message_pump_win.cc
M base/process_util.h
M base/process_util_win.cc
Message:
Please take a look.
Description:
Reverting r133134 - Make sure that base::MessagePumpForUI from different
modules
are isolated from each other and add protection from shatter attacks by
placing
|this| pointer to the used data associated with the message-only window
(instead
of blindly trusting the value of WPARAM).
We suspect that r133134 might be causing issues like 124091, so it needs to
be
reworked.
BUG=124091,127933
TBR=alex...@chromium.org
Please review this at https://chromiumcodereview.appspot.com/10384209/
SVN Base: svn://svn.chromium.org/chrome/trunk/src
Affected files:
M base/message_pump_win.h
M base/message_pump_win.cc
M base/process_util.h
M base/process_util_win.cc
w...@chromium.org
May 16, 2012, 5:01:35 PM5/16/12
to alex...@chromium.org, j...@chromium.org, chromium...@chromium.org, erikw...@chromium.org, sad...@chromium.org, bret...@chromium.org
On 2012/05/16 20:22:36, alexeypa wrote:
> Please take a look.
Is this a straight revert of the original CL, in which case you can just
drover-land it?
https://chromiumcodereview.appspot.com/10384209/
> Please take a look.
Is this a straight revert of the original CL, in which case you can just
drover-land it?
https://chromiumcodereview.appspot.com/10384209/
alex...@chromium.org
May 16, 2012, 5:07:13 PM5/16/12
to alex...@chromium.org, j...@chromium.org, w...@chromium.org, chromium...@chromium.org, erikw...@chromium.org, sad...@chromium.org, bret...@chromium.org
On 2012/05/16 21:01:34, Wez wrote:
> On 2012/05/16 20:22:36, alexeypa wrote:
> > Please take a look.
> Is this a straight revert of the original CL, in which case you can just
> drover-land it?
No, I had to resolve conflicts in base/message_pump_win.cc.
> On 2012/05/16 20:22:36, alexeypa wrote:
> > Please take a look.
> Is this a straight revert of the original CL, in which case you can just
> drover-land it?
https://chromiumcodereview.appspot.com/10384209/
w...@chromium.org
May 16, 2012, 5:13:55 PM5/16/12
to alex...@chromium.org, j...@chromium.org, chromium...@chromium.org, erikw...@chromium.org, sad...@chromium.org, bret...@chromium.org
j...@chromium.org
May 16, 2012, 6:13:29 PM5/16/12
to alex...@chromium.org, w...@chromium.org, chromium...@chromium.org, erikw...@chromium.org, sad...@chromium.org, bret...@chromium.org
Reply all
Reply to author
Forward
0 new messages