[sync] Remove SyncedBookmarkTracker::UpdateServerId() [chromium/src : main]

0 views
Skip to first unread message

Mikel Astiz (Gerrit)

unread,
5:19 AM (2 hours ago) 5:19 AM
to Rushan Suleymanov, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Rushan Suleymanov

Mikel Astiz voted Commit-Queue+0

Commit-Queue+0
Open in Gerrit

Related details

Attention is currently required from:
  • Rushan Suleymanov
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ia79897d6cd5036b74feeb8405de5055139c6526e
Gerrit-Change-Number: 8137717
Gerrit-PatchSet: 1
Gerrit-Owner: Mikel Astiz <mas...@chromium.org>
Gerrit-Reviewer: Mikel Astiz <mas...@chromium.org>
Gerrit-Reviewer: Rushan Suleymanov <rus...@google.com>
Gerrit-Attention: Rushan Suleymanov <rus...@google.com>
Gerrit-Comment-Date: Fri, 24 Jul 2026 09:18:41 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Rushan Suleymanov (Gerrit)

unread,
5:27 AM (2 hours ago) 5:27 AM
to Mikel Astiz, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Mikel Astiz

Rushan Suleymanov voted and added 1 comment

Votes added by Rushan Suleymanov

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Rushan Suleymanov . resolved

Nice, thank you!

Open in Gerrit

Related details

Attention is currently required from:
  • Mikel Astiz
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ia79897d6cd5036b74feeb8405de5055139c6526e
    Gerrit-Change-Number: 8137717
    Gerrit-PatchSet: 2
    Gerrit-Owner: Mikel Astiz <mas...@chromium.org>
    Gerrit-Reviewer: Mikel Astiz <mas...@chromium.org>
    Gerrit-Reviewer: Rushan Suleymanov <rus...@google.com>
    Gerrit-Attention: Mikel Astiz <mas...@chromium.org>
    Gerrit-Comment-Date: Fri, 24 Jul 2026 09:27:26 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Mikel Astiz (Gerrit)

    unread,
    5:35 AM (1 hour ago) 5:35 AM
    to Rushan Suleymanov, Chromium LUCI CQ, chromium...@chromium.org

    Mikel Astiz voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ia79897d6cd5036b74feeb8405de5055139c6526e
    Gerrit-Change-Number: 8137717
    Gerrit-PatchSet: 2
    Gerrit-Owner: Mikel Astiz <mas...@chromium.org>
    Gerrit-Reviewer: Mikel Astiz <mas...@chromium.org>
    Gerrit-Reviewer: Rushan Suleymanov <rus...@google.com>
    Gerrit-Comment-Date: Fri, 24 Jul 2026 09:31:12 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    6:07 AM (1 hour ago) 6:07 AM
    to Mikel Astiz, Rushan Suleymanov, chromium...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    [sync] Remove SyncedBookmarkTracker::UpdateServerId()

    This patch removes SyncedBookmarkTracker::UpdateServerId() from
    SyncedBookmarkTracker, as well as RecordAcceptedRemoteUpdate() which
    became trivial.

    Instead, server ID updates are fully encapsulated inside
    SyncedBookmarkTrackerEntity domain methods (RecordAcceptedRemoteUpdate,
    RecordIgnoredRemoteUpdate, and OverrideServerMetadata), matching
    ClientTagBasedModelTypeProcessor.
    Bug: 40823197
    Change-Id: Ia79897d6cd5036b74feeb8405de5055139c6526e
    Reviewed-by: Rushan Suleymanov <rus...@google.com>
    Commit-Queue: Mikel Astiz <mas...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1667750}
    Files:
    • M components/sync_bookmarks/bookmark_remote_updates_handler.cc
    • M components/sync_bookmarks/synced_bookmark_tracker.cc
    • M components/sync_bookmarks/synced_bookmark_tracker.h
    • M components/sync_bookmarks/synced_bookmark_tracker_entity.cc
    • M components/sync_bookmarks/synced_bookmark_tracker_entity.h
    • M components/sync_bookmarks/synced_bookmark_tracker_unittest.cc
    Change size: M
    Delta: 6 files changed, 34 insertions(+), 61 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Rushan Suleymanov
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ia79897d6cd5036b74feeb8405de5055139c6526e
    Gerrit-Change-Number: 8137717
    Gerrit-PatchSet: 3
    Gerrit-Owner: Mikel Astiz <mas...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Mikel Astiz <mas...@chromium.org>
    Gerrit-Reviewer: Rushan Suleymanov <rus...@google.com>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages