Split Element::HandleInterestForHoverOrFocus. [chromium/src : main]

0 views
Skip to first unread message

David Baron (Gerrit)

unread,
Feb 26, 2026, 11:05:06 AM (2 days ago) Feb 26
to David Baron, Mason Freed, chromium...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org
Attention needed from Mason Freed

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Mason Freed
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I50034853487ef1ec3f154758d38ec9838c0bbe92
Gerrit-Change-Number: 7613567
Gerrit-PatchSet: 1
Gerrit-Owner: David Baron <dba...@chromium.org>
Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
Gerrit-Attention: Mason Freed <mas...@chromium.org>
Gerrit-Comment-Date: Thu, 26 Feb 2026 16:04:59 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Mason Freed (Gerrit)

unread,
Feb 27, 2026, 5:53:31 PM (8 hours ago) Feb 27
to David Baron, chromium...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org
Attention needed from David Baron

Mason Freed voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • David Baron
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I50034853487ef1ec3f154758d38ec9838c0bbe92
    Gerrit-Change-Number: 7613567
    Gerrit-PatchSet: 2
    Gerrit-Owner: David Baron <dba...@chromium.org>
    Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
    Gerrit-Attention: David Baron <dba...@chromium.org>
    Gerrit-Comment-Date: Fri, 27 Feb 2026 22:53:24 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    David Baron (Gerrit)

    unread,
    Feb 27, 2026, 8:29:42 PM (5 hours ago) Feb 27
    to David Baron, Mason Freed, chromium...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org

    David Baron voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I50034853487ef1ec3f154758d38ec9838c0bbe92
    Gerrit-Change-Number: 7613567
    Gerrit-PatchSet: 2
    Gerrit-Owner: David Baron <dba...@chromium.org>
    Gerrit-Reviewer: David Baron <dba...@chromium.org>
    Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
    Gerrit-Comment-Date: Sat, 28 Feb 2026 01:29:35 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Feb 27, 2026, 9:26:30 PM (5 hours ago) Feb 27
    to David Baron, Mason Freed, chromium...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Split Element::HandleInterestForHoverOrFocus.

    Element::HandleInterestForHoverOrFocus is effectively two different
    functions, distinguished by the boolean argument. This splits it into
    two separate functions. (This will make it easier to add code to this
    for menu safe triangle handling.)
    Bug: 406566432
    Change-Id: I50034853487ef1ec3f154758d38ec9838c0bbe92
    Reviewed-by: Mason Freed <mas...@chromium.org>
    Commit-Queue: David Baron <dba...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1591943}
    Files:
    • M third_party/blink/renderer/core/dom/element.cc
    • M third_party/blink/renderer/core/dom/element.h
    Change size: S
    Delta: 2 files changed, 9 insertions(+), 12 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Mason Freed
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I50034853487ef1ec3f154758d38ec9838c0bbe92
    Gerrit-Change-Number: 7613567
    Gerrit-PatchSet: 3
    Gerrit-Owner: David Baron <dba...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages