terminalPrivate: restrict setPrefs to Terminal SWA [chromium/src : main]
0 views
Skip to first unread message
Joel Hockey (Gerrit)
Jul 20, 2026, 8:15:16 PM (24 hours ago) Jul 20
to maciek swiech, Joel Hockey, Keigo Oka, Mike Frysinger, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Keigo Oka and maciek swiech
Joel Hockey voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Keigo Oka
- maciek swiech
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Keigo Oka (Gerrit)
1:45 AM (18 hours ago) 1:45 AM
to maciek swiech, Joel Hockey, Mike Frysinger, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from maciek swiech
Keigo Oka voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- maciek swiech
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mike Frysinger (Gerrit)
2:03 AM (18 hours ago) 2:03 AM
to maciek swiech, Keigo Oka, Joel Hockey, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from maciek swiech
Mike Frysinger voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- maciek swiech
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
maciek swiech (Gerrit)
11:41 AM (8 hours ago) 11:41 AM
to Mike Frysinger, Keigo Oka, Joel Hockey, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
maciek swiech voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
11:46 AM (8 hours ago) 11:46 AM
to maciek swiech, Mike Frysinger, Keigo Oka, Joel Hockey, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
terminalPrivate: restrict setPrefs to Terminal SWA
The only writable pref, kGuestOsTerminalSettings, drives Terminal SWA
state such as hterm settings and shelf shortcut menu items, so setPrefs
is now rejected for callers other than chrome-untrusted://terminal
(crosh and the allowlisted extension IDs no longer need to write it).
Add a browser test covering both the crosh (rejected) and terminal
(accepted) paths, and update the extension api test to expect the new
rejection for extension contexts.
PATCH GENERATED VIA AI
Bug: b:520191142
Test: unit test
Change-Id: I7d05f30e535623109844f3b77dcc664ece88e6fb
Reviewed-by: Mike Frysinger <vap...@chromium.org>
Reviewed-by: Keigo Oka <o...@chromium.org>
Commit-Queue: maciek swiech <drmas...@google.com>
Reviewed-by: Joel Hockey <joelh...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1665521}
Files:
- M chrome/browser/extensions/BUILD.gn
- M chrome/browser/extensions/api/terminal/terminal_private_api.cc
- M chrome/browser/extensions/api/terminal/terminal_private_browsertest.cc
- M chrome/test/data/extensions/api_test/terminal/component_extension/test.js
Change size: M
Delta: 4 files changed, 53 insertions(+), 34 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Joel Hockey, +1 by Keigo Oka, +1 by Mike Frysinger
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages