[Extension] Create FT config for browser namespace and polyfill features [chromium/src : main]

0 views
Skip to first unread message

Justin Lulejian (Gerrit)

unread,
Jan 13, 2026, 2:20:23 PMJan 13
to Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org

Justin Lulejian voted

Auto-Submit+1
Commit-Queue+1
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I7a45f6ba29fa5c1be5c9b10f0f496bb62275140a
Gerrit-Change-Number: 7457536
Gerrit-PatchSet: 2
Gerrit-Owner: Justin Lulejian <jlul...@chromium.org>
Gerrit-Reviewer: Justin Lulejian <jlul...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-Comment-Date: Tue, 13 Jan 2026 19:20:16 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Emilia Paz (Gerrit)

unread,
Jan 13, 2026, 2:45:51 PMJan 13
to Justin Lulejian, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org
Attention needed from Justin Lulejian

Emilia Paz voted and added 1 comment

Votes added by Emilia Paz

Code-Review+1
Commit-Queue+2

1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Emilia Paz . resolved

lgtm for adding a new feature. However, I'm not sure how that is realted with crbug.com/475255714

Open in Gerrit

Related details

Attention is currently required from:
  • Justin Lulejian
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I7a45f6ba29fa5c1be5c9b10f0f496bb62275140a
    Gerrit-Change-Number: 7457536
    Gerrit-PatchSet: 2
    Gerrit-Owner: Justin Lulejian <jlul...@chromium.org>
    Gerrit-Reviewer: Emilia Paz <emil...@chromium.org>
    Gerrit-Reviewer: Justin Lulejian <jlul...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-Attention: Justin Lulejian <jlul...@chromium.org>
    Gerrit-Comment-Date: Tue, 13 Jan 2026 19:45:37 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Justin Lulejian (Gerrit)

    unread,
    Jan 13, 2026, 3:08:17 PMJan 13
    to Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org

    Justin Lulejian voted and added 1 comment

    Votes added by Justin Lulejian

    Commit-Queue+0

    1 comment

    Patchset-level comments
    Emilia Paz . resolved

    lgtm for adding a new feature. However, I'm not sure how that is realted with crbug.com/475255714

    Justin Lulejian

    this will

    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I7a45f6ba29fa5c1be5c9b10f0f496bb62275140a
    Gerrit-Change-Number: 7457536
    Gerrit-PatchSet: 2
    Gerrit-Owner: Justin Lulejian <jlul...@chromium.org>
    Gerrit-Reviewer: Emilia Paz <emil...@chromium.org>
    Gerrit-Reviewer: Justin Lulejian <jlul...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-Comment-Date: Tue, 13 Jan 2026 20:08:08 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    Comment-In-Reply-To: Emilia Paz <emil...@chromium.org>
    satisfied_requirement
    open
    diffy

    Justin Lulejian (Gerrit)

    unread,
    Jan 13, 2026, 4:23:46 PMJan 13
    to Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org

    Justin Lulejian voted and added 1 comment

    Votes added by Justin Lulejian

    Auto-Submit+1

    1 comment

    Patchset-level comments
    Emilia Paz . resolved

    lgtm for adding a new feature. However, I'm not sure how that is realted with crbug.com/475255714

    Justin Lulejian

    this will

    Justin Lulejian

    (hit enter too soon)

    Emilia and I resolved this over chat, but for future reference: this isn't creating a new feature(s), it's create a FT config for two existing features that were not managed by Finch that I'm hoping to get managed by Finch going forward.

    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I7a45f6ba29fa5c1be5c9b10f0f496bb62275140a
    Gerrit-Change-Number: 7457536
    Gerrit-PatchSet: 3
    Gerrit-Owner: Justin Lulejian <jlul...@chromium.org>
    Gerrit-Reviewer: Emilia Paz <emil...@chromium.org>
    Gerrit-Reviewer: Justin Lulejian <jlul...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-Comment-Date: Tue, 13 Jan 2026 21:23:37 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    Comment-In-Reply-To: Justin Lulejian <jlul...@chromium.org>
    Comment-In-Reply-To: Emilia Paz <emil...@chromium.org>
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Jan 13, 2026, 4:38:10 PMJan 13
    to Justin Lulejian, Emilia Paz, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org

    Chromium LUCI CQ submitted the change with unreviewed changes

    Unreviewed changes

    2 is the latest approved patch-set.
    The change was submitted with unreviewed changes in the following files:

    ```
    The name of the file: testing/variations/fieldtrial_testing_config.json
    Insertions: 12, Deletions: 0.

    @@ -10462,6 +10462,12 @@
    "enable_features": [
    "ExtensionBrowserNamespaceAlternative"
    ]
    + },
    + {
    + "name": "Disabled",
    + "disable_features": [
    + "ExtensionBrowserNamespaceAlternative"
    + ]
    }
    ]
    }
    @@ -21749,6 +21755,12 @@
    "enable_features": [
    "RuntimeOnMessageWebExtensionPolyfillSupport"
    ]
    + },
    + {
    + "name": "Disabled",
    + "disable_features": [
    + "RuntimeOnMessageWebExtensionPolyfillSupport"
    + ]
    }
    ]
    }
    ```

    Change information

    Commit message:
    [Extension] Create FT config for browser namespace and polyfill features

    This will allow control of the features by version/channel rather than
    default enable like it is now.
    Bug: 475255714
    Change-Id: I7a45f6ba29fa5c1be5c9b10f0f496bb62275140a
    Auto-Submit: Justin Lulejian <jlul...@chromium.org>
    Reviewed-by: Emilia Paz <emil...@chromium.org>
    Commit-Queue: Justin Lulejian <jlul...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1568688}
    Files:
    • M testing/variations/fieldtrial_testing_config.json
    Change size: S
    Delta: 1 file changed, 48 insertions(+), 0 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Emilia Paz
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I7a45f6ba29fa5c1be5c9b10f0f496bb62275140a
    Gerrit-Change-Number: 7457536
    Gerrit-PatchSet: 4
    Gerrit-Owner: Justin Lulejian <jlul...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Emilia Paz <emil...@chromium.org>
    Gerrit-Reviewer: Justin Lulejian <jlul...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages