ValidateIOSurface: Make more robust, and add CPU access parameter [chromium/src : main]
0 views
Skip to first unread message
ccameron chromium (Gerrit)
Jul 3, 2026, 9:23:23 AM (5 days ago) Jul 3
to ccameron chromium, Vasiliy Telezhnikov, Chromium LUCI CQ, chromium...@chromium.org, mac-r...@chromium.org
Attention needed from Vasiliy Telezhnikov
ccameron chromium added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 5 (Latest):
ccameron chromium . resolved
ptal -- validation updates needed for compressed IOSurface formats.
I see that we don't actually block mapping a SharedImage based on having CPU usage flags. This will indeed prevent this, but it would be good to have a higher level check.
Related details
Attention is currently required from:
- Vasiliy Telezhnikov
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Vasiliy Telezhnikov (Gerrit)
Jul 6, 2026, 2:52:38 PM (2 days ago) Jul 6
to ccameron chromium, Chromium LUCI CQ, chromium...@chromium.org, mac-r...@chromium.org
Attention needed from ccameron chromium
Vasiliy Telezhnikov voted and added 1 comment![]( "Open in Gerrit")
Votes added by Vasiliy Telezhnikov
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- ccameron chromium
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
ccameron chromium (Gerrit)
Jul 6, 2026, 3:22:59 PM (2 days ago) Jul 6
to ccameron chromium, Daniel Cheng, Vasiliy Telezhnikov, Chromium LUCI CQ, chromium...@chromium.org, mac-r...@chromium.org
Attention needed from Daniel Cheng
ccameron chromium added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Attention is currently required from:
- Daniel Cheng
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Daniel Cheng (Gerrit)
Jul 6, 2026, 7:00:19 PM (2 days ago) Jul 6
to ccameron chromium, Daniel Cheng, Vasiliy Telezhnikov, Chromium LUCI CQ, chromium...@chromium.org, mac-r...@chromium.org
Attention needed from ccameron chromium
Daniel Cheng voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- ccameron chromium
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
ccameron chromium (Gerrit)
1:44 AM (8 hours ago) 1:44 AM
to ccameron chromium, Daniel Cheng, Vasiliy Telezhnikov, Chromium LUCI CQ, chromium...@chromium.org, mac-r...@chromium.org
ccameron chromium voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
2:50 AM (7 hours ago) 2:50 AM
to ccameron chromium, Daniel Cheng, Vasiliy Telezhnikov, chromium...@chromium.org, mac-r...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
ValidateIOSurface: Make more robust, and add CPU access parameter
To check if an IOSurface pixel format and SharedImageFormat match, add a
new function IOSurfacePixelFormatMatchesSharedImageFormat, and use that.
This will be necessary for validation of compressed video formats.
Also, add a cpu_access parameter, indicating if CPU access is going to
be requested. This is used to reject attempts to access compressed video
formats via the CPU.
Bug: 500766607
Change-Id: I5ae3558cb8cdad0d52b209b9547d19c5cc3968a7
Commit-Queue: ccameron chromium <ccam...@chromium.org>
Reviewed-by: Vasiliy Telezhnikov <vas...@chromium.org>
Reviewed-by: Daniel Cheng <dch...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1658529}
Files:
- M gpu/command_buffer/client/internal/mappable_buffer_io_surface.cc
- M gpu/command_buffer/common/iosurface_validation.cc
- M gpu/command_buffer/common/iosurface_validation.h
- M gpu/command_buffer/service/shared_image/iosurface_image_backing_factory.mm
- M ui/gfx/mac/io_surface.cc
- M ui/gfx/mac/io_surface.h
Change size: M
Delta: 6 files changed, 78 insertions(+), 33 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Daniel Cheng, +1 by Vasiliy Telezhnikov
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages