Make Svg2Cascade an experimental feature [chromium/src : main]

0 views
Skip to first unread message

Rune Lillesveen (Gerrit)

unread,
Nov 5, 2025, 9:40:32 AM (2 days ago) Nov 5
to Rune Lillesveen, Fredrik Söderquist, Anders Hartvoll Ruud, chromium...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
Attention needed from Anders Hartvoll Ruud and Fredrik Söderquist

Rune Lillesveen added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Rune Lillesveen . resolved

andruud@ for VirtualTestSuites removal

Open in Gerrit

Related details

Attention is currently required from:
  • Anders Hartvoll Ruud
  • Fredrik Söderquist
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I88262fbd59a2c84043f9448c3f2a82ddb13e5497
Gerrit-Change-Number: 7123699
Gerrit-PatchSet: 1
Gerrit-Owner: Rune Lillesveen <fut...@chromium.org>
Gerrit-Reviewer: Anders Hartvoll Ruud <and...@chromium.org>
Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>
Gerrit-Attention: Anders Hartvoll Ruud <and...@chromium.org>
Gerrit-Attention: Fredrik Söderquist <f...@opera.com>
Gerrit-Comment-Date: Wed, 05 Nov 2025 14:40:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Anders Hartvoll Ruud (Gerrit)

unread,
Nov 5, 2025, 9:57:43 AM (2 days ago) Nov 5
to Rune Lillesveen, Fredrik Söderquist, chromium...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
Attention needed from Fredrik Söderquist and Rune Lillesveen

Anders Hartvoll Ruud voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Fredrik Söderquist
  • Rune Lillesveen
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I88262fbd59a2c84043f9448c3f2a82ddb13e5497
Gerrit-Change-Number: 7123699
Gerrit-PatchSet: 1
Gerrit-Owner: Rune Lillesveen <fut...@chromium.org>
Gerrit-Reviewer: Anders Hartvoll Ruud <and...@chromium.org>
Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>
Gerrit-Attention: Rune Lillesveen <fut...@chromium.org>
Gerrit-Attention: Fredrik Söderquist <f...@opera.com>
Gerrit-Comment-Date: Wed, 05 Nov 2025 14:57:27 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Fredrik Söderquist (Gerrit)

unread,
Nov 5, 2025, 10:18:32 AM (2 days ago) Nov 5
to Rune Lillesveen, Anders Hartvoll Ruud, chromium...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
Attention needed from Rune Lillesveen

Fredrik Söderquist voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Rune Lillesveen
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I88262fbd59a2c84043f9448c3f2a82ddb13e5497
Gerrit-Change-Number: 7123699
Gerrit-PatchSet: 1
Gerrit-Owner: Rune Lillesveen <fut...@chromium.org>
Gerrit-Reviewer: Anders Hartvoll Ruud <and...@chromium.org>
Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>
Gerrit-Attention: Rune Lillesveen <fut...@chromium.org>
Gerrit-Comment-Date: Wed, 05 Nov 2025 15:18:15 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Rune Lillesveen (Gerrit)

unread,
Nov 5, 2025, 10:18:44 AM (2 days ago) Nov 5
to Rune Lillesveen, Fredrik Söderquist, Anders Hartvoll Ruud, chromium...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org

Rune Lillesveen voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I88262fbd59a2c84043f9448c3f2a82ddb13e5497
Gerrit-Change-Number: 7123699
Gerrit-PatchSet: 1
Gerrit-Owner: Rune Lillesveen <fut...@chromium.org>
Gerrit-Reviewer: Anders Hartvoll Ruud <and...@chromium.org>
Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>
Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
Gerrit-Comment-Date: Wed, 05 Nov 2025 15:18:27 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Nov 5, 2025, 11:02:41 AM (2 days ago) Nov 5
to Rune Lillesveen, Fredrik Söderquist, Anders Hartvoll Ruud, chromium...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
Make Svg2Cascade an experimental feature

Remove the virtual test suite and change test expectations
Bug: 40550039
Change-Id: I88262fbd59a2c84043f9448c3f2a82ddb13e5497
Reviewed-by: Anders Hartvoll Ruud <and...@chromium.org>
Commit-Queue: Rune Lillesveen <fut...@chromium.org>
Reviewed-by: Fredrik Söderquist <f...@opera.com>
Cr-Commit-Position: refs/heads/main@{#1540652}
Files:
  • M third_party/blink/renderer/platform/runtime_enabled_features.json5
  • M third_party/blink/web_tests/NeverFixTests
  • M third_party/blink/web_tests/TestExpectations
  • M third_party/blink/web_tests/VirtualTestSuites
  • D third_party/blink/web_tests/virtual/svg2-cascade/README.md
Change size: S
Delta: 5 files changed, 6 insertions(+), 41 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Anders Hartvoll Ruud, +1 by Fredrik Söderquist
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I88262fbd59a2c84043f9448c3f2a82ddb13e5497
Gerrit-Change-Number: 7123699
Gerrit-PatchSet: 2
Gerrit-Owner: Rune Lillesveen <fut...@chromium.org>
Gerrit-Reviewer: Anders Hartvoll Ruud <and...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages