[Touchpad] Fix crashes in OnGestureStarted [chromium/src : main]
0 views
Skip to first unread message
Fuhsin Liao (Gerrit)
Jul 20, 2026, 2:48:25 PM (yesterday) Jul 20
to Keigo Oka, Aldo Culquicondor, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Aldo Culquicondor and Keigo Oka
Fuhsin Liao voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Aldo Culquicondor
- Keigo Oka
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Aldo Culquicondor (Gerrit)
Jul 20, 2026, 3:40:17 PM (yesterday) Jul 20
to Fuhsin Liao, Keigo Oka, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Fuhsin Liao and Keigo Oka
Aldo Culquicondor added 1 comment![]( "Open in Gerrit")
File chrome/browser/gesturenav/android/tab_on_back_gesture_handler.cc
Line 66, Patchset 2 (Latest):
void TabOnBackGestureHandler::OnBackProgressed(JNIEnv* env,Aldo Culquicondor . unresolved
But why is onBackProgressed being called without having called onBackStarted first?
Perhaps we can do this trick to figure out where it is getting called from https://crrev.com/c/8120410
Related details
Attention is currently required from:
- Fuhsin Liao
- Keigo Oka
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Keigo Oka (Gerrit)
1:44 AM (19 hours ago) 1:44 AM
to Fuhsin Liao, Aldo Culquicondor, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Fuhsin Liao
Keigo Oka added 1 comment![]( "Open in Gerrit")
File chrome/browser/gesturenav/android/tab_on_back_gesture_handler.cc
Line 66, Patchset 2:
void TabOnBackGestureHandler::OnBackProgressed(JNIEnv* env,Aldo Culquicondor . unresolved
But why is onBackProgressed being called without having called onBackStarted first?
Perhaps we can do this trick to figure out where it is getting called from https://crrev.com/c/8120410
Keigo Oka
+1. I think it's good to understand the root cause first, and then share it in the commit message or in the bug. Without this, we can't judge whether it's a proper fix or not.
Related details
Attention is currently required from:
- Fuhsin Liao
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages