Reapply "[layout] Reinsert LayoutObjects which undergo a in-flow state change." [chromium/src : main]

0 views
Skip to first unread message

Ian Kilpatrick (Gerrit)

unread,
Jan 9, 2026, 6:23:55 PM (5 days ago) Jan 9
to Morten Stenshorne, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, mac-r...@chromium.org, zol...@webkit.org
Attention needed from Morten Stenshorne

Ian Kilpatrick added 1 comment

Patchset-level comments
File-level comment, Patchset 5 (Latest):
Ian Kilpatrick . unresolved

I'll land this after the next branch point next week.

For the delta between the reapply and the update see:
https://chromium-review.googlesource.com/c/chromium/src/+/7427180/1..5

All a just nullptr checks so for. Clusterfuzz seemed to do a good job finding issues, so we'll see what else it finds in the reapply.

Open in Gerrit

Related details

Attention is currently required from:
  • Morten Stenshorne
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I983967e03d10552ad2f8cd1f70b4c3c2ea079836
Gerrit-Change-Number: 7427180
Gerrit-PatchSet: 5
Gerrit-Owner: Ian Kilpatrick <ikilp...@chromium.org>
Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>
Gerrit-Reviewer: Morten Stenshorne <mste...@chromium.org>
Gerrit-Attention: Morten Stenshorne <mste...@chromium.org>
Gerrit-Comment-Date: Fri, 09 Jan 2026 23:23:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Ian Kilpatrick (Gerrit)

unread,
Jan 9, 2026, 6:24:00 PM (5 days ago) Jan 9
to Morten Stenshorne, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, mac-r...@chromium.org, zol...@webkit.org
Attention needed from Morten Stenshorne

Ian Kilpatrick voted Code-Review-1

Code-Review-1
Open in Gerrit

Related details

Attention is currently required from:
  • Morten Stenshorne
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement is blockingCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I983967e03d10552ad2f8cd1f70b4c3c2ea079836
    Gerrit-Change-Number: 7427180
    Gerrit-PatchSet: 5
    Gerrit-Owner: Ian Kilpatrick <ikilp...@chromium.org>
    Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>
    Gerrit-Reviewer: Morten Stenshorne <mste...@chromium.org>
    Gerrit-Attention: Morten Stenshorne <mste...@chromium.org>
    Gerrit-Comment-Date: Fri, 09 Jan 2026 23:23:52 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    blocking_requirement
    unsatisfied_requirement
    open
    diffy

    Morten Stenshorne (Gerrit)

    unread,
    Jan 12, 2026, 3:13:15 AM (3 days ago) Jan 12
    to Ian Kilpatrick, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, mac-r...@chromium.org, zol...@webkit.org
    Attention needed from Ian Kilpatrick

    Morten Stenshorne added 2 comments

    Patchset-level comments
    Morten Stenshorne . resolved

    All the new nullptr checks... are we sure we really should be inside these functions if we have a nullptr?

    File third_party/blink/renderer/core/layout/layout_box_model_object.cc
    Line 203, Patchset 5 (Latest): } else if (Layer() && (RuntimeEnabledFeatures::
    Morten Stenshorne . unresolved

    We'll now do this for the root layer. Any concerns?

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Ian Kilpatrick
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement is blockingCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I983967e03d10552ad2f8cd1f70b4c3c2ea079836
    Gerrit-Change-Number: 7427180
    Gerrit-PatchSet: 5
    Gerrit-Owner: Ian Kilpatrick <ikilp...@chromium.org>
    Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>
    Gerrit-Reviewer: Morten Stenshorne <mste...@chromium.org>
    Gerrit-Attention: Ian Kilpatrick <ikilp...@chromium.org>
    Gerrit-Comment-Date: Mon, 12 Jan 2026 08:13:02 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    blocking_requirement
    unsatisfied_requirement
    open
    diffy

    Ian Kilpatrick (Gerrit)

    unread,
    7:43 PM (4 hours ago) 7:43 PM
    to Morten Stenshorne, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, mac-r...@chromium.org, zol...@webkit.org
    Attention needed from Morten Stenshorne

    Ian Kilpatrick voted and added 2 comments

    Votes added by Ian Kilpatrick

    Code-Review+0

    2 comments

    Patchset-level comments
    Morten Stenshorne . resolved

    All the new nullptr checks... are we sure we really should be inside these functions if we have a nullptr?

    Ian Kilpatrick

    I think so - an arguable one is `DirtyVisibleContentStatus` - but it also calls `MarkAncestorChainForFlagsUpdate` which has a side-effect on the current layer which i think is needed.

    File third_party/blink/renderer/core/layout/layout_box_model_object.cc
    Line 203, Patchset 5 (Latest): } else if (Layer() && (RuntimeEnabledFeatures::
    Morten Stenshorne . unresolved

    We'll now do this for the root layer. Any concerns?

    Ian Kilpatrick

    I don't think so - (can we even change the style for the root layer?).

    This part of the change was reverted in:
    https://chromiumdash.appspot.com/commit/d19611f290f1c793202dacb7ce790c86ed6db9c3

    and clusterfuzz seemed ok with it for a few weeks (compared with a few hours for the rest of this change).

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Morten Stenshorne
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I983967e03d10552ad2f8cd1f70b4c3c2ea079836
      Gerrit-Change-Number: 7427180
      Gerrit-PatchSet: 5
      Gerrit-Owner: Ian Kilpatrick <ikilp...@chromium.org>
      Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>
      Gerrit-Reviewer: Morten Stenshorne <mste...@chromium.org>
      Gerrit-Attention: Morten Stenshorne <mste...@chromium.org>
      Gerrit-Comment-Date: Thu, 15 Jan 2026 00:43:27 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      Comment-In-Reply-To: Morten Stenshorne <mste...@chromium.org>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages