[LNA] add ip address space override for SubresourceFilterBrowserTest [chromium/src : main]

[Hubert Chao (Gerrit)]

Attention needed from Josh Karlin, Patricia Rock and Ryan Sturm

Hubert Chao added 1 comment

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Hubert Chao . resolved

@ryan...@chromium.org: chrome/browser/navigation
@jka...@chromium.org: chrome/browser/subresource
@trisha...@google.com: chrome/browser/tpcd

Open in Gerrit

Related details

Attention is currently required from:

• Josh Karlin
• Patricia Rock
• Ryan Sturm

Submit Requirements:

• Code-Coverage
• Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I0c6178147cbc5e0be8f9ee562f8b5e6198291a26

Gerrit-Change-Number: 6635414

Gerrit-PatchSet: 2

Gerrit-Owner: Hubert Chao <hc...@chromium.org>

Gerrit-Reviewer: Hubert Chao <hc...@chromium.org>

Gerrit-Reviewer: Josh Karlin <jka...@chromium.org>

Gerrit-Reviewer: Patricia Rock <trisha...@google.com>

Gerrit-Reviewer: Ryan Sturm <ryan...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Josh Karlin <jka...@chromium.org>

Gerrit-Attention: Patricia Rock <trisha...@google.com>

Gerrit-Attention: Ryan Sturm <ryan...@chromium.org>

Gerrit-Comment-Date: Wed, 11 Jun 2025 12:14:11 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Ryan Sturm (Gerrit)]

Attention needed from Hubert Chao, Josh Karlin and Patricia Rock

Ryan Sturm voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

• Hubert Chao
• Josh Karlin
• Patricia Rock

Submit Requirements:

• Code-Coverage
• Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I0c6178147cbc5e0be8f9ee562f8b5e6198291a26

Gerrit-Change-Number: 6635414

Gerrit-PatchSet: 2

Gerrit-Owner: Hubert Chao <hc...@chromium.org>

Gerrit-Reviewer: Hubert Chao <hc...@chromium.org>

Gerrit-Reviewer: Josh Karlin <jka...@chromium.org>

Gerrit-Reviewer: Patricia Rock <trisha...@google.com>

Gerrit-Reviewer: Ryan Sturm <ryan...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Josh Karlin <jka...@chromium.org>

Gerrit-Attention: Patricia Rock <trisha...@google.com>

Gerrit-Attention: Hubert Chao <hc...@chromium.org>

Gerrit-Comment-Date: Wed, 11 Jun 2025 20:28:21 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Josh Karlin (Gerrit)]

Attention needed from Hubert Chao and Patricia Rock

Josh Karlin added 1 comment

File chrome/browser/subresource_filter/subresource_filter_browser_test_harness.cc

Line 187, Patchset 2 (Latest): // Treat the test server as public to bypass Local Network Access checks.

Josh Karlin . unresolved

Should we just do this by default for embedded_test_servers? Why go through this song and dance for test?

Open in Gerrit

Related details

Attention is currently required from:

• Hubert Chao
• Patricia Rock

Submit Requirements:

• Code-Coverage
• Code-Review

• No-Unresolved-Comments

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I0c6178147cbc5e0be8f9ee562f8b5e6198291a26

Gerrit-Change-Number: 6635414

Gerrit-PatchSet: 2

Gerrit-Owner: Hubert Chao <hc...@chromium.org>

Gerrit-Reviewer: Hubert Chao <hc...@chromium.org>

Gerrit-Reviewer: Josh Karlin <jka...@chromium.org>

Gerrit-Reviewer: Patricia Rock <trisha...@google.com>

Gerrit-Reviewer: Ryan Sturm <ryan...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Patricia Rock <trisha...@google.com>

Gerrit-Attention: Hubert Chao <hc...@chromium.org>

Gerrit-Comment-Date: Thu, 12 Jun 2025 13:00:20 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Josh Karlin (Gerrit)]

Attention needed from Hubert Chao and Patricia Rock

Josh Karlin added 1 comment

File chrome/browser/subresource_filter/subresource_filter_browser_test_harness.cc

Line 187, Patchset 2 (Latest): // Treat the test server as public to bypass Local Network Access checks.

Josh Karlin . unresolved

Should we just do this by default for embedded_test_servers? Why go through this song and dance for test?

Josh Karlin

Sorry, meant to say "for each test"

Gerrit-Comment-Date: Thu, 12 Jun 2025 13:00:46 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Josh Karlin <jka...@chromium.org>

[Hubert Chao (Gerrit)]

Attention needed from Hubert Chao and Patricia Rock

Hubert Chao added 1 comment

File chrome/browser/subresource_filter/subresource_filter_browser_test_harness.cc

Line 187, Patchset 2 (Latest): // Treat the test server as public to bypass Local Network Access checks.

Josh Karlin . unresolved

Should we just do this by default for embedded_test_servers? Why go through this song and dance for test?

Josh Karlin

Sorry, meant to say "for each test"

Hubert Chao

I've been working on this independently, but its unclear at this moment if it'll get approved.

https://chromium-review.googlesource.com/c/chromium/src/+/6638311

This CL was from before I started on the general approach, and since I'm trying to get things in before M139 branch cut I'm pushing on both approaches at the moment.

Open in Gerrit

Related details

Attention is currently required from:

• Hubert Chao
• Patricia Rock

Submit Requirements:

• Code-Coverage
• Code-Review
• No-Unresolved-Comments

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I0c6178147cbc5e0be8f9ee562f8b5e6198291a26

Gerrit-Change-Number: 6635414

Gerrit-PatchSet: 2

Gerrit-Owner: Hubert Chao <hc...@chromium.org>

Gerrit-Reviewer: Hubert Chao <hc...@chromium.org>

Gerrit-Reviewer: Josh Karlin <jka...@chromium.org>

Gerrit-Reviewer: Patricia Rock <trisha...@google.com>

Gerrit-Reviewer: Ryan Sturm <ryan...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Hubert Chao <hc...@google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Patricia Rock <trisha...@google.com>

Gerrit-Attention: Hubert Chao <hc...@chromium.org>

Gerrit-Comment-Date: Thu, 12 Jun 2025 15:17:16 +0000

[Josh Karlin (Gerrit)]

Attention needed from Hubert Chao and Patricia Rock

Josh Karlin added 1 comment

File chrome/browser/subresource_filter/subresource_filter_browser_test_harness.cc

Line 187, Patchset 2 (Latest): // Treat the test server as public to bypass Local Network Access checks.

Josh Karlin . unresolved

Should we just do this by default for embedded_test_servers? Why go through this song and dance for test?

Josh Karlin

Sorry, meant to say "for each test"

Hubert Chao

I've been working on this independently, but its unclear at this moment if it'll get approved.

https://chromium-review.googlesource.com/c/chromium/src/+/6638311

This CL was from before I started on the general approach, and since I'm trying to get things in before M139 branch cut I'm pushing on both approaches at the moment.

Josh Karlin

I'd prefer to land the more elegant approach. Can we hold off on this CL until a decision is made on 6638311?

Gerrit-Comment-Date: Thu, 12 Jun 2025 15:35:23 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Hubert Chao <hc...@google.com>

Comment-In-Reply-To: Josh Karlin <jka...@chromium.org>

[Hubert Chao (Gerrit)]

Hubert Chao abandoned this change

Related details

Attention set is empty

Submit Requirements:

• Code-Coverage
• Code-Review
• No-Unresolved-Comments

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: abandon

[Hubert Chao (Gerrit)]

Hubert Chao added 1 comment

File chrome/browser/subresource_filter/subresource_filter_browser_test_harness.cc

Line 187, Patchset 2 (Latest): // Treat the test server as public to bypass Local Network Access checks.

Josh Karlin . resolved

Should we just do this by default for embedded_test_servers? Why go through this song and dance for test?

Josh Karlin

Sorry, meant to say "for each test"

Hubert Chao

I've been working on this independently, but its unclear at this moment if it'll get approved.

https://chromium-review.googlesource.com/c/chromium/src/+/6638311

This CL was from before I started on the general approach, and since I'm trying to get things in before M139 branch cut I'm pushing on both approaches at the moment.

Josh Karlin

I'd prefer to land the more elegant approach. Can we hold off on this CL until a decision is made on 6638311?

Hubert Chao

6638311 seems to have stuck, abandoning this.

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Coverage
• Code-Review
• No-Unresolved-Comments

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I0c6178147cbc5e0be8f9ee562f8b5e6198291a26

Gerrit-Change-Number: 6635414

Gerrit-PatchSet: 2

Gerrit-Owner: Hubert Chao <hc...@chromium.org>

Gerrit-Reviewer: Hubert Chao <hc...@chromium.org>

Gerrit-Reviewer: Josh Karlin <jka...@chromium.org>

Gerrit-Reviewer: Patricia Rock <trisha...@google.com>

Gerrit-Reviewer: Ryan Sturm <ryan...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Hubert Chao <hc...@google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Comment-Date: Wed, 18 Jun 2025 16:54:52 +0000