[RSG] Implement prioritization of data sources [chromium/src : main]
Mikita Kuchyn (Gerrit)
Mikita Kuchyn added 1 comment![]( "Open in Gerrit")
Related details
- Jihad Hanna
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jihad Hanna (Gerrit)
Jihad Hanna added 7 comments![]( "Open in Gerrit")
std::optional<SuggestionDataSource> highest_priority_source;Could you add a small description right above here:
```
// Clear some of the suggestions based on priorities:
// (1) Find the highest priority suggestion data source S that returned data.
// (2) Keep only data from sources that are mergeable with S, discard the rest.
```
// If supported_merges_set is nullptr, then no merge options exist, so we
// should discard all other suggestions.I'd remove this comment as the codeblock below is quite trivial
{SuggestionDataSource::kAddressOnTyping,Address on typing cannot merge with anything.
// Passkeys are excluded (Handled via PasswordManagerDelegate)I'm almost sure this isn't true, we have logic right now that adds a passkey suggestion when appropriate.
SuggestionDataSource::kAddressOnTyping,Address on typing is very low priority (I think just above autocomplete)
SuggestionDataSource::kOneTimePassword,I don't think OTPs have a very high priority. How did you come up with this ranking?
std::to_array<SuggestionDataSource>({Could you wrap this array with `// clang-format off` and later `// clang-format on` and have each source on a single line?
Related details
- Mikita Kuchyn
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jihad Hanna (Gerrit)
Jihad Hanna added 1 comment![]( "Open in Gerrit")
Related details
- Mikita Kuchyn
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |