Update tab sharing infobar [chromium/src : main]

0 views
Skip to first unread message

Darryl James (Gerrit)

unread,
Dec 15, 2025, 2:48:11 PM (21 hours ago) Dec 15
to Muhammad Salmaan, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Muhammad Salmaan

Darryl James voted and added 1 comment

Votes added by Darryl James

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 5 (Latest):
Darryl James . resolved

lgtm!

Open in Gerrit

Related details

Attention is currently required from:
  • Muhammad Salmaan
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie84fb3cfb43f7144850a2a4d0941bde9514ec189
Gerrit-Change-Number: 7262634
Gerrit-PatchSet: 5
Gerrit-Owner: Muhammad Salmaan <musa...@chromium.org>
Gerrit-Reviewer: Darryl James <dlj...@chromium.org>
Gerrit-Reviewer: Muhammad Salmaan <musa...@chromium.org>
Gerrit-Attention: Muhammad Salmaan <musa...@chromium.org>
Gerrit-Comment-Date: Mon, 15 Dec 2025 19:47:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Muhammad Salmaan (Gerrit)

unread,
Dec 15, 2025, 2:55:25 PM (20 hours ago) Dec 15
to Darryl James, Chromium LUCI CQ, chromium...@chromium.org

Muhammad Salmaan voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie84fb3cfb43f7144850a2a4d0941bde9514ec189
Gerrit-Change-Number: 7262634
Gerrit-PatchSet: 5
Gerrit-Owner: Muhammad Salmaan <musa...@chromium.org>
Gerrit-Reviewer: Darryl James <dlj...@chromium.org>
Gerrit-Reviewer: Muhammad Salmaan <musa...@chromium.org>
Gerrit-Comment-Date: Mon, 15 Dec 2025 19:55:11 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Dec 15, 2025, 3:03:51 PM (20 hours ago) Dec 15
to Muhammad Salmaan, Darryl James, chromium...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
Update tab sharing infobar

Updated the tab sharing infobar the refreshed ui. Below is the before
and after :
Bug: 466463495
Change-Id: Ie84fb3cfb43f7144850a2a4d0941bde9514ec189
Reviewed-by: Darryl James <dlj...@chromium.org>
Commit-Queue: Muhammad Salmaan <musa...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1558910}
Files:
  • M chrome/browser/ui/views/chrome_layout_provider.cc
  • M chrome/browser/ui/views/tab_sharing/tab_sharing_infobar.cc
  • M chrome/browser/ui/views/tab_sharing/tab_sharing_status_message_view.cc
Change size: S
Delta: 3 files changed, 35 insertions(+), 10 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Darryl James
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie84fb3cfb43f7144850a2a4d0941bde9514ec189
Gerrit-Change-Number: 7262634
Gerrit-PatchSet: 6
Gerrit-Owner: Muhammad Salmaan <musa...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Darryl James <dlj...@chromium.org>
Gerrit-Reviewer: Muhammad Salmaan <musa...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages