overview: Fix no windows widget while dragging [chromium/src : main]
0 views
Skip to first unread message
Sophie Wen (Gerrit)
12:56 PM (11 hours ago) 12:56 PM
to Sammie Quon, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Sammie Quon
Sophie Wen added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 3 (Latest):
Sophie Wen . resolved
Sammie, can you please review? Thank you!
Related details
Attention is currently required from:
- Sammie Quon
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Sammie Quon (Gerrit)
8:21 PM (3 hours ago) 8:21 PM
to Sophie Wen, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Sophie Wen
Sammie Quon voted and added 1 comment![]( "Open in Gerrit")
Votes added by Sammie Quon
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Sophie Wen
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Sophie Wen (Gerrit)
8:22 PM (3 hours ago) 8:22 PM
to Sammie Quon, Chromium LUCI CQ, chromium...@chromium.org
Sophie Wen voted and added 1 comment![]( "Open in Gerrit")
Votes added by Sophie Wen
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
9:10 PM (3 hours ago) 9:10 PM
to Sophie Wen, Sammie Quon, chromium...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
overview: Fix no windows widget while dragging
This fixes an issue where the widget would briefly show during drag to
partial overview. This will always hide it for consistency.
Demo: https://b.corp.google.com/issues/313505530#comment7
Test: added, verified it fails w/o fix in Patchset 1
Bug: b:313505530
Change-Id: Ic061e146fdc34f5165cf900c14852fa23febaa91
Reviewed-by: Sammie Quon <sammi...@chromium.org>
Commit-Queue: Sophie Wen <soph...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1322507}
Files:
- M ash/wm/overview/overview_grid.cc
- M ash/wm/overview/overview_session_unittest.cc
Change size: M
Delta: 2 files changed, 37 insertions(+), 15 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Sammie Quon
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages