[mojo] Guard VM buffer address access in ChannelMac [chromium/src : main]

0 views
Skip to first unread message

Doug Turner (Gerrit)

unread,
Aug 3, 2026, 11:10:23 PM (6 days ago) Aug 3
to Chromium LUCI CQ, chromium...@chromium.org, mac-r...@chromium.org

Doug Turner added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Doug Turner . resolved

hrm, ignore plz.

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ic2c6d201135c8179788e72f12c2c47ff8707407e
Gerrit-Change-Number: 8190836
Gerrit-PatchSet: 1
Gerrit-Owner: Doug Turner <d...@google.com>
Gerrit-Reviewer: Doug Turner <d...@google.com>
Gerrit-Comment-Date: Tue, 04 Aug 2026 03:10:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Andrea Orru (Gerrit)

unread,
Aug 7, 2026, 6:09:34 PM (2 days ago) Aug 7
to Doug Turner, Chromium LUCI CQ, chromium...@chromium.org, mac-r...@chromium.org
Attention needed from Doug Turner

Andrea Orru voted and added 4 comments

Votes added by Andrea Orru

Code-Review+1

4 comments

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Andrea Orru . resolved

lgtm % nits

Commit Message
Line 1, Patchset 2 (Latest):Parent: 61eed89b (Resolve CSS property aliases for @position-try validation)
Andrea Orru . unresolved

Please edit the commit message and hit "Format" so it's formatted properly.

Alternatively, you can point your Jetski at the `cl-description` skill:
https://source.chromium.org/chromium/chromium/src/+/main:agents/shared/skills/cl-description/SKILL.md

Line 9, Patchset 2 (Latest):Add validity checks (is_valid()) for receive_buffer_ and send_buffer_
Andrea Orru . unresolved

Actualy it checks `.address()`

Line 18, Patchset 2 (Latest):Checking receive_buffer_.is_valid() and send_buffer_.is_valid() matches
Andrea Orru . unresolved

ditto

Open in Gerrit

Related details

Attention is currently required from:
  • Doug Turner
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ic2c6d201135c8179788e72f12c2c47ff8707407e
Gerrit-Change-Number: 8190836
Gerrit-PatchSet: 2
Gerrit-Owner: Doug Turner <d...@google.com>
Gerrit-Reviewer: Andrea Orru <andre...@chromium.org>
Gerrit-Reviewer: Doug Turner <d...@google.com>
Gerrit-Attention: Doug Turner <d...@google.com>
Gerrit-Comment-Date: Fri, 07 Aug 2026 22:09:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Doug Turner (Gerrit)

unread,
6:54 PM (1 hour ago) 6:54 PM
to Chromium LUCI CQ, chromium...@chromium.org, mac-r...@chromium.org

Doug Turner added 3 comments

Commit Message
Line 1, Patchset 2:Parent: 61eed89b (Resolve CSS property aliases for @position-try validation)
Andrea Orru . resolved

Please edit the commit message and hit "Format" so it's formatted properly.

Alternatively, you can point your Jetski at the `cl-description` skill:
https://source.chromium.org/chromium/chromium/src/+/main:agents/shared/skills/cl-description/SKILL.md

Doug Turner

Acknowledged

Line 9, Patchset 2:Add validity checks (is_valid()) for receive_buffer_ and send_buffer_
Andrea Orru . resolved

Actualy it checks `.address()`

Doug Turner

Acknowledged

Line 18, Patchset 2:Checking receive_buffer_.is_valid() and send_buffer_.is_valid() matches
Andrea Orru . resolved

ditto

Doug Turner

Acknowledged

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ic2c6d201135c8179788e72f12c2c47ff8707407e
    Gerrit-Change-Number: 8190836
    Gerrit-PatchSet: 5
    Gerrit-Owner: Doug Turner <d...@google.com>
    Gerrit-Reviewer: Andrea Orru <andre...@chromium.org>
    Gerrit-Reviewer: Doug Turner <d...@google.com>
    Gerrit-Comment-Date: Sun, 09 Aug 2026 22:53:59 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Andrea Orru <andre...@chromium.org>
    satisfied_requirement
    open
    diffy

    Doug Turner (Gerrit)

    unread,
    6:56 PM (1 hour ago) 6:56 PM
    to Chromium LUCI CQ, chromium...@chromium.org, mac-r...@chromium.org

    Doug Turner voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ic2c6d201135c8179788e72f12c2c47ff8707407e
    Gerrit-Change-Number: 8190836
    Gerrit-PatchSet: 5
    Gerrit-Owner: Doug Turner <d...@google.com>
    Gerrit-Reviewer: Andrea Orru <andre...@chromium.org>
    Gerrit-Reviewer: Doug Turner <d...@google.com>
    Gerrit-Comment-Date: Sun, 09 Aug 2026 22:56:14 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages