[iOS] Don't open share tab group if not user initiated [chromium/src : main]

0 views

Skip to first unread message

Gauthier Ambard (Gerrit)

unread,

6:20 AM (2 hours ago) 6:20 AM

to Louis Romero, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org

Attention needed from Louis Romero

Gauthier Ambard voted

Auto-Submit	+1
Commit-Queue	+1

Open in Gerrit

Related details

Attention is currently required from:

Louis Romero

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Louis Romero (Gerrit)

unread,

7:21 AM (1 hour ago) 7:21 AM

to Gauthier Ambard, Louis Romero, Chromium LUCI CQ, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org

Attention needed from Gauthier Ambard

Louis Romero voted and added 1 comment

Votes added by Louis Romero

Code-Review

1 comment

File ios/chrome/browser/collaboration/model/data_sharing_tab_helper.mm

Line 27, Patchset 1 (Latest):

  if (!request_info.is_user_initiated) {
    return request_info.user_tapped_recently;
  }

Louis Romero . unresolved

Should we even add the other conditions like in https://source.chromium.org/chromium/chromium/src/+/main:chrome/browser/data_sharing/data_sharing_navigation_throttle.cc;l=38-46;drc=34f0d2690d43df1880f2cf7c265cf27d1c86e0a7?