Removing UpdateDeviceRecoveryDataRequest helper used for migration to the new proto format. [infra/infra : main]

0 views
Skip to first unread message

Sergey Fetisov (Gerrit)

unread,
Jul 1, 2022, 5:49:51 PMJul 1
to Justin Suen, Xixuan Wu, chromium...@chromium.org

Attention is currently required from: Justin Suen, Xixuan Wu.

View Change

    To view, visit change 3741276. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-Project: infra/infra
    Gerrit-Branch: main
    Gerrit-Change-Id: Ia7365b044a461bf830a9c88e32e2ea6a57157c6e
    Gerrit-Change-Number: 3741276
    Gerrit-PatchSet: 2
    Gerrit-Owner: Sergey Fetisov <sfet...@google.com>
    Gerrit-Reviewer: Justin Suen <justi...@google.com>
    Gerrit-Reviewer: Xixuan Wu <xix...@chromium.org>
    Gerrit-Attention: Justin Suen <justi...@google.com>
    Gerrit-Attention: Xixuan Wu <xix...@chromium.org>
    Gerrit-Comment-Date: Fri, 01 Jul 2022 21:49:42 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: No
    Gerrit-MessageType: comment

    Xixuan Wu (Gerrit)

    unread,
    Jul 2, 2022, 1:50:54 AMJul 2
    to Sergey Fetisov, Justin Suen, chromium...@chromium.org

    Attention is currently required from: Justin Suen, Sergey Fetisov.

    Patch set 2:Code-Review +1

    View Change

      To view, visit change 3741276. To unsubscribe, or for help writing mail filters, visit settings.

      Gerrit-Project: infra/infra
      Gerrit-Branch: main
      Gerrit-Change-Id: Ia7365b044a461bf830a9c88e32e2ea6a57157c6e
      Gerrit-Change-Number: 3741276
      Gerrit-PatchSet: 2
      Gerrit-Owner: Sergey Fetisov <sfet...@google.com>
      Gerrit-Reviewer: Justin Suen <justi...@google.com>
      Gerrit-Reviewer: Xixuan Wu <xix...@chromium.org>
      Gerrit-Attention: Sergey Fetisov <sfet...@google.com>
      Gerrit-Attention: Justin Suen <justi...@google.com>
      Gerrit-Comment-Date: Sat, 02 Jul 2022 05:50:45 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      Gerrit-MessageType: comment

      Justin Suen (Gerrit)

      unread,
      Jul 6, 2022, 1:36:07 AMJul 6
      to Sergey Fetisov, Xixuan Wu, chromium...@chromium.org

      Attention is currently required from: Sergey Fetisov.

      Patch set 2:Code-Review +1

      View Change

        To view, visit change 3741276. To unsubscribe, or for help writing mail filters, visit settings.

        Gerrit-Project: infra/infra
        Gerrit-Branch: main
        Gerrit-Change-Id: Ia7365b044a461bf830a9c88e32e2ea6a57157c6e
        Gerrit-Change-Number: 3741276
        Gerrit-PatchSet: 2
        Gerrit-Owner: Sergey Fetisov <sfet...@google.com>
        Gerrit-Reviewer: Justin Suen <justi...@google.com>
        Gerrit-Reviewer: Xixuan Wu <xix...@chromium.org>
        Gerrit-Attention: Sergey Fetisov <sfet...@google.com>
        Gerrit-Comment-Date: Wed, 06 Jul 2022 05:35:52 +0000

        Sergey Fetisov (Gerrit)

        unread,
        Jul 11, 2022, 9:24:07 PMJul 11
        to Justin Suen, Xixuan Wu, chromium...@chromium.org

        Attention is currently required from: Sergey Fetisov.

        Patch set 4:Commit-Queue +2

        View Change

          To view, visit change 3741276. To unsubscribe, or for help writing mail filters, visit settings.

          Gerrit-Project: infra/infra
          Gerrit-Branch: main
          Gerrit-Change-Id: Ia7365b044a461bf830a9c88e32e2ea6a57157c6e
          Gerrit-Change-Number: 3741276
          Gerrit-PatchSet: 4
          Gerrit-Owner: Sergey Fetisov <sfet...@google.com>
          Gerrit-Reviewer: Justin Suen <justi...@google.com>
          Gerrit-Reviewer: Sergey Fetisov <sfet...@google.com>
          Gerrit-Reviewer: Xixuan Wu <xix...@chromium.org>
          Gerrit-Attention: Sergey Fetisov <sfet...@google.com>
          Gerrit-Comment-Date: Tue, 12 Jul 2022 01:23:56 +0000

          LUCI CQ (Gerrit)

          unread,
          Jul 11, 2022, 9:39:29 PMJul 11
          to Sergey Fetisov, Justin Suen, Xixuan Wu, chromium...@chromium.org

          LUCI CQ submitted this change.

          View Change



          2 is the latest approved patch-set.
          No files were changed between the latest approved patch-set and the submitted one.

          Approvals: Justin Suen: Looks good to me Xixuan Wu: Looks good to me Sergey Fetisov: Commit
          Removing UpdateDeviceRecoveryDataRequest helper used for migration to the new proto format.

          BUG=b:235869134
          TEST=unit tests
          ok infra/unifiedfleet/api/v1/rpc 0.085s

          Change-Id: Ia7365b044a461bf830a9c88e32e2ea6a57157c6e
          Reviewed-on: https://chromium-review.googlesource.com/c/infra/infra/+/3741276
          Commit-Queue: Sergey Fetisov <sfet...@google.com>
          Reviewed-by: Xixuan Wu <xix...@chromium.org>
          Reviewed-by: Justin Suen <justi...@google.com>
          Cr-Commit-Position: refs/heads/main@{#50173}
          ---
          D go/src/infra/unifiedfleet/api/v1/rpc/update_device_recovery_data_request_helper.go
          1 file changed, 18 insertions(+), 109 deletions(-)


          To view, visit change 3741276. To unsubscribe, or for help writing mail filters, visit settings.

          Gerrit-Project: infra/infra
          Gerrit-Branch: main
          Gerrit-Change-Id: Ia7365b044a461bf830a9c88e32e2ea6a57157c6e
          Gerrit-Change-Number: 3741276
          Gerrit-PatchSet: 5
          Gerrit-Owner: Sergey Fetisov <sfet...@google.com>
          Gerrit-Reviewer: Justin Suen <justi...@google.com>
          Gerrit-Reviewer: Sergey Fetisov <sfet...@google.com>
          Gerrit-Reviewer: Xixuan Wu <xix...@chromium.org>
          Gerrit-MessageType: merged
          Reply all
          Reply to author
          Forward
          0 new messages