Revert "Spanify `RedactionTool` (1/2)" [chromium/src : main]
0 views
Skip to first unread message
luci-bisection@appspot.gserviceaccount.com (Gerrit)
1:49 AM (11 hours ago) 1:49 AM
to Kalvin Lee, Chromium LUCI CQ, Xiangdong Kong, Emilia Paz, Michelle Chen, Vasilii Sukhanov, AyeAye, chromium...@chromium.org
Attention needed from Emilia Paz, Kalvin Lee, Michelle Chen, Vasilii Sukhanov and Xiangdong Kong
luci-bi...@appspot.gserviceaccount.com has uploaded the change for review![]( "Open in Gerrit")
luci-bi...@appspot.gserviceaccount.com would like Kalvin Lee, Chromium LUCI CQ, Xiangdong Kong, Emilia Paz, Michelle Chen and Vasilii Sukhanov to review this change.
Commit message
Revert "Spanify `RedactionTool` (1/2)"
This reverts commit b71bf2a194a1d2fd6a25ffb8a0c9546ba2557116.
Reason for revert:
LUCI Bisection has identified this change as the culprit of a build failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/compile-analysis/b/8690546660686992961
Sample failed build: https://ci.chromium.org/b/8690546660686992961
If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F7544238&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Fcompile-analysis%2Fb%2F8690546660686992961&type=BUG
Original change's description:
> Spanify `RedactionTool` (1/2)
>
> Broadly,
>
> 1. Convert `kBuiltInFirstPartyExtensionIds` to a `std::array` and
> inline it directly in the associated header. This exposes its size
> everywhere and makes it compatible with `base::span`.
>
> 2. Move away from trafficking `const char* const*`. Use `base::span`
> where possible, and default it to the empty span where `nullptr`
> would be passed.
>
> Bug: 439455382
> Change-Id: If3dbbdc088ece9e760ce359c8c63caab2accb8b9
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7544238
> Reviewed-by: Vasilii Sukhanov <vas...@chromium.org>
> Reviewed-by: Emilia Paz <emil...@chromium.org>
> Reviewed-by: Xiangdong Kong <xiangd...@google.com>
> Commit-Queue: Kalvin Lee <kd...@chromium.org>
> Reviewed-by: Michelle Chen <miche...@google.com>
> Cr-Commit-Position: refs/heads/main@{#1581291}
>
Bug: 439455382
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: I2905577cdea819d2a7e9f60ee6f62da478c8bf6e
Change diff
Change information
Files:
- M chrome/browser/error_reporting/chrome_js_error_report_processor.cc
- M chrome/browser/extensions/api/feedback_private/chrome_feedback_private_delegate.cc
- M chrome/browser/feedback/system_logs/about_system_logs_fetcher.cc
- M chrome/browser/feedback/system_logs/chrome_system_logs_fetcher.cc
- M chrome/browser/support_tool/ash/chrome_user_logs_data_collector_unittest.cc
- M chrome/browser/support_tool/ash/network_health_data_collector_unittest.cc
- M chrome/browser/support_tool/ash/network_routes_data_collector_unittest.cc
- M chrome/browser/support_tool/ash/shill_data_collector_unittest.cc
- M chrome/browser/support_tool/ash/system_logs_data_collector_unittest.cc
- M chrome/browser/support_tool/ash/system_state_data_collector_unittest.cc
- M chrome/browser/support_tool/signin_data_collector_browsertest.cc
- M chrome/browser/support_tool/support_tool_handler.cc
- M chrome/browser/support_tool/system_log_source_data_collector_adaptor_unittest.cc
- M chrome/browser/support_tool/updater_data_collector_unittest.cc
- M chrome/common/extensions/BUILD.gn
- A chrome/common/extensions/extension_constants.cc
- M chrome/common/extensions/extension_constants.h
- M chromeos/ash/components/specialized_features/feedback.cc
- M components/feedback/redaction_tool/redaction_tool.cc
- M components/feedback/redaction_tool/redaction_tool.h
- M components/feedback/redaction_tool_fuzzer.cc
- M components/feedback/system_logs/system_logs_fetcher.cc
- M components/feedback/system_logs/system_logs_fetcher.h
- M extensions/browser/api/feedback_private/feedback_service.cc
- M extensions/browser/api/feedback_private/log_source_access_manager.cc
- M extensions/shell/browser/system_logs/shell_system_logs_fetcher.cc
Change size: M
Delta: 26 files changed, 101 insertions(+), 86 deletions(-)
Related details
Attention is currently required from:
- Emilia Paz
- Kalvin Lee
- Michelle Chen
- Vasilii Sukhanov
- Xiangdong Kong
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
luci-bisection@appspot.gserviceaccount.com (Gerrit)
1:49 AM (11 hours ago) 1:49 AM
to Kalvin Lee, Chromium LUCI CQ, Xiangdong Kong, Emilia Paz, Michelle Chen, Vasilii Sukhanov, AyeAye, chromium...@chromium.org, extension...@chromium.org, chromium-a...@chromium.org, fuzzin...@chromium.org, oshima...@chromium.org
Attention needed from Emilia Paz, Kalvin Lee, Michelle Chen, Vasilii Sukhanov and Xiangdong Kong
luci-bi...@appspot.gserviceaccount.com voted![]( "Open in Gerrit")
LUCI Bisection is automatically submitting this revert.
| Bot-Commit | +1 |
| Commit-Queue | +2 |
| Owners-Override | +1 |
Related details
Attention is currently required from:
- Emilia Paz
- Kalvin Lee
- Michelle Chen
- Vasilii Sukhanov
- Xiangdong Kong
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
1:49 AM (11 hours ago) 1:49 AM
to luci-bi...@appspot.gserviceaccount.com, Kalvin Lee, Xiangdong Kong, Emilia Paz, Michelle Chen, Vasilii Sukhanov, AyeAye, chromium...@chromium.org, extension...@chromium.org, chromium-a...@chromium.org, fuzzin...@chromium.org, oshima...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Cr-Commit-Position: refs/heads/main@{#1581294}
Branch: refs/heads/main
Submit Requirements:
Code-Review: Bot-Commit+1 by luci-bi...@appspot.gserviceaccount.com
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jason Robert Rauch (Gerrit)
6:34 AM (6 hours ago) 6:34 AM
to luci-bi...@appspot.gserviceaccount.com, Chromium LUCI CQ, Kalvin Lee, Xiangdong Kong, Michelle Chen, Vasilii Sukhanov, AyeAye, chromium...@chromium.org, extension...@chromium.org, chromium-a...@chromium.org, fuzzin...@chromium.org, oshima...@chromium.org
Jason Robert Rauch added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Jason Robert Rauch . resolved
not that I think you will reply buy I cant save edits please see attaitched it wont let me attach a screenshot its a 404 error stating i cant edit endpoints
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jason Robert Rauch (Gerrit)
6:40 AM (6 hours ago) 6:40 AM
to luci-bi...@appspot.gserviceaccount.com, Chromium LUCI CQ, Kalvin Lee, Xiangdong Kong, Michelle Chen, Vasilii Sukhanov, AyeAye, chromium...@chromium.org, extension...@chromium.org, chromium-a...@chromium.org, fuzzin...@chromium.org, oshima...@chromium.org
Jason Robert Rauch added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Jason Robert Rauch . resolved
i apparently cant see anything now man yall really dont like me any time i say hi I loose another privlege.. Failed to load analysis details
An error occurred when querying for the analysis details using build ID "8690546660686992961":
Error: code: 7 (PERMISSION_DENIED) desc: anonymous:anonymous does not have access to method QueryAnalysis of GoFindit
Jason Robert Rauch (Gerrit)
8:34 AM (4 hours ago) 8:34 AM
to luci-bi...@appspot.gserviceaccount.com, Chromium LUCI CQ, Kalvin Lee, Xiangdong Kong, Michelle Chen, Vasilii Sukhanov, AyeAye, chromium...@chromium.org, extension...@chromium.org, chromium-a...@chromium.org, fuzzin...@chromium.org, oshima...@chromium.org
Jason Robert Rauch added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Jason Robert Rauch . resolved
I still cant do edits can either this be fixed or someone kindly do that for me ?
Jason Robert Rauch (Gerrit)
8:34 AM (4 hours ago) 8:34 AM
to luci-bi...@appspot.gserviceaccount.com, Chromium LUCI CQ, Kalvin Lee, Xiangdong Kong, Michelle Chen, Vasilii Sukhanov, AyeAye, chromium...@chromium.org, extension...@chromium.org, chromium-a...@chromium.org, fuzzin...@chromium.org, oshima...@chromium.org
Jason Robert Rauch added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Jason Robert Rauch . resolved
Failed to load analysis details
An error occurred when querying for the analysis details using build ID "8690546660686992961":
Error: code: 7 (PERMISSION_DENIED) desc: user:jjra...@gmail.com does not have access to method QueryAnalysis of GoFindit
Jason Robert Rauch (Gerrit)
8:51 AM (4 hours ago) 8:51 AM
to luci-bi...@appspot.gserviceaccount.com, Chromium LUCI CQ, Kalvin Lee, Xiangdong Kong, Michelle Chen, Vasilii Sukhanov, AyeAye, chromium...@chromium.org, extension...@chromium.org, chromium-a...@chromium.org, fuzzin...@chromium.org, oshima...@chromium.org
Jason Robert Rauch added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Jason Robert Rauch . resolved
The tree just loops me right back to the ticket am i doning something wrong?
Reply all
Reply to author
Forward
0 new messages