Alexis Wu (Gerrit)

unread,

May 27, 2026, 1:02:37 PM (yesterday) May 27

to Wenyu Fu, Chromium LUCI CQ, chromium...@chromium.org

Attention needed from Wenyu Fu

Alexis Wu added 1 comment

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Alexis Wu . resolved

Passed the run! will fix merge conflict after part 1 lands. PTAL Thank you!

Open in Gerrit

Related details

Attention is currently required from:

Wenyu Fu

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Wenyu Fu (Gerrit)

unread,

May 27, 2026, 1:05:36 PM (yesterday) May 27

to Alexis Wu, Dan Polanco, Chromium LUCI CQ, chromium...@chromium.org

Attention needed from Alexis Wu and Dan Polanco

Wenyu Fu voted and added 2 comments

Votes added by Wenyu Fu

Code-Review

+1

2 comments

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Wenyu Fu . resolved

+Dan to coreview

File chrome/browser/ui/android/bottombar/java/src/org/chromium/chrome/browser/ui/bottombar/BottomBarView.java

Line 96, Patchset 3 (Parent): if (mOtherContainers[i].hasTargetView()) {

Wenyu Fu . unresolved

Is removing this intended?

Open in Gerrit

Related details

Attention is currently required from:

Alexis Wu
Dan Polanco

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Alexis Wu (Gerrit)

unread,

May 27, 2026, 1:49:24 PM (yesterday) May 27

to Dan Polanco, Wenyu Fu, Chromium LUCI CQ, chromium...@chromium.org

Attention needed from Dan Polanco

Alexis Wu added 1 comment

File chrome/browser/ui/android/bottombar/java/src/org/chromium/chrome/browser/ui/bottombar/BottomBarView.java

Line 96, Patchset 3 (Parent): if (mOtherContainers[i].hasTargetView()) {

Wenyu Fu . resolved

Is removing this intended?

Alexis Wu

Yes, this is for lazy inflation :)

Open in Gerrit

Related details

Attention is currently required from:

Dan Polanco

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Alexis Wu (Gerrit)

unread,

May 27, 2026, 1:49:33 PM (yesterday) May 27

to Dan Polanco, Wenyu Fu, Chromium LUCI CQ, chromium...@chromium.org

Attention needed from Dan Polanco

Alexis Wu voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention is currently required from:

Dan Polanco

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Dan Polanco (Gerrit)

unread,

May 27, 2026, 2:41:09 PM (yesterday) May 27

to Alexis Wu, Wenyu Fu, Chromium LUCI CQ, chromium...@chromium.org

Attention needed from Alexis Wu

Dan Polanco added 1 comment

Patchset-level comments

File-level comment, Patchset 3:

Wenyu Fu . unresolved

+Dan to coreview

Dan Polanco

I will make sure to review and test this CL later today, let's not trigger submit for now

Open in Gerrit

Related details

Attention is currently required from:

Alexis Wu

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Wenyu Fu (Gerrit)

unread,

May 27, 2026, 6:20:34 PM (23 hours ago) May 27

to Alexis Wu, Dan Polanco, Chromium LUCI CQ, chromium...@chromium.org

Attention needed from Dan Polanco

Wenyu Fu voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Dan Polanco

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Wenyu Fu (Gerrit)

unread,

May 27, 2026, 6:37:22 PM (22 hours ago) May 27

to Alexis Wu, Dan Polanco, Chromium LUCI CQ, chromium...@chromium.org

Attention needed from Alexis Wu and Dan Polanco

Wenyu Fu added 1 comment

File chrome/browser/ui/android/bottombar/java/src/org/chromium/chrome/browser/ui/bottombar/BottomBarMediatorUnitTest.java

Line 526, Patchset 5 (Latest):


    private void createMediator(boolean shouldIncludeHomeButton) {
        createMediator(shouldIncludeHomeButton, /* shouldIncludeGlic= */ false);
    }

Wenyu Fu . unresolved

nit: Clean this up - we can just remove the `shouldIncludeGlic` from the method above

Open in Gerrit

Related details

Attention is currently required from:

Alexis Wu
Dan Polanco

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Wenyu Fu (Gerrit)

unread,

2:55 PM (2 hours ago) 2:55 PM

to Alexis Wu, Dan Polanco, Chromium LUCI CQ, chromium...@chromium.org

Attention needed from Alexis Wu and Dan Polanco

Wenyu Fu added 1 comment

Patchset-level comments

File-level comment, Patchset 3:

Wenyu Fu . unresolved

+Dan to coreview

Dan Polanco

I will make sure to review and test this CL later today, let's not trigger submit for now

Wenyu Fu

Friendly bump - we need this CL to land for branch :)

satisfied_requirement

unsatisfied_requirement

open

diffy

Dan Polanco (Gerrit)

unread,

3:42 PM (1 hour ago) 3:42 PM

to Alexis Wu, Wenyu Fu, Chromium LUCI CQ, chromium...@chromium.org

Attention needed from Alexis Wu

Dan Polanco voted and added 1 comment

Votes added by Dan Polanco

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 3:

Wenyu Fu . resolved

+Dan to coreview

Dan Polanco

I will make sure to review and test this CL later today, let's not trigger submit for now

Wenyu Fu

Friendly bump - we need this CL to land for branch :)

Dan Polanco

I tested locally and don't see major concerns. I have a quick fix to ensure we properly delay the stub inflation. We can land this for now!

Open in Gerrit

Related details

Attention is currently required from:

Alexis Wu

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Alexis Wu (Gerrit)

unread,

4:26 PM (1 hour ago) 4:26 PM

to Dan Polanco, Wenyu Fu, Chromium LUCI CQ, chromium...@chromium.org

Alexis Wu added 1 comment

File chrome/browser/ui/android/bottombar/java/src/org/chromium/chrome/browser/ui/bottombar/BottomBarMediatorUnitTest.java

Line 526, Patchset 5:


    private void createMediator(boolean shouldIncludeHomeButton) {
        createMediator(shouldIncludeHomeButton, /* shouldIncludeGlic= */ false);
    }

Wenyu Fu . resolved

nit: Clean this up - we can just remove the `shouldIncludeGlic` from the method above

Alexis Wu

Done

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Alexis Wu (Gerrit)

unread,

4:27 PM (1 hour ago) 4:27 PM

to Dan Polanco, Wenyu Fu, Chromium LUCI CQ, chromium...@chromium.org

Alexis Wu voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Reply all

Reply to author

Forward

[GlicMTBFallback2] Implement bottom bar visibility changes with Glic dynamic API [chromium/src : main]

Alexis Wu (Gerrit)

Alexis Wu added 1 comment

Related details

Wenyu Fu (Gerrit)

Wenyu Fu voted and added 2 comments

Votes added by Wenyu Fu

2 comments

Related details

Alexis Wu (Gerrit)

Alexis Wu added 1 comment

Related details

Alexis Wu (Gerrit)

Alexis Wu voted Commit-Queue+2

Related details

Dan Polanco (Gerrit)

Dan Polanco added 1 comment

Related details

Wenyu Fu (Gerrit)

Wenyu Fu voted Code-Review+1

Related details

Wenyu Fu (Gerrit)

Wenyu Fu added 1 comment

Related details

Wenyu Fu (Gerrit)

Wenyu Fu added 1 comment

Dan Polanco (Gerrit)

Dan Polanco voted and added 1 comment

Votes added by Dan Polanco

1 comment

Related details

Alexis Wu (Gerrit)

Alexis Wu added 1 comment

Related details

Alexis Wu (Gerrit)

Alexis Wu voted Commit-Queue+2

Related details