Added new SubApps Enterprise Policies [chromium/src : main]

0 views
Skip to first unread message

Vlad Krot (Gerrit)

unread,
May 4, 2026, 6:59:15 AM (yesterday) May 4
to Bhaskar Sharma, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Enterprise Policy Reviews, asvitkine...@chromium.org, dullweb...@chromium.org, msrame...@chromium.org
Attention needed from Bhaskar Sharma

Vlad Krot added 3 comments

File components/policy/resources/templates/policy_definitions/ContentSettings/SubAppsBlockedForUrls.yaml
Line 18, Patchset 2 (Latest):- file://chrome/browser/web_applications/OWNERS
Vlad Krot . unresolved

Put iwa team to owners as well

File components/policy/test/data/pref_mapping/DefaultSubAppsSetting.json
Line 10, Patchset 2 (Latest): 1,
Vlad Krot . unresolved

Why not origin like others?

File components/policy/test/data/pref_mapping/SubAppsBlockedForUrls.json
Line 14, Patchset 2 (Latest): "*"
Vlad Krot . unresolved

Are you sure it is a good value for test?

Open in Gerrit

Related details

Attention is currently required from:
  • Bhaskar Sharma
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I2fc1a0d656efaa217deba16906fa66091a6a3005
Gerrit-Change-Number: 7799884
Gerrit-PatchSet: 2
Gerrit-Owner: Bhaskar Sharma <bhaska...@google.com>
Gerrit-Reviewer: Bhaskar Sharma <bhaska...@google.com>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
Gerrit-CC: Vlad Krot <vk...@google.com>
Gerrit-Attention: Bhaskar Sharma <bhaska...@google.com>
Gerrit-Comment-Date: Mon, 04 May 2026 10:58:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Vlad Krot (Gerrit)

unread,
May 4, 2026, 7:00:28 AM (yesterday) May 4
to Bhaskar Sharma, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Enterprise Policy Reviews, asvitkine...@chromium.org, dullweb...@chromium.org, msrame...@chromium.org
Attention needed from Bhaskar Sharma

Vlad Krot added 1 comment

Commit Message
Line 7, Patchset 2 (Latest):Added new SubApps Enterprise Policies
Vlad Krot . unresolved

Add please design doc link here.

Gerrit-Comment-Date: Mon, 04 May 2026 11:00:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Bhaskar Sharma (Gerrit)

unread,
7:14 AM (1 hour ago) 7:14 AM
to Vlad Krot, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Enterprise Policy Reviews, asvitkine...@chromium.org, dullweb...@chromium.org, msrame...@chromium.org

Bhaskar Sharma abandoned this change.

View Change

Abandoned made a new cl. the branch was polluted.

Bhaskar Sharma abandoned this change

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: abandon
satisfied_requirement
unsatisfied_requirement
open
diffy

gwsq (Gerrit)

unread,
7:20 AM (1 hour ago) 7:20 AM
to Bhaskar Sharma, Enterprise Policy Reviews, Sergey Poromov, Salma Elmahallawy, Vlad Krot, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, dullweb...@chromium.org, msrame...@chromium.org
Attention needed from Salma Elmahallawy, Sergey Poromov and Vlad Krot

Message from gwsq

From chrome/enterprise/gwsq/enterprise-policy-review.gwsq:
Note: A shadow reviewer was assigned to this CL. go/new-policy-review-process
Shadowed: esalma

Reviewer source(s):
esalma, por...@chromium.org is from context(chrome/enterprise/gwsq/enterprise-policy-review.gwsq)

Open in Gerrit

Related details

Attention is currently required from:
  • Salma Elmahallawy
  • Sergey Poromov
  • Vlad Krot
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I8276dd2ee10d867fee1d682f8a18b9e8eae81aa8
Gerrit-Change-Number: 7817055
Gerrit-PatchSet: 3
Gerrit-Owner: Bhaskar Sharma <bhaska...@google.com>
Gerrit-Reviewer: Bhaskar Sharma <bhaska...@google.com>
Gerrit-Reviewer: Salma Elmahallawy <esa...@google.com>
Gerrit-Reviewer: Sergey Poromov <por...@chromium.org>
Gerrit-Reviewer: Vlad Krot <vk...@google.com>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
Gerrit-CC: gwsq
Gerrit-Attention: Salma Elmahallawy <esa...@google.com>
Gerrit-Attention: Sergey Poromov <por...@chromium.org>
Gerrit-Attention: Vlad Krot <vk...@google.com>
Gerrit-Comment-Date: Tue, 05 May 2026 11:20:00 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Vlad Krot (Gerrit)

unread,
7:24 AM (1 hour ago) 7:24 AM
to Bhaskar Sharma, Edman Anjos, Enterprise Policy Reviews, Sergey Poromov, Salma Elmahallawy, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, pwa-com...@google.com, asvitkine...@chromium.org, dullweb...@chromium.org, msrame...@chromium.org
Attention needed from Bhaskar Sharma, Edman Anjos, Salma Elmahallawy and Sergey Poromov

Vlad Krot added 2 comments

File components/policy/resources/templates/policy_definitions/ContentSettings/DefaultSubAppsWithoutPromptsSetting.yaml
Line 4, Patchset 3 (Latest): Setting the policy specifies whether Isolated Web Apps will by default be able to access Sub Apps APIs (subApps.add(), subApps.remove(), subApps.list()).
Vlad Krot . unresolved

Check in the code, it guards currently only subApps.add correct?

File components/policy/resources/templates/policy_definitions/ContentSettings/SubAppsWithoutPromptsAllowedForOrigins.yaml
Line 3, Patchset 3 (Latest): Setting the policy specifies which IWA origins will be able to use Sub Apps APIs without having the user prompted for permission.
Vlad Krot . unresolved

Only adding a sub app requires a prompt

Open in Gerrit

Related details

Attention is currently required from:
  • Bhaskar Sharma
  • Edman Anjos
  • Salma Elmahallawy
  • Sergey Poromov
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I8276dd2ee10d867fee1d682f8a18b9e8eae81aa8
    Gerrit-Change-Number: 7817055
    Gerrit-PatchSet: 3
    Gerrit-Owner: Bhaskar Sharma <bhaska...@google.com>
    Gerrit-Reviewer: Bhaskar Sharma <bhaska...@google.com>
    Gerrit-Reviewer: Edman Anjos <ed...@chromium.org>
    Gerrit-Reviewer: Salma Elmahallawy <esa...@google.com>
    Gerrit-Reviewer: Sergey Poromov <por...@chromium.org>
    Gerrit-Reviewer: Vlad Krot <vk...@google.com>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
    Gerrit-CC: gwsq
    Gerrit-Attention: Bhaskar Sharma <bhaska...@google.com>
    Gerrit-Attention: Salma Elmahallawy <esa...@google.com>
    Gerrit-Attention: Sergey Poromov <por...@chromium.org>
    Gerrit-Attention: Edman Anjos <ed...@chromium.org>
    Gerrit-Comment-Date: Tue, 05 May 2026 11:24:27 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Bhaskar Sharma (Gerrit)

    unread,
    7:43 AM (1 hour ago) 7:43 AM
    to Edman Anjos, Enterprise Policy Reviews, Sergey Poromov, Salma Elmahallawy, Vlad Krot, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, pwa-com...@google.com, asvitkine...@chromium.org, dullweb...@chromium.org, msrame...@chromium.org
    Attention needed from Edman Anjos, Salma Elmahallawy, Sergey Poromov and Vlad Krot

    Bhaskar Sharma added 2 comments

    File components/policy/resources/templates/policy_definitions/ContentSettings/DefaultSubAppsWithoutPromptsSetting.yaml
    Line 4, Patchset 3: Setting the policy specifies whether Isolated Web Apps will by default be able to access Sub Apps APIs (subApps.add(), subApps.remove(), subApps.list()).
    Vlad Krot . resolved

    Check in the code, it guards currently only subApps.add correct?

    Bhaskar Sharma

    Done

    File components/policy/resources/templates/policy_definitions/ContentSettings/SubAppsWithoutPromptsAllowedForOrigins.yaml
    Line 3, Patchset 3: Setting the policy specifies which IWA origins will be able to use Sub Apps APIs without having the user prompted for permission.
    Vlad Krot . resolved

    Only adding a sub app requires a prompt

    Bhaskar Sharma

    Done

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Edman Anjos
    • Salma Elmahallawy
    • Sergey Poromov
    • Vlad Krot
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I8276dd2ee10d867fee1d682f8a18b9e8eae81aa8
      Gerrit-Change-Number: 7817055
      Gerrit-PatchSet: 4
      Gerrit-Owner: Bhaskar Sharma <bhaska...@google.com>
      Gerrit-Reviewer: Bhaskar Sharma <bhaska...@google.com>
      Gerrit-Reviewer: Edman Anjos <ed...@chromium.org>
      Gerrit-Reviewer: Salma Elmahallawy <esa...@google.com>
      Gerrit-Reviewer: Sergey Poromov <por...@chromium.org>
      Gerrit-Reviewer: Vlad Krot <vk...@google.com>
      Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
      Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
      Gerrit-CC: gwsq
      Gerrit-Attention: Salma Elmahallawy <esa...@google.com>
      Gerrit-Attention: Sergey Poromov <por...@chromium.org>
      Gerrit-Attention: Edman Anjos <ed...@chromium.org>
      Gerrit-Attention: Vlad Krot <vk...@google.com>
      Gerrit-Comment-Date: Tue, 05 May 2026 11:42:41 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Vlad Krot <vk...@google.com>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages