Add fallback styles for <meter> element [chromium/src : main]
Traian Captan (Gerrit)
New activity on the change![]( "Open in Gerrit")
Related details
- Mason Freed
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mason Freed (Gerrit)
Mason Freed added 7 comments![]( "Open in Gerrit")
I think it'd be worth referring to tkent's CL and bug that changed this behavior in the first place:
https://chromium.googlesource.com/chromium/src/+/5bfffca95444ba872b0a7faeaf956e92ab18639f
That work happened before the blink intent process, so we just shipped it. But the intent was that meters with `appearance:none` are stylable. We should add a few tests (akin to `meter-appearance-basic-*.html` but with `appearance:none` on all elements) that ensure it stays stylable. (I'm also not sure what changed between 2016 and now that allows it to now be stylable? If you know, it'd be good to include that here also.)
And then as I mentioned, I think this'll require an intent to ship. Given that there's interop (with this change) it might be deemed "ok" to do without a spec. Let's see.
meter {
appearance: auto;
box-sizing: border-box;
display: inline-block;
block-size: 1em;It'd be nice to indent these @supports blocks.
meter::-webkit-meter-inner-element:-internal-shadow-host-has-appearance {
display: grid;
grid-template-rows: 1fr [line1] 2fr [line2] 1fr;
position: relative;
}
meter::-internal-fallback:-internal-shadow-host-has-appearance {
display: none;
}Would you mind renaming this pseudo to `internal-shadow-host-has-non-auto-appearance`? We're doing other work on appearance, and I think that should help reduce confusion.
The inner element of meter should not be deleteable.Perhaps this test should actually be fixed?
Seems like this test also needs to be repaired? It says "meter disappears"...
Does the gradient rotate on webkit/firefox? Note that it is still a vertical gradient, even when the meter is vertical. Seems (if it matches other browsers?) like it should be horizontal. If the other browsers just keep the vertical gradient, then this is ok.
Related details
- Traian Captan
Code-Coverage
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Traian Captan (Gerrit)
Traian Captan added 6 comments![]( "Open in Gerrit")
meter {
appearance: auto;
box-sizing: border-box;
display: inline-block;
block-size: 1em;It'd be nice to indent these @supports blocks.
Done
meter::-webkit-meter-inner-element:-internal-shadow-host-has-appearance {
display: grid;
grid-template-rows: 1fr [line1] 2fr [line2] 1fr;
position: relative;
}
meter::-internal-fallback:-internal-shadow-host-has-appearance {
display: none;
}Would you mind renaming this pseudo to `internal-shadow-host-has-non-auto-appearance`? We're doing other work on appearance, and I think that should help reduce confusion.
Done.
The inner element of meter should not be deleteable.Perhaps this test should actually be fixed?
The "In meter" text was the content of the `-internal-fallback` shadow element, which we don't display anymore.
Did you want to remove this part of the test?
Seems like this test also needs to be repaired? It says "meter disappears"...
Done
Does the gradient rotate on webkit/firefox? Note that it is still a vertical gradient, even when the meter is vertical. Seems (if it matches other browsers?) like it should be horizontal. If the other browsers just keep the vertical gradient, then this is ok.
- Mason Freed
Code-Coverage
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mason Freed (Gerrit)
Mason Freed voted and added 4 comments![]( "Open in Gerrit")
Votes added by Mason Freed
| Code-Review | +1 |
4 comments
I'm guessing the baselines need a bit of work, but code-wise this LGTM. Just needs an I2S before you can ship it. But this CL can land since the runtime feature is "test".
The inner element of meter should not be deleteable.Traian CaptanPerhaps this test should actually be fixed?
The "In meter" text was the content of the `-internal-fallback` shadow element, which we don't display anymore.
Did you want to remove this part of the test?
Yeah, probably. Maybe just change the text to say "meter content doesn't get rendered" or something like that?
Looks like maybe some of the baselines didn't get updated, or aren't necessary? E.g. this image still says "meter still disappears".
Traian CaptanDoes the gradient rotate on webkit/firefox? Note that it is still a vertical gradient, even when the meter is vertical. Seems (if it matches other browsers?) like it should be horizontal. If the other browsers just keep the vertical gradient, then this is ok.
The gradient does not rotate on either Safari or Firefox.
- Traian Captan
Code-Coverage
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Traian Captan (Gerrit)
Traian Captan added 1 comment![]( "Open in Gerrit")
Looks like maybe some of the baselines didn't get updated, or aren't necessary? E.g. this image still says "meter still disappears".
Yep. All the platform baselines need updating.
I had to upload the patch first to update the baseline images across all platforms. Then I have to pull them down locally and add them to the CL.
I'll mark the CL as WIP until it's ready to review again.
Related details
- Mason Freed
Code-Coverage
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |