Repaint gap decorations after item size or position changes [chromium/src : main]

0 views
Skip to first unread message

Kevin Babbitt (Gerrit)

unread,
Feb 6, 2026, 3:52:39 PM (2 days ago) Feb 6
to Alison Maher, Javier Fernandez, AyeAye, Sam Davis Omekara, Chromium LUCI CQ, chromium...@chromium.org, blink-revi...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, zol...@webkit.org
Attention needed from Alison Maher

Kevin Babbitt voted and added 2 comments

Votes added by Kevin Babbitt

Commit-Queue+1

2 comments

Patchset-level comments
File-level comment, Patchset 9 (Latest):
Kevin Babbitt . resolved

Thanks for the review almaher@.

I discovered that these changes also fixed the other invalidation bugs I had found and added WPTs for them as well; could I get a fresh CR+1?

File third_party/blink/renderer/core/layout/flex/layout_flexible_box.cc
Line 141, Patchset 2: StyleRef().HasGapRule()) {
Alison Maher . resolved

Is it possible to key off of whether we have a gap geometry instead, or is this synonymous?

Kevin Babbitt

It is, and I suppose it would be marginally faster in certain edge cases where we have property values but no actual decorations. It's not as elegant though since it requires iterating fragments. I made this change its own patchset; I'm fine keeping it but would also happily revert - let me know what you think.

Alison Maher

Forgot this would be per fragment. One idea would be if we can assume if the first fragment needs it, they all will, but what you had originally is a lot simpler, so reverting back to that sounds good to me. Was mainly thinking of the cases where we have a gap rule, but don't actually create decorations, but that is likely a rare edge case

Kevin Babbitt

Reverted.

Open in Gerrit

Related details

Attention is currently required from:
  • Alison Maher
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ic59cd47269cacaa483d19b762a7c9a5f7e19176c
Gerrit-Change-Number: 7543079
Gerrit-PatchSet: 9
Gerrit-Owner: Kevin Babbitt <kbab...@microsoft.com>
Gerrit-Reviewer: Alison Maher <alm...@microsoft.com>
Gerrit-Reviewer: Kevin Babbitt <kbab...@microsoft.com>
Gerrit-CC: Javier Fernandez <jfern...@igalia.com>
Gerrit-CC: Sam Davis Omekara <samome...@microsoft.com>
Gerrit-Attention: Alison Maher <alm...@microsoft.com>
Gerrit-Comment-Date: Fri, 06 Feb 2026 20:52:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Alison Maher <alm...@microsoft.com>
Comment-In-Reply-To: Kevin Babbitt <kbab...@microsoft.com>
satisfied_requirement
unsatisfied_requirement
open
diffy

Alison Maher (Gerrit)

unread,
Feb 6, 2026, 4:11:55 PM (2 days ago) Feb 6
to Kevin Babbitt, Javier Fernandez, AyeAye, Sam Davis Omekara, Chromium LUCI CQ, chromium...@chromium.org, blink-revi...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, zol...@webkit.org
Attention needed from Kevin Babbitt

Alison Maher voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Kevin Babbitt
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ic59cd47269cacaa483d19b762a7c9a5f7e19176c
    Gerrit-Change-Number: 7543079
    Gerrit-PatchSet: 9
    Gerrit-Owner: Kevin Babbitt <kbab...@microsoft.com>
    Gerrit-Reviewer: Alison Maher <alm...@microsoft.com>
    Gerrit-Reviewer: Kevin Babbitt <kbab...@microsoft.com>
    Gerrit-CC: Javier Fernandez <jfern...@igalia.com>
    Gerrit-CC: Sam Davis Omekara <samome...@microsoft.com>
    Gerrit-Attention: Kevin Babbitt <kbab...@microsoft.com>
    Gerrit-Comment-Date: Fri, 06 Feb 2026 21:11:46 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Kevin Babbitt (Gerrit)

    unread,
    Feb 6, 2026, 4:17:47 PM (2 days ago) Feb 6
    to Alison Maher, Javier Fernandez, AyeAye, Sam Davis Omekara, Chromium LUCI CQ, chromium...@chromium.org, blink-revi...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, zol...@webkit.org

    Kevin Babbitt voted and added 1 comment

    Votes added by Kevin Babbitt

    Commit-Queue+2

    1 comment

    Patchset-level comments
    Kevin Babbitt . resolved

    Thanks!

    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ic59cd47269cacaa483d19b762a7c9a5f7e19176c
    Gerrit-Change-Number: 7543079
    Gerrit-PatchSet: 9
    Gerrit-Owner: Kevin Babbitt <kbab...@microsoft.com>
    Gerrit-Reviewer: Alison Maher <alm...@microsoft.com>
    Gerrit-Reviewer: Kevin Babbitt <kbab...@microsoft.com>
    Gerrit-CC: Javier Fernandez <jfern...@igalia.com>
    Gerrit-CC: Sam Davis Omekara <samome...@microsoft.com>
    Gerrit-Comment-Date: Fri, 06 Feb 2026 21:17:37 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Blink W3C Test Autoroller (Gerrit)

    unread,
    Feb 6, 2026, 4:26:29 PM (2 days ago) Feb 6
    to Kevin Babbitt, Alison Maher, Javier Fernandez, AyeAye, Sam Davis Omekara, Chromium LUCI CQ, chromium...@chromium.org, blink-revi...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, zol...@webkit.org

    Message from Blink W3C Test Autoroller

    Exportable changes to web-platform-tests were detected in this CL and a pull request in the upstream repo has been made: https://github.com/web-platform-tests/wpt/pull/57628.

    When this CL lands, the bot will automatically merge the PR on GitHub if the required GitHub checks pass; otherwise, ecosystem-infra@ team will triage the failures and may contact you.

    WPT Export docs:
    https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md#Automatic-export-process

    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ic59cd47269cacaa483d19b762a7c9a5f7e19176c
    Gerrit-Change-Number: 7543079
    Gerrit-PatchSet: 9
    Gerrit-Owner: Kevin Babbitt <kbab...@microsoft.com>
    Gerrit-Reviewer: Alison Maher <alm...@microsoft.com>
    Gerrit-Reviewer: Kevin Babbitt <kbab...@microsoft.com>
    Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
    Gerrit-CC: Javier Fernandez <jfern...@igalia.com>
    Gerrit-CC: Sam Davis Omekara <samome...@microsoft.com>
    Gerrit-Comment-Date: Fri, 06 Feb 2026 21:26:23 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: No
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Feb 6, 2026, 5:40:15 PM (2 days ago) Feb 6
    to Kevin Babbitt, Blink W3C Test Autoroller, Alison Maher, Javier Fernandez, AyeAye, Sam Davis Omekara, chromium...@chromium.org, blink-revi...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, zol...@webkit.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Repaint gap decorations after item size or position changes

    Gap decorations were not being redrawn correctly after items in flex
    and grid containers were added, removed, or resized in a way that didn't
    affect the size of the container itself. The fix is to invalidate paint
    after layout when gap decorations have been specified. It may be
    possible to scope these invalidations more tightly; that is left to
    future exploration.
    Bug: 357648037
    Fixed: 480828682, 480788639, 480828683
    Change-Id: Ic59cd47269cacaa483d19b762a7c9a5f7e19176c
    Reviewed-by: Alison Maher <alm...@microsoft.com>
    Commit-Queue: Kevin Babbitt <kbab...@microsoft.com>
    Cr-Commit-Position: refs/heads/main@{#1581139}
    Files:
    • M third_party/blink/renderer/core/layout/flex/layout_flexible_box.cc
    • M third_party/blink/renderer/core/layout/flex/layout_flexible_box.h
    • M third_party/blink/renderer/core/layout/grid/layout_grid.cc
    • M third_party/blink/renderer/core/layout/grid/layout_grid.h
    • A third_party/blink/web_tests/external/wpt/css/css-gaps/flex/flex-gap-decorations-repaint-on-child-resize-ref.html
    • A third_party/blink/web_tests/external/wpt/css/css-gaps/flex/flex-gap-decorations-repaint-on-child-resize.html
    • A third_party/blink/web_tests/external/wpt/css/css-gaps/grid/grid-gap-decorations-repaint-on-child-resize-ref.html
    • A third_party/blink/web_tests/external/wpt/css/css-gaps/grid/grid-gap-decorations-repaint-on-child-resize.html
    • A third_party/blink/web_tests/external/wpt/css/css-gaps/grid/grid-gap-decorations-repaint-on-item-position-change-ref.html
    • A third_party/blink/web_tests/external/wpt/css/css-gaps/grid/grid-gap-decorations-repaint-on-item-position-change.html
    • A third_party/blink/web_tests/external/wpt/css/css-gaps/grid/grid-gap-decorations-repaint-on-item-span-change-ref.html
    • A third_party/blink/web_tests/external/wpt/css/css-gaps/grid/grid-gap-decorations-repaint-on-item-span-change.html
    Change size: L
    Delta: 12 files changed, 372 insertions(+), 2 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Alison Maher
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ic59cd47269cacaa483d19b762a7c9a5f7e19176c
    Gerrit-Change-Number: 7543079
    Gerrit-PatchSet: 10
    Gerrit-Owner: Kevin Babbitt <kbab...@microsoft.com>
    Gerrit-Reviewer: Alison Maher <alm...@microsoft.com>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Kevin Babbitt <kbab...@microsoft.com>
    Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
    open
    diffy
    satisfied_requirement

    Blink W3C Test Autoroller (Gerrit)

    unread,
    Feb 6, 2026, 6:39:15 PM (2 days ago) Feb 6
    to Chromium LUCI CQ, Kevin Babbitt, Alison Maher, Javier Fernandez, AyeAye, Sam Davis Omekara, chromium...@chromium.org, blink-revi...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, zol...@webkit.org

    Message from Blink W3C Test Autoroller

    The WPT PR for this CL has been merged upstream! https://github.com/web-platform-tests/wpt/pull/57628

    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ic59cd47269cacaa483d19b762a7c9a5f7e19176c
    Gerrit-Change-Number: 7543079
    Gerrit-PatchSet: 10
    Gerrit-Owner: Kevin Babbitt <kbab...@microsoft.com>
    Gerrit-Reviewer: Alison Maher <alm...@microsoft.com>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Kevin Babbitt <kbab...@microsoft.com>
    Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
    Gerrit-CC: Javier Fernandez <jfern...@igalia.com>
    Gerrit-CC: Sam Davis Omekara <samome...@microsoft.com>
    Gerrit-Comment-Date: Fri, 06 Feb 2026 23:39:11 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: No
    satisfied_requirement
    open
    diffy

    โฮเซ่ มาร์ติเนซ (Gerrit)

    unread,
    Feb 7, 2026, 4:45:09 PM (11 hours ago) Feb 7
    to Chromium LUCI CQ, Kevin Babbitt, Blink W3C Test Autoroller, Alison Maher, Javier Fernandez, AyeAye, Sam Davis Omekara, chromium...@chromium.org, blink-revi...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, zol...@webkit.org

    โฮเซ่ มาร์ติเนซ added 1 comment

    Patchset-level comments
    File-level comment, Patchset 10 (Latest):
    โฮเซ่ มาร์ติเนซ . resolved
    Gerrit-CC: โฮเซ่ มาร์ติเนซ <sslhub...@gmail.com>
    Gerrit-Comment-Date: Sat, 07 Feb 2026 21:44:57 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages