Adam Rice (Gerrit)

unread,

8:22 PM (3 hours ago) 8:22 PM

to Chromium LUCI CQ, Nidhi Jaju, AyeAye, chromium...@chromium.org, Chromium Metrics Reviews

Adam Rice has uploaded the change for review

Adam Rice would like Chromium LUCI CQ and Nidhi Jaju to review this change.

Commit message

Revert "Add histogram HttpCache.GenerateCacheKey.Time"

This reverts commit 6d38842ce92bf0c370ec0e2f90521c4d70652807.

Reason for revert: Enough data has been gathered for this histogram. This CL should be landed on or after 31st December 2025, to avoid the histogram being included in the stable release.


Original change's description:
> Add histogram HttpCache.GenerateCacheKey.Time
>
> Measure the real-world performance of net::HttpCache::GenerateCacheKey()
> by adding a scoped histogram, "HttpCache.GenerateCacheKey.Time".
>
> This is intended to be temporary and should be removed before the end of
> 2025.
>
> BUG=388956603
>
> Change-Id: Ice54cb5b0e21df7ad4a3ede97460953373b36ca1
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7206904
> Commit-Queue: Adam Rice <ri...@chromium.org>
> Reviewed-by: Nidhi Jaju <nidh...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1561912}

Bug: 388956603

Change-Id: I7575247cee9231f1713242aec9f5a18fe71f57fd

Change diff

diff --git a/net/http/http_cache.cc b/net/http/http_cache.cc
index 0df924a..e00065b6 100644
--- a/net/http/http_cache.cc
+++ b/net/http/http_cache.cc
@@ -734,9 +734,6 @@
     bool is_shared_resource,
     std::optional<url::Origin> initiator,
     bool include_url) {
-  // This function is very performance critical, so a histogram macro is
-  // appropriate here.
-  SCOPED_UMA_HISTOGRAM_TIMER_MICROS("HttpCache.GenerateCacheKey.Time");
   // The first character of the key may vary depending on whether or not sending
   // credentials is permitted for this request. This only happens if the
   // SplitCacheByIncludeCredentials feature is enabled.
diff --git a/tools/metrics/histograms/metadata/net/histograms.xml b/tools/metrics/histograms/metadata/net/histograms.xml
index 4d1d1b56..555a7f68 100644
--- a/tools/metrics/histograms/metadata/net/histograms.xml
+++ b/tools/metrics/histograms/metadata/net/histograms.xml
@@ -758,23 +758,6 @@
   </summary>
 </histogram>
 
-<histogram name="HttpCache.GenerateCacheKey.Time" units="microseconds"
-    expires_after="2025-12-31">
-  <owner>ri...@chromium.org</owner>
-  <owner>net...@chromium.org</owner>
-  <improvement direction="LOWER_IS_BETTER"/>
-  <summary>
-    The time spent executing the net::HttpCache::GenerateCacheKey() function.
-    Recorded once for every call to the function.
-
-    This is a temporary histogram to collect real-world performance data and
-    should be removed before 2026.
-
-    The histogram is not reported on Windows machines without high resolution
-    clocks.
-  </summary>
-</histogram>
-
 <histogram name="HttpCache.IsNoStore{Type}" enum="Boolean"
     expires_after="2026-05-17">
   <owner>ba...@chromium.org</owner>

Change information

Files:

M net/http/http_cache.cc
M tools/metrics/histograms/metadata/net/histograms.xml

Change size: S

Delta: 2 files changed, 0 insertions(+), 20 deletions(-)

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Adam Rice (Gerrit)

unread,

8:50 PM (2 hours ago) 8:50 PM

to Rubber Stamper, Chromium LUCI CQ, Nidhi Jaju, AyeAye, chromium...@chromium.org, Chromium Metrics Reviews, net-r...@chromium.org, asvitkine...@chromium.org, gavin...@chromium.org

Attention needed from Nidhi Jaju

Adam Rice voted Commit-Queue+1

Commit-Queue

+1

Open in Gerrit

Related details

Attention is currently required from:

Nidhi Jaju

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Rubber Stamper (Gerrit)

unread,

8:51 PM (2 hours ago) 8:51 PM

to Adam Rice, Chromium LUCI CQ, Nidhi Jaju, AyeAye, chromium...@chromium.org, Chromium Metrics Reviews, net-r...@chromium.org, asvitkine...@chromium.org, gavin...@chromium.org

Attention needed from Nidhi Jaju

Rubber Stamper voted Bot-Commit+1

Bot-Commit

+1

Open in Gerrit

Related details

Attention is currently required from:

Nidhi Jaju

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Nidhi Jaju (Gerrit)

unread,

8:53 PM (2 hours ago) 8:53 PM

to Adam Rice, Rubber Stamper, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, Chromium Metrics Reviews, net-r...@chromium.org, asvitkine...@chromium.org, gavin...@chromium.org

Attention needed from Adam Rice

Nidhi Jaju voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Adam Rice

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Reply all

Reply to author

Forward

Revert "Add histogram HttpCache.GenerateCacheKey.Time" [chromium/src : main]

Adam Rice (Gerrit)

Adam Rice has uploaded the change for review

Commit message

Change diff

Change information

Related details

Adam Rice (Gerrit)

Adam Rice voted Commit-Queue+1

Related details

Rubber Stamper (Gerrit)

Rubber Stamper voted Bot-Commit+1

Related details

Nidhi Jaju (Gerrit)

Nidhi Jaju voted Code-Review+1

Related details