[EVP] Add logged-out and failed states for the input field indicator [chromium/src : main]
0 views
Skip to first unread message
Christian Biesinger (Gerrit)
Jul 8, 2026, 4:19:21 PM (yesterday) Jul 8
to Christian Biesinger, Nicolás Peña, Chromium LUCI CQ, chromium...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, browser-comp...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org
Attention needed from Nicolás Peña
Christian Biesinger voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Nicolás Peña
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nicolás Peña (Gerrit)
Jul 8, 2026, 4:54:11 PM (yesterday) Jul 8
to Christian Biesinger, Chromium LUCI CQ, chromium...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, browser-comp...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org
Attention needed from Christian Biesinger
Nicolás Peña voted and added 3 comments![]( "Open in Gerrit")
Votes added by Nicolás Peña
| Code-Review | +1 |
3 comments
File components/autofill/content/browser/integrators/email_verifier/email_verifier_delegate.cc
Line 302, Patchset 5 (Latest):
result != EvpAutofillFlowResult::kSuccess) {Nicolás Peña . unresolved
Is there a reason we call UpdateEmailVerificationState() for success in a different place?
File third_party/blink/public/common/webid/email_verification_state.h
Line 15, Patchset 5 (Latest):
kFailed,Nicolás Peña . unresolved
should we lint that this enum is kept in sync with the mojom one?
File third_party/blink/renderer/core/html/forms/email_input_type.cc
Line 399, Patchset 5 (Latest):
state_str = "failed";Nicolás Peña . unresolved
Are these values queryable by the web developer?
Related details
Attention is currently required from:
- Christian Biesinger
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Christian Biesinger (Gerrit)
Jul 8, 2026, 5:37:33 PM (yesterday) Jul 8
to Christian Biesinger, Chromium IPC Reviews, Philip Rogers, Nicolás Peña, Chromium LUCI CQ, chromium...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, browser-comp...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org
Attention needed from Christoph Schwering, Chromium IPC Reviews, Joey Arhar and Philip Rogers
Christian Biesinger added 3 comments![]( "Open in Gerrit")
File components/autofill/content/browser/integrators/email_verifier/email_verifier_delegate.cc
Is there a reason we call UpdateEmailVerificationState() for success in a different place?
Christian Biesinger
No reason, put that one here.
File third_party/blink/public/common/webid/email_verification_state.h
should we lint that this enum is kept in sync with the mojom one?
Christian Biesinger
Done
File third_party/blink/renderer/core/html/forms/email_input_type.cc
Are these values queryable by the web developer?
Christian Biesinger
No, they are in the user-agent shadow DOM which website can't access.
Related details
Attention is currently required from:
- Christoph Schwering
- Chromium IPC Reviews
- Joey Arhar
- Philip Rogers
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Christoph Schwering (Gerrit)
Jul 8, 2026, 5:39:53 PM (yesterday) Jul 8
to Christian Biesinger, Chromium IPC Reviews, Philip Rogers, Nicolás Peña, Chromium LUCI CQ, chromium...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, browser-comp...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org
Attention needed from Christian Biesinger, Chromium IPC Reviews, Joey Arhar and Philip Rogers
Christoph Schwering voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Christian Biesinger
gwsq (Gerrit)
Jul 8, 2026, 5:41:17 PM (yesterday) Jul 8
to Christian Biesinger, Chromium IPC Reviews, Giovanni Ortuno Urquidi, Philip Rogers, Nicolás Peña, Chromium LUCI CQ, chromium...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, browser-comp...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org
Attention needed from Christian Biesinger, Giovanni Ortuno Urquidi, Joey Arhar and Philip Rogers
Message from gwsq![]( "Open in Gerrit")
From googleclient/chrome/chromium_gwsq/ipc/config.gwsq:
IPC: ort...@chromium.org
📎 It looks like you’re making a possibly security-sensitive change! 📎 IPC security review isn’t a rubberstamp, so your friendly security reviewer will need a fair amount of context to review your CL effectively. Please review your CL description and code comments to make sure they provide context for someone unfamiliar with your project/area. Pay special attention to where data comes from and which processes it flows between (and their privilege levels). Feel free to point your security reviewer at design docs, bugs, or other links if you can’t reasonably make a self-contained CL description. (Also see https://cbea.ms/git-commit/).
IPC reviewer(s): ort...@chromium.org
Reviewer source(s):
ort...@chromium.org is from context(googleclient/chrome/chromium_gwsq/ipc/config.gwsq)
Related details
Attention is currently required from:
- Christian Biesinger
- Giovanni Ortuno Urquidi
- Joey Arhar
- Philip Rogers
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Philip Rogers (Gerrit)
Jul 8, 2026, 6:23:23 PM (yesterday) Jul 8
to Christian Biesinger, Chromium IPC Reviews, Giovanni Ortuno Urquidi, Nicolás Peña, Chromium LUCI CQ, chromium...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, browser-comp...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org
Attention needed from Christian Biesinger, Giovanni Ortuno Urquidi and Joey Arhar
Philip Rogers voted and added 3 comments![]( "Open in Gerrit")
Votes added by Philip Rogers
| Code-Review | +1 |
3 comments
Patchset-level comments
File third_party/blink/renderer/core/html/resources/images/email_verification_failed.svg
Line 1, Patchset 6 (Latest):
<svg xmlns="http://www.w3.org/2000/svg" width="16" height="16" viewBox="0 0 24 24"><path fill="none" d="M0 0h24v24H0z"/><path fill="WindowText" d="M12 2C6.48 2 2 6.48 2 12s4.48 10 10 10 10-4.48 10-10S17.52 2 12 2zm1 15h-2v-2h2v2zm0-4h-2V7h2v6z"/></svg>Philip Rogers . unresolved
Remove `<path fill="none" d="M0 0h24v24H0z"/>`?
File third_party/blink/renderer/core/html/resources/images/email_verification_logged_out.svg
Line 1, Patchset 6 (Latest):
<svg xmlns="http://www.w3.org/2000/svg" width="16" height="16" viewBox="0 0 24 24"><path fill="WindowText" d="M12 17c1.1 0 2-.9 2-2s-.9-2-2-2-2 .9-2 2 .9 2 2 2zm6-9h-1V6c0-2.76-2.24-5-5-5S7 3.24 7 6h1.9c0-1.71 1.39-3.1 3.1-3.1 1.71 0 3.1 1.39 3.1 3.1v2H6c-1.1 0-2 .9-2 2v10c0 1.1.9 2 2 2h12c1.1 0 2-.9 2-2V10c0-1.1-.9-2-2-2zm0 12H6V10h12v10z"/><path fill="none" d="M0 0h24v24H0z"/></svg>Philip Rogers . unresolved
Remove `<path fill="none" d="M0 0h24v24H0z"/>`?
Related details
Attention is currently required from:
- Christian Biesinger
- Giovanni Ortuno Urquidi
- Joey Arhar
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Giovanni Ortuno Urquidi (Gerrit)
10:12 AM (10 hours ago) 10:12 AM
to Christian Biesinger, Philip Rogers, Chromium IPC Reviews, Giovanni Ortuno Urquidi, Nicolás Peña, Chromium LUCI CQ, chromium...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, browser-comp...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org
Attention needed from Christian Biesinger and Joey Arhar
Giovanni Ortuno Urquidi added 1 comment![]( "Open in Gerrit")
File components/autofill/content/browser/integrators/email_verifier/email_verifier_delegate.cc
Line 317, Patchset 6 (Latest):
default:
state = mojom::EmailVerificationState::kNone;
should_update = true;
break;Giovanni Ortuno Urquidi . unresolved
How come we use default here?
Related details
Attention is currently required from:
- Christian Biesinger
- Joey Arhar
Christian Biesinger (Gerrit)
2:44 PM (5 hours ago) 2:44 PM
to Christian Biesinger, Philip Rogers, Chromium IPC Reviews, Giovanni Ortuno Urquidi, Nicolás Peña, Chromium LUCI CQ, chromium...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, browser-comp...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org
Attention needed from Giovanni Ortuno Urquidi and Joey Arhar
Christian Biesinger added 4 comments![]( "Open in Gerrit")
Patchset-level comments
File components/autofill/content/browser/integrators/email_verifier/email_verifier_delegate.cc
Line 317, Patchset 6:
default:
state = mojom::EmailVerificationState::kNone;
should_update = true;
break;Giovanni Ortuno Urquidi . resolved
How come we use default here?
Christian Biesinger
Done
File third_party/blink/renderer/core/html/resources/images/email_verification_failed.svg
Line 1, Patchset 6:
<svg xmlns="http://www.w3.org/2000/svg" width="16" height="16" viewBox="0 0 24 24"><path fill="none" d="M0 0h24v24H0z"/><path fill="WindowText" d="M12 2C6.48 2 2 6.48 2 12s4.48 10 10 10 10-4.48 10-10S17.52 2 12 2zm1 15h-2v-2h2v2zm0-4h-2V7h2v6z"/></svg>Philip Rogers . resolved
Remove `<path fill="none" d="M0 0h24v24H0z"/>`?
Christian Biesinger
Done
File third_party/blink/renderer/core/html/resources/images/email_verification_logged_out.svg
Line 1, Patchset 6:
<svg xmlns="http://www.w3.org/2000/svg" width="16" height="16" viewBox="0 0 24 24"><path fill="WindowText" d="M12 17c1.1 0 2-.9 2-2s-.9-2-2-2-2 .9-2 2 .9 2 2 2zm6-9h-1V6c0-2.76-2.24-5-5-5S7 3.24 7 6h1.9c0-1.71 1.39-3.1 3.1-3.1 1.71 0 3.1 1.39 3.1 3.1v2H6c-1.1 0-2 .9-2 2v10c0 1.1.9 2 2 2h12c1.1 0 2-.9 2-2V10c0-1.1-.9-2-2-2zm0 12H6V10h12v10z"/><path fill="none" d="M0 0h24v24H0z"/></svg>Philip Rogers . resolved
Remove `<path fill="none" d="M0 0h24v24H0z"/>`?
Attention is currently required from:
- Giovanni Ortuno Urquidi
- Joey Arhar
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Giovanni Ortuno Urquidi (Gerrit)
2:55 PM (5 hours ago) 2:55 PM
to Christian Biesinger, Giovanni Ortuno Urquidi, Philip Rogers, Chromium IPC Reviews, Nicolás Peña, Chromium LUCI CQ, chromium...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, browser-comp...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org
Attention needed from Christian Biesinger and Joey Arhar
Giovanni Ortuno Urquidi voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Christian Biesinger
- Joey Arhar
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Christian Biesinger (Gerrit)
3:08 PM (5 hours ago) 3:08 PM
to Christian Biesinger, Giovanni Ortuno Urquidi, Philip Rogers, Chromium IPC Reviews, Nicolás Peña, Chromium LUCI CQ, chromium...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, browser-comp...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org
Attention needed from Joey Arhar
Christian Biesinger voted Commit-Queue+2![]( "Open in Gerrit")
Attention is currently required from:
- Joey Arhar
Chromium LUCI CQ (Gerrit)
4:51 PM (3 hours ago) 4:51 PM
to Christian Biesinger, Giovanni Ortuno Urquidi, Philip Rogers, Chromium IPC Reviews, Nicolás Peña, chromium...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, browser-comp...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[EVP] Add logged-out and failed states for the input field indicator
EvpAutofillFlowResult does not currently let us distinguish between
"email provider does not support EVP" and "user is logged out".
This CL maps both of those to a kLoggedOutOrUnsupported code.
Depending on UX feedback we can split this up.
Demo:
https://crbug.com/524671711#comment7
Bug: 524671711
Change-Id: I4fe018e03080f35d34439957ef5ca5f5c3359087
Reviewed-by: Christoph Schwering <schw...@google.com>
Reviewed-by: Philip Rogers <p...@chromium.org>
Reviewed-by: Giovanni Ortuno Urquidi <ort...@chromium.org>
Reviewed-by: Nicolás Peña <n...@chromium.org>
Commit-Queue: Christian Biesinger <cbies...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1659822}
Files:
- M components/autofill/content/browser/integrators/email_verifier/email_verifier_delegate.cc
- M components/autofill/content/browser/integrators/email_verifier/email_verifier_delegate_unittest.cc
- M components/autofill/content/renderer/autofill_agent.cc
- M components/autofill/core/common/mojom/autofill_types.mojom
- M third_party/blink/public/common/webid/email_verification_state.h
- M third_party/blink/renderer/core/html/forms/email_input_type.cc
- M third_party/blink/renderer/core/html/forms/html_input_element_test.cc
- M third_party/blink/renderer/core/html/resources/html.css
- A third_party/blink/renderer/core/html/resources/images/email_verification_failed.svg
- A third_party/blink/renderer/core/html/resources/images/email_verification_logged_out.svg
Change size: M
Delta: 10 files changed, 139 insertions(+), 7 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Christoph Schwering, +1 by Nicolás Peña, +1 by Giovanni Ortuno Urquidi, +1 by Philip Rogers
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages