[glic] Fix 'Verify It's You' crash on ChromeOS [chromium/src : main]
0 views
Skip to first unread message
Michael Wojcicka (Gerrit)
Feb 1, 2026, 2:28:36 AMFeb 1
to Sophie Chang, Achuith Bhandarkar, Mitsuru Oshima, Vincent Chiang, Zoraiz Naeem, Justin DeWitt, Carlos Knippschild, Hidehiko Abe, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org
Attention needed from Kush Sinha and Sophie Chang
Michael Wojcicka added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Michael Wojcicka . resolved
Hi Reviewers! FYI: this crash is a P0 as it is found in M144 Stable on ChromeOS, and will need to be merged back to both M144 and M145.
Related details
Attention is currently required from:
- Kush Sinha
- Sophie Chang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Sophie Chang (Gerrit)
Feb 1, 2026, 12:06:28 PMFeb 1
to Michael Wojcicka, Achuith Bhandarkar, Mitsuru Oshima, Vincent Chiang, Zoraiz Naeem, Justin DeWitt, Carlos Knippschild, Hidehiko Abe, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org
Attention needed from Kush Sinha and Michael Wojcicka
Sophie Chang voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Kush Sinha
- Michael Wojcicka
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Achuith Bhandarkar (Gerrit)
Feb 1, 2026, 1:30:55 PMFeb 1
to Michael Wojcicka, Sophie Chang, Mitsuru Oshima, Vincent Chiang, Zoraiz Naeem, Justin DeWitt, Carlos Knippschild, Hidehiko Abe, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org
Attention needed from Kush Sinha and Michael Wojcicka
Achuith Bhandarkar voted and added 1 comment![]( "Open in Gerrit")
Votes added by Achuith Bhandarkar
| Code-Review | +1 |
1 comment
Patchset-level comments
Achuith Bhandarkar . resolved
Were you able to verify that this fixes the crash? As a follow-up we should add a browsertest
Related details
Attention is currently required from:
- Kush Sinha
- Michael Wojcicka
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Wojcicka (Gerrit)
Feb 2, 2026, 1:22:06 AMFeb 2
to Achuith Bhandarkar, Sophie Chang, Mitsuru Oshima, Vincent Chiang, Zoraiz Naeem, Justin DeWitt, Carlos Knippschild, Hidehiko Abe, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org
Attention needed from Kush Sinha
Michael Wojcicka added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Achuith Bhandarkar . resolved
Were you able to verify that this fixes the crash? As a follow-up we should add a browsertest
Michael Wojcicka
Yes, I tested it on a cloudtop, and I flashed a real device with the change.
I verified that on both, the `Add Account` dialog appeared. My understanding is that it's used for reauthentication.
I wasn't able to test the whole authentication flow because the repro for this issue is difficult, but at minimum, this fixes Chrome crashing when the button is clicked, which is important.
Screenshot of the reauth screen: https://screenshot.googleplex.com/BX9M379YgtQY5KZ
Related details
Attention is currently required from:
- Kush Sinha
Kush Sinha (Gerrit)
Feb 2, 2026, 4:50:18 AMFeb 2
to Michael Wojcicka, David Roger, Achuith Bhandarkar, Sophie Chang, Mitsuru Oshima, Vincent Chiang, Zoraiz Naeem, Justin DeWitt, Carlos Knippschild, Hidehiko Abe, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org
Attention needed from Michael Wojcicka
Kush Sinha voted and added 2 comments![]( "Open in Gerrit")
Votes added by Kush Sinha
| Code-Review | +1 |
2 comments
Patchset-level comments
Kush Sinha . resolved
lgtm for account_manager_core and histograms.
cc'ing droger@ from Chrome signin team for signin/*
File tools/metrics/histograms/enums.xml
Line 144, Patchset 1 (Latest):
<int value="20" label="Gemini in Chrome asked to reauthenticate."/>Kush Sinha . unresolved
Super nit sorry - Please remove the trailing period `.` to conform to the other labels above.
Related details
Attention is currently required from:
- Michael Wojcicka
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Wojcicka (Gerrit)
Feb 2, 2026, 4:10:13 PMFeb 2
to David Roger, Achuith Bhandarkar, Sophie Chang, Mitsuru Oshima, Vincent Chiang, Zoraiz Naeem, Justin DeWitt, Carlos Knippschild, Hidehiko Abe, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org
Michael Wojcicka added 1 comment![]( "Open in Gerrit")
File tools/metrics/histograms/enums.xml
Line 144, Patchset 1:
<int value="20" label="Gemini in Chrome asked to reauthenticate."/>Kush Sinha . resolved
Super nit sorry - Please remove the trailing period `.` to conform to the other labels above.
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Wojcicka (Gerrit)
Feb 2, 2026, 4:10:17 PMFeb 2
to David Roger, Achuith Bhandarkar, Sophie Chang, Mitsuru Oshima, Vincent Chiang, Zoraiz Naeem, Justin DeWitt, Carlos Knippschild, Hidehiko Abe, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org
Michael Wojcicka voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Feb 2, 2026, 5:56:06 PMFeb 2
to Michael Wojcicka, David Roger, Achuith Bhandarkar, Sophie Chang, Mitsuru Oshima, Vincent Chiang, Zoraiz Naeem, Justin DeWitt, Carlos Knippschild, Hidehiko Abe, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org
Chromium LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
1 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: tools/metrics/histograms/enums.xml
Insertions: 1, Deletions: 1.
@@ -141,7 +141,7 @@
label="Launched from ChromeOS Projector App for re-authentication"/>
<int value="18" label="Turn on sync menu item in Chrome app menu"/>
<int value="19" label="Account addition flow triggered from a Sign-in promo"/>
- <int value="20" label="Gemini in Chrome asked to reauthenticate."/>
+ <int value="20" label="Gemini in Chrome asked to reauthenticate"/>
</enum>
<enum name="AccountManagerAccountUpsertionResultStatus">
```
Change information
Commit message:
[glic] Fix 'Verify It's You' crash on ChromeOS
- On ChromeOS, clicking the "Verify It's You" button when a user's
credentials are expired will cause Chrome to crash due to hitting
a NOTREACHED().
- This CL adds the missing signin_metrics::AccessPoint to fix the
NOTREACHED() codepath.
Bug: b:450629835
Change-Id: I1fcaecd8431369d961827b60ca9b49f6cefb5b68
Reviewed-by: Achuith Bhandarkar <ach...@chromium.org>
Reviewed-by: Kush Sinha <sin...@chromium.org>
Reviewed-by: Sophie Chang <sophi...@chromium.org>
Commit-Queue: Michael Wojcicka <mw...@google.com>
Cr-Commit-Position: refs/heads/main@{#1578412}
Files:
- M chrome/browser/signin/signin_ui_chromeos_util.cc
- M components/account_manager_core/account_manager_facade.h
- M components/account_manager_core/account_manager_facade_impl.cc
- M tools/metrics/histograms/enums.xml
Change size: S
Delta: 4 files changed, 11 insertions(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Kush Sinha, +1 by Achuith Bhandarkar, +1 by Sophie Chang
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages