Ameur Hosni (Gerrit)

unread,

May 4, 2026, 11:38:58 AM (21 hours ago) May 4

to Christian Xu, Radu Nitescu, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org

Attention needed from Christian Xu and Radu Nitescu

Ameur Hosni voted Commit-Queue+1

Commit-Queue

+1

Open in Gerrit

Related details

Attention is currently required from:

Christian Xu
Radu Nitescu

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Christian Xu (Gerrit)

unread,

May 4, 2026, 4:39:55 PM (16 hours ago) May 4

to Ameur Hosni, Chromium LUCI CQ, Radu Nitescu, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org

Attention needed from Ameur Hosni and Radu Nitescu

Christian Xu voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Ameur Hosni
Radu Nitescu

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Christian Xu (Gerrit)

unread,

5:33 AM (3 hours ago) 5:33 AM

to Ameur Hosni, Chromium LUCI CQ, Radu Nitescu, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org

Attention needed from Ameur Hosni and Radu Nitescu

Christian Xu voted and added 2 comments

Votes added by Christian Xu

Code-Review

+1

2 comments

Commit Message

Line 7, Patchset 2 (Latest):[IOS][AIM] Introduce attach current tab option

Christian Xu . unresolved

Could you share a screenshot ?

File ios/chrome/browser/composebox/menu/ui/composebox_menu_attachment_view.mm

Line 90, Patchset 2 (Latest): _titleLabel.numberOfLines = 2;

Christian Xu . unresolved

The specs seems to limit to one line.

Open in Gerrit

Related details

Attention is currently required from:

Ameur Hosni
Radu Nitescu

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Ameur Hosni (Gerrit)

unread,

6:08 AM (3 hours ago) 6:08 AM

to Christian Xu, Chromium LUCI CQ, Radu Nitescu, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org

Attention needed from Christian Xu and Radu Nitescu

Ameur Hosni voted and added 2 comments

Votes added by Ameur Hosni

Auto-Submit	+1
Commit-Queue	+1

2 comments

Commit Message

Line 7, Patchset 2:[IOS][AIM] Introduce attach current tab option

Christian Xu . resolved

Could you share a screenshot ?

Ameur Hosni

Done

File ios/chrome/browser/composebox/menu/ui/composebox_menu_attachment_view.mm

Line 90, Patchset 2: _titleLabel.numberOfLines = 2;

Christian Xu . resolved

The specs seems to limit to one line.

Ameur Hosni

Done

Open in Gerrit

Related details

Attention is currently required from:

Christian Xu
Radu Nitescu

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Christian Xu (Gerrit)

unread,

6:25 AM (2 hours ago) 6:25 AM

to Ameur Hosni, Chromium LUCI CQ, Radu Nitescu, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org

Attention needed from Ameur Hosni and Radu Nitescu

Christian Xu voted and added 1 comment

Votes added by Christian Xu

Code-Review

+1

1 comment

File ios/chrome/browser/composebox/menu/ui/composebox_menu_view_controller.mm

Line 409, Patchset 4 (Latest): disabled:NO

Christian Xu . unresolved

current tab can also be disabled.

Open in Gerrit

Related details

Attention is currently required from:

Ameur Hosni
Radu Nitescu

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Ameur Hosni (Gerrit)

unread,

7:16 AM (1 hour ago) 7:16 AM

to android-bu...@system.gserviceaccount.com, Christian Xu, Chromium LUCI CQ, Radu Nitescu, chromium...@chromium.org, srahim...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org

Attention needed from Radu Nitescu

Ameur Hosni voted and added 1 comment

Votes added by Ameur Hosni

Auto-Submit	+1
Commit-Queue	+2

1 comment

File ios/chrome/browser/composebox/menu/ui/composebox_menu_view_controller.mm

Line 409, Patchset 4: disabled:NO

Christian Xu . resolved

current tab can also be disabled.

Ameur Hosni

Nice catch!

Open in Gerrit

Related details

Attention is currently required from:

Radu Nitescu

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

8:19 AM (23 minutes ago) 8:19 AM

to Ameur Hosni, android-bu...@system.gserviceaccount.com, Christian Xu, Radu Nitescu, chromium...@chromium.org, srahim...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org

Chromium LUCI CQ submitted the change with unreviewed changes

Unreviewed changes

4 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:

```
The name of the file: ios/chrome/browser/composebox/menu/ui/composebox_menu_view_controller.mm
Insertions: 2, Deletions: 1.

@@ -406,7 +406,8 @@
               image:DefaultSymbolWithPointSize(kGlobeSymbol,
                                                kSymbolActionPointSize)
                type:ComposeboxMenuItemType::kCurrentTab
-           disabled:NO
+           disabled:[_inputState isAttachmentDisabled:
+                                     ComposeboxAttachmentOption::kCurrentTab]
             favicon:_inputState.currentTabFavicon];
   ComposeboxMenuItem* tabsItem = [[ComposeboxMenuItem alloc]
       initWithTitle:l10n_util::GetNSString(IDS_IOS_COMPOSEBOX_SELECT_TAB_ACTION)
```

Change information

Commit message:

[IOS][AIM] Introduce attach current tab option

https://screenshot.googleplex.com/BnRqPN4EGSFdbTG

Bug: 509514884

Change-Id: I717825e56d4ba4d14fc31767ffa4d97535c556c0

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7813856

Commit-Queue: Ameur Hosni <ameur...@google.com>

Reviewed-by: Christian Xu <chris...@chromium.org>

Auto-Submit: Ameur Hosni <ameur...@google.com>

Cr-Commit-Position: refs/heads/main@{#1625335}

Files:

M ios/chrome/app/strings/ios_strings.grd
A ios/chrome/app/strings/ios_strings_grd/IDS_IOS_COMPOSEBOX_MENU_CURRENT_TAB_ACTION.png.sha1
M ios/chrome/browser/composebox/menu/coordinator/composebox_menu_mediator.mm
M ios/chrome/browser/composebox/menu/ui/composebox_menu_attachment_cell.mm
M ios/chrome/browser/composebox/menu/ui/composebox_menu_item.h
M ios/chrome/browser/composebox/menu/ui/composebox_menu_item.mm
M ios/chrome/browser/composebox/menu/ui/composebox_menu_item_type.h
M ios/chrome/browser/composebox/menu/ui/composebox_menu_view_controller.mm

Change size: M

Delta: 8 files changed, 71 insertions(+), 9 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Christian Xu

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

[IOS][AIM] Introduce attach current tab option [chromium/src : main]

Ameur Hosni (Gerrit)

Ameur Hosni voted Commit-Queue+1

Related details

Christian Xu (Gerrit)

Christian Xu voted Code-Review+1

Related details

Christian Xu (Gerrit)

Christian Xu voted and added 2 comments

Votes added by Christian Xu

2 comments

Related details

Ameur Hosni (Gerrit)

Ameur Hosni voted and added 2 comments

Votes added by Ameur Hosni

2 comments

Related details

Christian Xu (Gerrit)

Christian Xu voted and added 1 comment

Votes added by Christian Xu

1 comment

Related details

Ameur Hosni (Gerrit)

Ameur Hosni voted and added 1 comment

Votes added by Ameur Hosni

1 comment

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change with unreviewed changes

Unreviewed changes

Change information