[Lens] Add full height support for followups. [chromium/src : main]

0 views
Skip to first unread message

Radu Nitescu (Gerrit)

unread,
5:09 AM (3 hours ago) 5:09 AM
to Charles Yang, Chromium LUCI CQ, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Charles Yang

Radu Nitescu voted and added 1 comment

Votes added by Radu Nitescu

Code-Review+1

1 comment

File ios/chrome/browser/lens_overlay/model/lens_overlay_detents_manager.mm
Line 343, Patchset 4 (Latest): return [weakSelf windowHeight] - [weakSelf statusBarHeight];
Radu Nitescu . unresolved

can you check compact iPad with window mode? My concern is that the subtracting the status bar height wouldn't be needed there.

Open in Gerrit

Related details

Attention is currently required from:
  • Charles Yang
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Iaae5402a98a1dd0af0ede31dedfc4118f5cba360
Gerrit-Change-Number: 8141424
Gerrit-PatchSet: 4
Gerrit-Owner: Charles Yang <cmy...@google.com>
Gerrit-Reviewer: Charles Yang <cmy...@google.com>
Gerrit-Reviewer: Radu Nitescu <radun...@google.com>
Gerrit-Attention: Charles Yang <cmy...@google.com>
Gerrit-Comment-Date: Fri, 24 Jul 2026 09:09:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages