Dave Tapuska (Gerrit)

unread,

Jan 13, 2026, 2:47:39 PMJan 13

to James Cook, Colin Blundell, Bo Liu, Andrey Kosyakov, Reilly Grant, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Andrew Rayskiy, Permissions Reviews, Rijubrata Bhaumik, Simon Hangl, James Su, mac-r...@chromium.org, alexmo...@chromium.org, andysjl...@chromium.org, cc-...@chromium.org, chfreme...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromium-a...@chromium.org, creis...@chromium.org, dewitt...@chromium.org, druber...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, headless...@chromium.org, jbauma...@chromium.org, jdonnel...@chromium.org, jophba...@chromium.org, keithle...@chromium.org, lens-chrome...@google.com, mercer...@google.com, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org, navigation...@chromium.org, nona+...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, oshima...@chromium.org, rmcelra...@chromium.org, shuche...@chromium.org, stanfie...@google.com, tranbaod...@chromium.org, vakh+safe_br...@chromium.org, xinghui...@chromium.org, yhanad...@chromium.org, zackha...@chromium.org

Attention needed from Andrey Kosyakov, Bo Liu, Colin Blundell, James Cook and Reilly Grant

Dave Tapuska added 1 comment

Patchset-level comments

File-level comment, Patchset 4 (Latest):

Dave Tapuska . resolved

reilly@ extensions
boliu@ ui/android, content/
caseq@ headless/
blundell@ chrome & components

Open in Gerrit

Related details

Attention is currently required from:

Andrey Kosyakov
Bo Liu
Colin Blundell
James Cook
Reilly Grant

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Colin Blundell (Gerrit)

unread,

Jan 13, 2026, 2:54:19 PMJan 13

to Dave Tapuska, Colin Blundell, James Cook, Bo Liu, Andrey Kosyakov, Reilly Grant, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Andrew Rayskiy, Permissions Reviews, Rijubrata Bhaumik, Simon Hangl, James Su, mac-r...@chromium.org, alexmo...@chromium.org, andysjl...@chromium.org, cc-...@chromium.org, chfreme...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromium-a...@chromium.org, creis...@chromium.org, dewitt...@chromium.org, druber...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, headless...@chromium.org, jbauma...@chromium.org, jdonnel...@chromium.org, jophba...@chromium.org, keithle...@chromium.org, lens-chrome...@google.com, mercer...@google.com, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org, navigation...@chromium.org, nona+...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, oshima...@chromium.org, rmcelra...@chromium.org, shuche...@chromium.org, stanfie...@google.com, tranbaod...@chromium.org, vakh+safe_br...@chromium.org, xinghui...@chromium.org, yhanad...@chromium.org, zackha...@chromium.org

Attention needed from Andrey Kosyakov, Bo Liu, Dave Tapuska, James Cook and Reilly Grant

Colin Blundell voted and added 2 comments

Votes added by Colin Blundell

Code-Review

+1

2 comments

Patchset-level comments

File-level comment, Patchset 4 (Latest):

Colin Blundell . resolved

Thanks! LGTM with question

File components/viz/common/frame_sinks/copy_output_result.cc

Line 350, Patchset 4 (Latest): if (result_) {

Colin Blundell . unresolved

Was this intended to be part of this CL?

Open in Gerrit

Related details

Attention is currently required from:

Andrey Kosyakov
Bo Liu
Dave Tapuska
James Cook
Reilly Grant

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Dave Tapuska (Gerrit)

unread,

Jan 13, 2026, 3:17:23 PMJan 13

to Colin Blundell, James Cook, Bo Liu, Andrey Kosyakov, Reilly Grant, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Andrew Rayskiy, Permissions Reviews, Rijubrata Bhaumik, Simon Hangl, James Su, mac-r...@chromium.org, alexmo...@chromium.org, andysjl...@chromium.org, cc-...@chromium.org, chfreme...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromium-a...@chromium.org, creis...@chromium.org, dewitt...@chromium.org, druber...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, headless...@chromium.org, jbauma...@chromium.org, jdonnel...@chromium.org, jophba...@chromium.org, keithle...@chromium.org, lens-chrome...@google.com, mercer...@google.com, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org, navigation...@chromium.org, nona+...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, oshima...@chromium.org, rmcelra...@chromium.org, shuche...@chromium.org, stanfie...@google.com, tranbaod...@chromium.org, vakh+safe_br...@chromium.org, xinghui...@chromium.org, yhanad...@chromium.org, zackha...@chromium.org

Attention needed from Andrey Kosyakov, Bo Liu, Colin Blundell, James Cook and Reilly Grant

Dave Tapuska added 1 comment

File components/viz/common/frame_sinks/copy_output_result.cc

Line 350, Patchset 4: if (result_) {

Colin Blundell . resolved

Was this intended to be part of this CL?

Dave Tapuska

Yes this can be removed from this CL. Done

Open in Gerrit

Related details

Attention is currently required from:

Andrey Kosyakov
Bo Liu
Colin Blundell
James Cook
Reilly Grant

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Andrey Kosyakov (Gerrit)

unread,

Jan 13, 2026, 3:35:26 PMJan 13

to Dave Tapuska, Colin Blundell, James Cook, Bo Liu, Reilly Grant, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Andrew Rayskiy, Permissions Reviews, Rijubrata Bhaumik, Simon Hangl, James Su, mac-r...@chromium.org, alexmo...@chromium.org, andysjl...@chromium.org, cc-...@chromium.org, chfreme...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromium-a...@chromium.org, creis...@chromium.org, dewitt...@chromium.org, druber...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, headless...@chromium.org, jbauma...@chromium.org, jdonnel...@chromium.org, jophba...@chromium.org, keithle...@chromium.org, lens-chrome...@google.com, mercer...@google.com, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org, navigation...@chromium.org, nona+...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, oshima...@chromium.org, rmcelra...@chromium.org, shuche...@chromium.org, stanfie...@google.com, tranbaod...@chromium.org, vakh+safe_br...@chromium.org, xinghui...@chromium.org, yhanad...@chromium.org, zackha...@chromium.org

Attention needed from Bo Liu, Colin Blundell, Dave Tapuska, James Cook and Reilly Grant

Andrey Kosyakov voted and added 1 comment

Votes added by Andrey Kosyakov

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 5 (Latest):

Andrey Kosyakov . resolved

headless/ lgtm

Open in Gerrit

Related details

Attention is currently required from:

Bo Liu
Colin Blundell
Dave Tapuska
James Cook
Reilly Grant

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

satisfied_requirement

unsatisfied_requirement

open

diffy

James Cook (Gerrit)

unread,

Jan 13, 2026, 4:01:07 PMJan 13

to Dave Tapuska, Andrey Kosyakov, Colin Blundell, Bo Liu, Reilly Grant, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Andrew Rayskiy, Permissions Reviews, Rijubrata Bhaumik, Simon Hangl, James Su, mac-r...@chromium.org, alexmo...@chromium.org, andysjl...@chromium.org, cc-...@chromium.org, chfreme...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromium-a...@chromium.org, creis...@chromium.org, dewitt...@chromium.org, druber...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, headless...@chromium.org, jbauma...@chromium.org, jdonnel...@chromium.org, jophba...@chromium.org, keithle...@chromium.org, lens-chrome...@google.com, mercer...@google.com, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org, navigation...@chromium.org, nona+...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, oshima...@chromium.org, rmcelra...@chromium.org, shuche...@chromium.org, stanfie...@google.com, tranbaod...@chromium.org, vakh+safe_br...@chromium.org, xinghui...@chromium.org, yhanad...@chromium.org, zackha...@chromium.org

Attention needed from Bo Liu, Colin Blundell, Dave Tapuska and Reilly Grant

James Cook voted and added 1 comment

Votes added by James Cook

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 5 (Latest):

James Cook . resolved

LGTM for chromeos

Open in Gerrit

Related details

Attention is currently required from:

Bo Liu
Colin Blundell
Dave Tapuska

Reilly Grant

Submit Requirements:

Code-Coverage
Code-Owners

satisfied_requirement

open

diffy

Bo Liu (Gerrit)

unread,

Jan 13, 2026, 5:43:08 PMJan 13

to Dave Tapuska, James Cook, Andrey Kosyakov, Colin Blundell, Bo Liu, Reilly Grant, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Andrew Rayskiy, Permissions Reviews, Rijubrata Bhaumik, Simon Hangl, James Su, mac-r...@chromium.org, alexmo...@chromium.org, andysjl...@chromium.org, cc-...@chromium.org, chfreme...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromium-a...@chromium.org, creis...@chromium.org, dewitt...@chromium.org, druber...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, headless...@chromium.org, jbauma...@chromium.org, jdonnel...@chromium.org, jophba...@chromium.org, keithle...@chromium.org, lens-chrome...@google.com, mercer...@google.com, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org, navigation...@chromium.org, nona+...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, oshima...@chromium.org, rmcelra...@chromium.org, shuche...@chromium.org, stanfie...@google.com, tranbaod...@chromium.org, vakh+safe_br...@chromium.org, xinghui...@chromium.org, yhanad...@chromium.org, zackha...@chromium.org

Attention needed from Colin Blundell, Dave Tapuska and Reilly Grant

Bo Liu added 2 comments

File content/public/browser/render_widget_host_view.h

Line 243, Patchset 5 (Latest): base::TimeDelta timeout,

Bo Liu . unresolved

add docs

File ui/android/delegated_frame_host_android.cc

Line 196, Patchset 5 (Latest): base::TimeDelta timeout,

Bo Liu . unresolved

going to use it here I assume?

Open in Gerrit

Related details

Attention is currently required from:

Colin Blundell
Dave Tapuska
Reilly Grant

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

No-Unresolved-Comments
Review-Enforcement

satisfied_requirement

unsatisfied_requirement

open

diffy

Reilly Grant (Gerrit)

unread,

Jan 13, 2026, 6:04:41 PMJan 13

to Dave Tapuska, Reilly Grant, James Cook, Andrey Kosyakov, Colin Blundell, Bo Liu, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Andrew Rayskiy, Permissions Reviews, Rijubrata Bhaumik, Simon Hangl, James Su, mac-r...@chromium.org, alexmo...@chromium.org, andysjl...@chromium.org, cc-...@chromium.org, chfreme...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromium-a...@chromium.org, creis...@chromium.org, dewitt...@chromium.org, druber...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, headless...@chromium.org, jbauma...@chromium.org, jdonnel...@chromium.org, jophba...@chromium.org, keithle...@chromium.org, lens-chrome...@google.com, mercer...@google.com, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org, navigation...@chromium.org, nona+...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, oshima...@chromium.org, rmcelra...@chromium.org, shuche...@chromium.org, stanfie...@google.com, tranbaod...@chromium.org, vakh+safe_br...@chromium.org, xinghui...@chromium.org, yhanad...@chromium.org, zackha...@chromium.org

Attention needed from Colin Blundell and Dave Tapuska

Reilly Grant voted and added 1 comment

Votes added by Reilly Grant

Code-Review

+1

1 comment

File extensions/browser/api/web_contents_capture_client.cc

Line 81, Patchset 5 (Latest):

      source_rect,  // An empty rect will capture the entire surface.
      gfx::Size(),  // Result contains device-level detail.
      base::TimeDelta(),

Reilly Grant . unresolved

It seems like these comments have gotten moved around and are now unclear.

```suggestion
      source_rect,
      gfx::Size(),        // Capture the entire surface.
      base::TimeDelta(),  // No timeout.
      // `result` contains device-level detail.
```

Open in Gerrit

Related details

Attention is currently required from:

Colin Blundell
Dave Tapuska

satisfied_requirement

unsatisfied_requirement

open

diffy

Dave Tapuska (Gerrit)

unread,

Jan 14, 2026, 11:31:00 AMJan 14

to Reilly Grant, James Cook, Andrey Kosyakov, Colin Blundell, Bo Liu, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Andrew Rayskiy, Permissions Reviews, Rijubrata Bhaumik, Simon Hangl, James Su, mac-r...@chromium.org, alexmo...@chromium.org, andysjl...@chromium.org, cc-...@chromium.org, chfreme...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromium-a...@chromium.org, creis...@chromium.org, dewitt...@chromium.org, druber...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, headless...@chromium.org, jbauma...@chromium.org, jdonnel...@chromium.org, jophba...@chromium.org, keithle...@chromium.org, lens-chrome...@google.com, mercer...@google.com, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org, navigation...@chromium.org, nona+...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, oshima...@chromium.org, rmcelra...@chromium.org, shuche...@chromium.org, stanfie...@google.com, tranbaod...@chromium.org, vakh+safe_br...@chromium.org, xinghui...@chromium.org, yhanad...@chromium.org, zackha...@chromium.org

Attention needed from Bo Liu and Colin Blundell

Dave Tapuska voted and added 3 comments

Votes added by Dave Tapuska

Commit-Queue

+2

3 comments

File content/public/browser/render_widget_host_view.h

Line 243, Patchset 5: base::TimeDelta timeout,

Bo Liu . resolved

add docs

Dave Tapuska

Done

File extensions/browser/api/web_contents_capture_client.cc

Line 81, Patchset 5: source_rect, // An empty rect will capture the entire surface.


      gfx::Size(),  // Result contains device-level detail.
      base::TimeDelta(),

Reilly Grant . resolved

It seems like these comments have gotten moved around and are now unclear.

```suggestion
      source_rect,
      gfx::Size(),        // Capture the entire surface.
      base::TimeDelta(),  // No timeout.
      // `result` contains device-level detail.
```

Dave Tapuska

Done

File ui/android/delegated_frame_host_android.cc

Line 196, Patchset 5: base::TimeDelta timeout,

Bo Liu . resolved

going to use it here I assume?

Dave Tapuska

The primary target is for desktop so I missed the passing this into the HostFrameSinkManager, good catch. Fixed.

Open in Gerrit

Related details

Attention is currently required from:

Bo Liu
Colin Blundell

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Dave Tapuska (Gerrit)

unread,

Jan 14, 2026, 1:03:13 PMJan 14

to Reilly Grant, James Cook, Andrey Kosyakov, Colin Blundell, Bo Liu, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Andrew Rayskiy, Permissions Reviews, Rijubrata Bhaumik, Simon Hangl, James Su, mac-r...@chromium.org, alexmo...@chromium.org, andysjl...@chromium.org, cc-...@chromium.org, chfreme...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromium-a...@chromium.org, creis...@chromium.org, dewitt...@chromium.org, druber...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, headless...@chromium.org, jbauma...@chromium.org, jdonnel...@chromium.org, jophba...@chromium.org, keithle...@chromium.org, lens-chrome...@google.com, mercer...@google.com, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org, navigation...@chromium.org, nona+...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, oshima...@chromium.org, rmcelra...@chromium.org, shuche...@chromium.org, stanfie...@google.com, tranbaod...@chromium.org, vakh+safe_br...@chromium.org, xinghui...@chromium.org, yhanad...@chromium.org, zackha...@chromium.org

Attention needed from Bo Liu and Colin Blundell

Dave Tapuska voted Commit-Queue+2

Commit-Queue

+2

satisfied_requirement

open

diffy

Dave Tapuska (Gerrit)

unread,

Jan 14, 2026, 2:51:10 PMJan 14

to Reilly Grant, James Cook, Andrey Kosyakov, Colin Blundell, Bo Liu, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Andrew Rayskiy, Permissions Reviews, Rijubrata Bhaumik, Simon Hangl, James Su, mac-r...@chromium.org, alexmo...@chromium.org, andysjl...@chromium.org, cc-...@chromium.org, chfreme...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromium-a...@chromium.org, creis...@chromium.org, dewitt...@chromium.org, druber...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, headless...@chromium.org, jbauma...@chromium.org, jdonnel...@chromium.org, jophba...@chromium.org, keithle...@chromium.org, lens-chrome...@google.com, mercer...@google.com, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org, navigation...@chromium.org, nona+...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, oshima...@chromium.org, rmcelra...@chromium.org, shuche...@chromium.org, stanfie...@google.com, tranbaod...@chromium.org, vakh+safe_br...@chromium.org, xinghui...@chromium.org, yhanad...@chromium.org, zackha...@chromium.org

Attention needed from Bo Liu and Colin Blundell

Dave Tapuska voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention is currently required from:

Bo Liu
Colin Blundell

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Jan 14, 2026, 4:46:52 PMJan 14

to Dave Tapuska, Reilly Grant, James Cook, Andrey Kosyakov, Colin Blundell, Bo Liu, AyeAye, chromium...@chromium.org, Andrew Rayskiy, Permissions Reviews, Rijubrata Bhaumik, Simon Hangl, James Su, mac-r...@chromium.org, alexmo...@chromium.org, andysjl...@chromium.org, cc-...@chromium.org, chfreme...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromium-a...@chromium.org, creis...@chromium.org, dewitt...@chromium.org, druber...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, headless...@chromium.org, jbauma...@chromium.org, jdonnel...@chromium.org, jophba...@chromium.org, keithle...@chromium.org, lens-chrome...@google.com, mercer...@google.com, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org, navigation...@chromium.org, nona+...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, oshima...@chromium.org, rmcelra...@chromium.org, shuche...@chromium.org, stanfie...@google.com, tranbaod...@chromium.org, vakh+safe_br...@chromium.org, xinghui...@chromium.org, yhanad...@chromium.org, zackha...@chromium.org

Chromium LUCI CQ submitted the change with unreviewed changes

Unreviewed changes

5 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:

```
The name of the file: content/public/browser/render_widget_host_view.h
Insertions: 4, Deletions: 0.

The diff is too large to show. Please review the diff.
```
```
The name of the file: extensions/browser/api/web_contents_capture_client.cc
Insertions: 4, Deletions: 3.

The diff is too large to show. Please review the diff.
```
```
The name of the file: ui/android/delegated_frame_host_android.cc
Insertions: 2, Deletions: 2.

The diff is too large to show. Please review the diff.
```

Change information

Commit message:

Add timeouts to content API for CopyFromSurface

A later change will adjust this value for the multi source page
context fetcher.

Bug: b:447589565

Change-Id: Ia8738a27f97731ec029870ffc9c50fe0b2b6dd04

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7454865

Reviewed-by: Andrey Kosyakov <ca...@chromium.org>

Reviewed-by: Reilly Grant <rei...@chromium.org>

Reviewed-by: James Cook <jame...@chromium.org>

Commit-Queue: Dave Tapuska <dtap...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1569302}

Files:

M chrome/browser/actor/execution_engine_browsertest.cc
M chrome/browser/ai/ai_data_keyed_service.cc
M chrome/browser/android/compositor/tab_content_manager.cc
M chrome/browser/glic/widget/inactive_view_controller.cc
M chrome/browser/media/webrtc/current_tab_desktop_media_list.cc
M chrome/browser/media/webrtc/tab_desktop_media_list.cc
M chrome/browser/page_content_annotations/multi_source_page_context_fetcher.cc
M chrome/browser/permissions/prediction_service/permissions_ai_ui_selector.cc
M chrome/browser/ui/contextual_search/tab_contextualization_controller.cc
M chrome/browser/ui/lens/lens_overlay_blur_layer_delegate.cc
M chrome/browser/ui/lens/lens_search_contextualization_controller.cc
M chrome/browser/ui/omnibox/chrome_omnibox_client.cc
M chrome/browser/ui/thumbnails/thumbnail_tab_helper.cc
M chrome/browser/ui/views/desktop_capture/share_this_tab_source_view.cc
M chrome/browser/ui/views/tabs/dragging/tab_drag_controller.cc
M chromeos/ash/experiences/clipboard/clipboard_image_model_request.cc
M components/safe_browsing/content/browser/password_protection/password_protection_request_content.cc
M content/browser/navigation_browsertest.cc
M content/browser/renderer_host/delegated_frame_host.cc
M content/browser/renderer_host/delegated_frame_host.h
M content/browser/renderer_host/delegated_frame_host_unittest.cc
M content/browser/renderer_host/render_widget_host_impl.cc
M content/browser/renderer_host/render_widget_host_view_android.cc
M content/browser/renderer_host/render_widget_host_view_android.h
M content/browser/renderer_host/render_widget_host_view_aura.cc
M content/browser/renderer_host/render_widget_host_view_aura.h
M content/browser/renderer_host/render_widget_host_view_base.cc
M content/browser/renderer_host/render_widget_host_view_base.h
M content/browser/renderer_host/render_widget_host_view_browsertest.cc
M content/browser/renderer_host/render_widget_host_view_child_frame.cc
M content/browser/renderer_host/render_widget_host_view_child_frame.h
M content/browser/renderer_host/render_widget_host_view_ios.h
M content/browser/renderer_host/render_widget_host_view_ios.mm
M content/browser/renderer_host/render_widget_host_view_mac.h
M content/browser/renderer_host/render_widget_host_view_mac.mm
M content/browser/renderer_host/view_transition_browsertest.cc
M content/public/browser/render_widget_host_view.h
M content/public/test/browser_test_utils.cc
M content/web_test/browser/web_test_control_host.cc
M extensions/browser/api/web_contents_capture_client.cc
M headless/lib/browser/headless_web_contents_impl.cc
M ui/android/delegated_frame_host_android.cc
M ui/android/delegated_frame_host_android.h

Change size: M

Delta: 43 files changed, 82 insertions(+), 48 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Reilly Grant, +1 by James Cook, +1 by Andrey Kosyakov

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

Add timeouts to content API for CopyFromSurface [chromium/src : main]

Dave Tapuska (Gerrit)

Dave Tapuska added 1 comment

Related details

Colin Blundell (Gerrit)

Colin Blundell voted and added 2 comments

Votes added by Colin Blundell

2 comments

Related details

Dave Tapuska (Gerrit)

Dave Tapuska added 1 comment

Related details

Andrey Kosyakov (Gerrit)

Andrey Kosyakov voted and added 1 comment

Votes added by Andrey Kosyakov

1 comment

Related details

James Cook (Gerrit)

James Cook voted and added 1 comment

Votes added by James Cook

1 comment

Related details

Bo Liu (Gerrit)

Bo Liu added 2 comments

Related details

Reilly Grant (Gerrit)

Reilly Grant voted and added 1 comment

Votes added by Reilly Grant

1 comment

Related details

Dave Tapuska (Gerrit)

Dave Tapuska voted and added 3 comments

Votes added by Dave Tapuska

3 comments

Related details

Dave Tapuska (Gerrit)

Dave Tapuska voted Commit-Queue+2

Dave Tapuska (Gerrit)

Dave Tapuska voted Commit-Queue+2

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change with unreviewed changes

Unreviewed changes

Change information