Remove unused fields for 'animation-trigger' and 'timeline-trigger-name' [chromium/src : main]

0 views
Skip to first unread message

Fredrik Söderquist (Gerrit)

unread,
4:35 AM (4 hours ago) 4:35 AM
to Rune Lillesveen, Menard, Alexis, chromium...@chromium.org, Chromium LUCI CQ, apavlo...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org
Attention needed from Rune Lillesveen

Fredrik Söderquist voted Auto-Submit+1

Auto-Submit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Rune Lillesveen
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ic0c5d5da6a9ea51b7795ce4c13ec23f65665744a
Gerrit-Change-Number: 8140359
Gerrit-PatchSet: 2
Gerrit-Owner: Fredrik Söderquist <f...@opera.com>
Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>
Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-Attention: Rune Lillesveen <fut...@chromium.org>
Gerrit-Comment-Date: Fri, 24 Jul 2026 08:35:11 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Rune Lillesveen (Gerrit)

unread,
5:08 AM (3 hours ago) 5:08 AM
to Fredrik Söderquist, Rune Lillesveen, Menard, Alexis, chromium...@chromium.org, Chromium LUCI CQ, apavlo...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org
Attention needed from Fredrik Söderquist

Rune Lillesveen voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Fredrik Söderquist
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ic0c5d5da6a9ea51b7795ce4c13ec23f65665744a
    Gerrit-Change-Number: 8140359
    Gerrit-PatchSet: 2
    Gerrit-Owner: Fredrik Söderquist <f...@opera.com>
    Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>
    Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
    Gerrit-CC: Menard, Alexis <alexis...@intel.com>
    Gerrit-Attention: Fredrik Söderquist <f...@opera.com>
    Gerrit-Comment-Date: Fri, 24 Jul 2026 09:08:28 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    5:34 AM (3 hours ago) 5:34 AM
    to Fredrik Söderquist, Rune Lillesveen, Menard, Alexis, chromium...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Remove unused fields for 'animation-trigger' and 'timeline-trigger-name'

    These properties apply to the "Animations" extra field, so these field
    definitions are not used, but still take up space. Drop the field
    definitions. Remove the dead converter ConvertTimelineTriggerName() and
    its helper.
    Change-Id: Ic0c5d5da6a9ea51b7795ce4c13ec23f65665744a
    Commit-Queue: Rune Lillesveen <fut...@chromium.org>
    Auto-Submit: Fredrik Söderquist <f...@opera.com>
    Reviewed-by: Rune Lillesveen <fut...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1667737}
    Files:
    • M third_party/blink/renderer/core/css/css_properties.json5
    • M third_party/blink/renderer/core/css/resolver/style_builder_converter.cc
    • M third_party/blink/renderer/core/css/resolver/style_builder_converter.h
    Change size: S
    Delta: 3 files changed, 0 insertions(+), 32 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Rune Lillesveen
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ic0c5d5da6a9ea51b7795ce4c13ec23f65665744a
    Gerrit-Change-Number: 8140359
    Gerrit-PatchSet: 3
    Gerrit-Owner: Fredrik Söderquist <f...@opera.com>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>
    Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages