Remove strip_debug_info from Android CI bots that run tests [chromium/src : main]

0 views
Skip to first unread message

Andrew Grieve (Gerrit)

unread,
Apr 20, 2026, 8:39:42 PM (10 days ago) Apr 20
to Andrew Grieve, Ben Pastene, Haiyang Pan, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Ben Pastene and Haiyang Pan

Andrew Grieve added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Andrew Grieve . resolved

Left it on for the compile-only bots (best as I could tell at least)

Open in Gerrit

Related details

Attention is currently required from:
  • Ben Pastene
  • Haiyang Pan
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I759b5535c04a46ca03581fd6d453e805e7f36e82
Gerrit-Change-Number: 7780134
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Grieve <agr...@chromium.org>
Gerrit-Reviewer: Andrew Grieve <agr...@chromium.org>
Gerrit-Reviewer: Ben Pastene <bpas...@chromium.org>
Gerrit-Reviewer: Haiyang Pan <hy...@google.com>
Gerrit-Attention: Ben Pastene <bpas...@chromium.org>
Gerrit-Attention: Haiyang Pan <hy...@google.com>
Gerrit-Comment-Date: Tue, 21 Apr 2026 00:39:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Ben Pastene (Gerrit)

unread,
Apr 20, 2026, 9:08:03 PM (10 days ago) Apr 20
to Andrew Grieve, Junji Watanabe, Haiyang Pan, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Andrew Grieve and Haiyang Pan

Ben Pastene added 1 comment

Patchset-level comments
Ben Pastene . unresolved

Same concern as the other CL: does this GN arg have any expected impact on compile/link times? I'm unfamiliar with the arg, but I imagine it would lead to smaller binaries -> faster links?

Open in Gerrit

Related details

Attention is currently required from:
  • Andrew Grieve
  • Haiyang Pan
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I759b5535c04a46ca03581fd6d453e805e7f36e82
    Gerrit-Change-Number: 7780134
    Gerrit-PatchSet: 1
    Gerrit-Owner: Andrew Grieve <agr...@chromium.org>
    Gerrit-Reviewer: Andrew Grieve <agr...@chromium.org>
    Gerrit-Reviewer: Ben Pastene <bpas...@chromium.org>
    Gerrit-Reviewer: Haiyang Pan <hy...@google.com>
    Gerrit-CC: Junji Watanabe <jw...@google.com>
    Gerrit-Attention: Andrew Grieve <agr...@chromium.org>
    Gerrit-Attention: Haiyang Pan <hy...@google.com>
    Gerrit-Comment-Date: Tue, 21 Apr 2026 01:07:52 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Andrew Grieve (Gerrit)

    unread,
    Apr 20, 2026, 9:17:56 PM (10 days ago) Apr 20
    to Andrew Grieve, Junji Watanabe, Ben Pastene, Haiyang Pan, Chromium LUCI CQ, chromium...@chromium.org
    Attention needed from Andrew Grieve and Haiyang Pan

    Andrew Grieve added 1 comment

    Patchset-level comments
    Andrew Grieve . resolved

    Note: this affects a bunch of trybots, but the bots already set `symbol_level=0`, which has the same effect as `strip_debug_info=true`.

    Gerrit-Comment-Date: Tue, 21 Apr 2026 01:17:49 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages