git cl upload: add --all alias for --dependencies [chromium/tools/depot_tools : main]
Thiago Perrotta (Gerrit)
Attention is currently required from: Aravind Vasudevan.
Patch set 1:Commit-Queue +1
1 comment:
Patchset:
Pingback: http://yaqs/2010731889295360000
To view, visit change 4059206. To unsubscribe, or for help writing mail filters, visit settings.
Aravind Vasudevan (Gerrit)
Attention is currently required from: Thiago Perrotta.
1 comment:
File git_cl.py:
Patch Set #1, Line 1626:
if '--all' in orig_args:Why remove `--all`? optparse combines both the flag when provided through `add_option`.
Eg:
```
➜ ~ python3
Python 3.9.6 (default, Sep 26 2022, 11:37:49)
[Clang 14.0.0 (clang-1400.0.29.202)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import optparse
>>> parser = optparse.OptionParser()
>>> parser.add_option('--dependencies', '--all', action='store_true')
<Option at 0x100ba00a0: --dependencies/--all>
>>>
>>> parser.parse_args([])
(<Values at 0x100b85fa0: {'dependencies': None}>, [])
>>> parser.parse_args(['--dependencies'])
(<Values at 0x100c4a370: {'dependencies': True}>, [])
>>> parser.parse_args(['--all'])
(<Values at 0x100ba08b0: {'dependencies': True}>, [])
```
To view, visit change 4059206. To unsubscribe, or for help writing mail filters, visit settings.
Thiago Perrotta (Gerrit)
Attention is currently required from: Aravind Vasudevan.
Patch set 1:Auto-Submit +1Commit-Queue +1
1 comment:
File git_cl.py:
Patch Set #1, Line 1626:
if '--all' in orig_args:
Why remove `--all`? optparse combines both the flag when provided through `add_option`. […]
Good catch, thanks. Done.
To view, visit change 4059206. To unsubscribe, or for help writing mail filters, visit settings.
Aravind Vasudevan (Gerrit)
Attention is currently required from: Thiago Perrotta.
1 comment:
File git_cl.py:
Patch Set #2, Line 1624:
if '--dependencies' in orig_args:Is there a reason for adding this check. I'm assuming `orig_args.remove('--dependencies')` would be a noop if `--dependencies` don't exist.
To view, visit change 4059206. To unsubscribe, or for help writing mail filters, visit settings.
Thiago Perrotta (Gerrit)
Attention is currently required from: Aravind Vasudevan.
Patch set 2:Auto-Submit +1Commit-Queue +1
1 comment:
File git_cl.py:
Patch Set #2, Line 1624:
if '--dependencies' in orig_args:
Is there a reason for adding this check. I'm assuming `orig_args. […]
Removed.
To view, visit change 4059206. To unsubscribe, or for help writing mail filters, visit settings.
Joanna Wang (Gerrit)
Attention is currently required from: Joanna Wang.
1 comment:
Patchset:
iiuc '--all' in hg upload has a different behavior (uploads all CLs in the chain?).
If we were to add '--all' i think we'd want to have it behave similarly (called in any branch and upload all CLs in the stack not just the dependencies rather than just being an alias of --dependencies).
We're also in the early stages of improving the stacked changes experience. I think we'd prefer holding off on this until we have a clearer idea of how we want to make the experience better. We don't want to add args and then remove them or change their behavior later on.
To view, visit change 4059206. To unsubscribe, or for help writing mail filters, visit settings.
Thiago Perrotta (Gerrit)
Attention is currently required from: Joanna Wang.
Patch set 3:Auto-Submit +1
1 comment:
Patchset:
iiuc '--all' in hg upload has a different behavior (uploads all CLs in the chain?). […]
Sounds good, will abandon this then.
To view, visit change 4059206. To unsubscribe, or for help writing mail filters, visit settings.
Thiago Perrotta (Gerrit)
Thiago Perrotta abandoned this change.
To view, visit change 4059206. To unsubscribe, or for help writing mail filters, visit settings.