Do IWYU for base/functional/callback.h in various files [chromium/src : main]
0 views
Skip to first unread message
Lei Zhang (Gerrit)
Dec 5, 2025, 4:09:51 PM (11 hours ago) Dec 5
to Lei Zhang, Daniel Cheng, chromium...@chromium.org, Kentaro Hara, (Julie)Jeongeun Kim, Raphael Kubo da Costa, Mike Taylor, Permissions Reviews, prerendering-reviews, Victor Tan, Chromium LUCI CQ, abigailbk...@google.com, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, chromeos-kio...@google.com, chromium-a...@chromium.org, crost...@chromium.org, dewitt...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, extension...@chromium.org, francisjp...@google.com, gavin...@chromium.org, jbroma...@chromium.org, josiah...@chromium.org, kinuko+...@chromium.org, kinuko...@chromium.org, kyungjunle...@google.com, lens-chrome...@google.com, mercer...@google.com, mpdento...@chromium.org, msrame...@chromium.org, nektar...@chromium.org, oshima...@chromium.org, performance-m...@chromium.org, rsesek...@chromium.org, stanfie...@google.com, storage...@chromium.org, tburkar...@chromium.org, yuzo+...@chromium.org
Attention needed from Daniel Cheng
Lei Zhang added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Daniel Cheng
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Daniel Cheng (Gerrit)
Dec 5, 2025, 4:12:38 PM (11 hours ago) Dec 5
to Lei Zhang, Daniel Cheng, chromium...@chromium.org, Kentaro Hara, (Julie)Jeongeun Kim, Raphael Kubo da Costa, Mike Taylor, Permissions Reviews, prerendering-reviews, Victor Tan, Chromium LUCI CQ, abigailbk...@google.com, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, chromeos-kio...@google.com, chromium-a...@chromium.org, crost...@chromium.org, dewitt...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, extension...@chromium.org, francisjp...@google.com, gavin...@chromium.org, jbroma...@chromium.org, josiah...@chromium.org, kinuko+...@chromium.org, kinuko...@chromium.org, kyungjunle...@google.com, lens-chrome...@google.com, mercer...@google.com, mpdento...@chromium.org, msrame...@chromium.org, nektar...@chromium.org, oshima...@chromium.org, performance-m...@chromium.org, rsesek...@chromium.org, stanfie...@google.com, storage...@chromium.org, tburkar...@chromium.org, yuzo+...@chromium.org
Attention needed from Lei Zhang
Daniel Cheng voted![]( "Open in Gerrit")
Attention is currently required from:
- Lei Zhang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lei Zhang (Gerrit)
Dec 5, 2025, 9:35:58 PM (5 hours ago) Dec 5
to Lei Zhang, Daniel Cheng, chromium...@chromium.org, Kentaro Hara, (Julie)Jeongeun Kim, Raphael Kubo da Costa, Mike Taylor, Permissions Reviews, prerendering-reviews, Victor Tan, Chromium LUCI CQ, abigailbk...@google.com, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, chromeos-kio...@google.com, chromium-a...@chromium.org, crost...@chromium.org, dewitt...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, extension...@chromium.org, francisjp...@google.com, gavin...@chromium.org, jbroma...@chromium.org, josiah...@chromium.org, kinuko+...@chromium.org, kinuko...@chromium.org, kyungjunle...@google.com, lens-chrome...@google.com, mercer...@google.com, mpdento...@chromium.org, msrame...@chromium.org, nektar...@chromium.org, oshima...@chromium.org, performance-m...@chromium.org, rsesek...@chromium.org, stanfie...@google.com, storage...@chromium.org, tburkar...@chromium.org, yuzo+...@chromium.org
Lei Zhang voted and added 1 comment![]( "Open in Gerrit")
Votes added by Lei Zhang
| Commit-Queue | +2 |
Lei Zhang . resolved
Please OO+1.
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Dec 5, 2025, 9:39:48 PM (5 hours ago) Dec 5
to Lei Zhang, Daniel Cheng, Akihiro Ota, chromium...@chromium.org, Kentaro Hara, (Julie)Jeongeun Kim, Raphael Kubo da Costa, Mike Taylor, Permissions Reviews, prerendering-reviews, Victor Tan, abigailbk...@google.com, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, chromeos-kio...@google.com, chromium-a...@chromium.org, crost...@chromium.org, dewitt...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, extension...@chromium.org, francisjp...@google.com, gavin...@chromium.org, jbroma...@chromium.org, josiah...@chromium.org, kinuko+...@chromium.org, kinuko...@chromium.org, kyungjunle...@google.com, lens-chrome...@google.com, mercer...@google.com, mpdento...@chromium.org, msrame...@chromium.org, nektar...@chromium.org, oshima...@chromium.org, performance-m...@chromium.org, rsesek...@chromium.org, stanfie...@google.com, storage...@chromium.org, tburkar...@chromium.org, yuzo+...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
2 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
Do IWYU for base/functional/callback.h in various files
Selectively add callback.h to some files that use it. In some cases,
replace incorrect callback_forward.h usage. This is split off from an
upcoming //mojo change that breaks the build for the files in this CL.
Change-Id: I7d0c8a2792b04ba443e58cb7045242f4dd69e50e
Owners-Override: Daniel Cheng <dch...@chromium.org>
Commit-Queue: Lei Zhang <the...@chromium.org>
Reviewed-by: Daniel Cheng <dch...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1555037}
Files:
- M ash/public/cpp/test/mock_input_device_settings_controller.h
- M chrome/browser/ash/app_mode/crash_recovery_launcher.h
- M chrome/browser/ash/guest_os/vm_sk_forwarding_native_message_host.h
- M chrome/browser/chromeos/app_mode/kiosk_app_level_logs_saver.h
- M chrome/browser/extensions/external_provider_manager.h
- M chrome/browser/glic/service/glic_tab_creation_observer.h
- M chrome/browser/performance_manager/policies/background_tab_loading_policy.h
- M chrome/browser/performance_manager/policies/discard_eligibility_policy.h
- M chrome/browser/permissions/system/mock_platform_handle.h
- M chrome/browser/permissions/system/system_permission_settings_default.cc
- M chrome/browser/privacy_sandbox/notice/notice_model.cc
- M chrome/browser/privacy_sandbox/notice/notice_model.h
- M chrome/browser/ui/lens/lens_overlay_image_helper.cc
- M chrome/browser/ui/lens/lens_overlay_image_helper_unittest.cc
- M chrome/common/extensions/chrome_extensions_client_unittest.cc
- M chrome/enterprise_companion/proxy_config_service.cc
- M components/browser_ui/site_settings/android/website_preference_bridge_util.h
- M components/client_hints/browser/in_memory_client_hints_controller_delegate.h
- M components/content_settings/core/browser/user_modifiable_provider.cc
- M components/performance_manager/graph/tracing_observer.h
- M components/performance_manager/test_support/test_harness_helper.h
- M components/permissions/test/mock_permission_ui_selector.cc
- M content/browser/fenced_frame/fenced_document_data.cc
- M content/browser/fenced_frame/fenced_document_data.h
- M content/browser/preloading/prefetch/no_vary_search_helper.h
- M content/zygote/zygote_main_linux.cc
- M extensions/common/command.cc
- M extensions/common/extensions_client.h
- M extensions/common/features/complex_feature.cc
- M extensions/common/features/feature_provider.cc
- M extensions/common/features/simple_feature.h
- M extensions/common/user_scripts_availability.cc
- M gpu/command_buffer/service/shared_image/shared_image_representation.h
- M mojo/public/cpp/bindings/lib/message.cc
- M mojo/public/cpp/bindings/lib/message_internal.h
- M sandbox/policy/linux/sandbox_linux.cc
- M sandbox/policy/sandbox.cc
- M services/device/geolocation/location_api_adapter_android.h
- M storage/browser/file_system/external_mount_points.cc
- M third_party/blink/common/thread_safe_browser_interface_broker_proxy.cc
- M third_party/blink/renderer/bindings/core/v8/serialization/serialized_script_value.h
- M third_party/blink/renderer/core/html/forms/html_form_element.h
- M third_party/blink/renderer/modules/filesystem/file_system_callbacks.h
- M ui/accessibility/ax_tree_manager.cc
- M ui/accessibility/platform/test_ax_platform_tree_manager_delegate.cc
- M ui/events/ash/keyboard_capability.h
Change size: M
Delta: 46 files changed, 51 insertions(+), 7 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Daniel Cheng
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages