[Extensions UI] Enable upload extension to account dialog on Android [chromium/src : main]
0 views
Skip to first unread message
Emilia Paz (Gerrit)
Jan 8, 2026, 12:07:46 PM (3 days ago) Jan 8
to Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Emilia Paz abandoned this change![]( "Open in Gerrit")
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Emilia Paz (Gerrit)
Jan 9, 2026, 11:48:58 AM (2 days ago) Jan 9
to Eva Su, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Eva Su
Emilia Paz voted and added 1 comment![]( "Open in Gerrit")
Votes added by Emilia Paz
| Auto-Submit | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Eva Su
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Eva Su (Gerrit)
Jan 9, 2026, 7:01:07 PM (2 days ago) Jan 9
to Emilia Paz, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Emilia Paz
Eva Su voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Emilia Paz
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Eva Su (Gerrit)
Jan 9, 2026, 7:02:01 PM (2 days ago) Jan 9
to Emilia Paz, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Emilia Paz
Eva Su added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Eva Su . resolved
LGTM! Did you test to see if the dialog shows up on Android? Not triggering autosubmit as there seems to be a merge conflict.
Related details
Attention is currently required from:
- Emilia Paz
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Emilia Paz (Gerrit)
Jan 10, 2026, 5:29:35 PM (24 hours ago) Jan 10
to Eva Su, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Emilia Paz voted and added 2 comments![]( "Open in Gerrit")
Votes added by Emilia Paz
| Auto-Submit | +1 |
| Commit-Queue | +2 |
Eva Su . resolved
LGTM! Did you test to see if the dialog shows up on Android? Not triggering autosubmit as there seems to be a merge conflict.
Emilia Paz
I was only able to trigger it on a test, but wasn't interactive. I hope it will be easier to see on an actual AL device, which can do next week. Landing for now
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jan 10, 2026, 6:58:39 PM (22 hours ago) Jan 10
to Emilia Paz, Eva Su, AyeAye, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
5 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
[Extensions UI] Enable upload extension to account dialog on Android
Enable 'upload extension to account' dialog by showing it using the
dialog util method supported by all platforms.
Fixed: 424013333
Bypass-Check-License: moved file
Change-Id: I2da1364c563ca4da494dddaa4561acdc48026eaf
Commit-Queue: Emilia Paz <emil...@chromium.org>
Reviewed-by: Eva Su <ev...@chromium.org>
Auto-Submit: Emilia Paz <emil...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1567451}
Files:
- M chrome/browser/extensions/api/developer_private/developer_private_functions.cc
- M chrome/browser/ui/BUILD.gn
- M chrome/browser/ui/extensions/BUILD.gn
- M chrome/browser/ui/extensions/extensions_dialogs.h
- A chrome/browser/ui/extensions/upload_extension_to_account_dialog.cc
- R chrome/browser/ui/extensions/upload_extension_to_account_dialog_browsertest.cc
- D chrome/browser/ui/views/extensions/dialogs/upload_extension_to_account_dialog.cc
- M chrome/test/BUILD.gn
Change size: M
Delta: 8 files changed, 86 insertions(+), 85 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Eva Su
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages