prerender: Add manifest v3 tests for prerendering content script. [chromium/src : main]
Huanpo Lin (Gerrit)
Attention is currently required from: Devlin Cronin, Takashi Toyoshima.
Patch set 4:Commit-Queue +1
To view, visit change 3804051. To unsubscribe, or for help writing mail filters, visit settings.
Takashi Toyoshima (Gerrit)
Attention is currently required from: Devlin Cronin, Huanpo Lin.
Patch set 5:Code-Review +1
2 comments:
Patchset:
thanks!
lgtm though this may have a similar flakiness as v2 test did.
at this moment, I'm focusing on fixing a crash bug and will revisit it to re-enable the test after that bug fix. it's great if you can also investigate the root of the flakiness!
File chrome/test/data/extensions/api_test/content_scripts/prerendering/test.js:
// TODO(https://crbug.com/3731231): Add more tests for
// `match_origin_as_fallback`.I think now this TODO can be removed as `match_origin_as_fallback` is v3 only feature. So, having a TODO in the v3 test is enough.
To view, visit change 3804051. To unsubscribe, or for help writing mail filters, visit settings.
Devlin Cronin (Gerrit)
Attention is currently required from: Huanpo Lin, Takashi Toyoshima.
Patch set 11:Code-Review +1
2 comments:
Patchset:
Thanks! LGTM
File chrome/test/data/extensions/api_test/content_scripts/prerendering/test.js:
// TODO(https://crbug.com/3731231): Add more tests for
// `match_origin_as_fallback`.
I think now this TODO can be removed as `match_origin_as_fallback` is v3 only feature. […]
+1
To view, visit change 3804051. To unsubscribe, or for help writing mail filters, visit settings.
Huanpo Lin (Gerrit)
Attention is currently required from: Takashi Toyoshima.
1 comment:
File chrome/test/data/extensions/api_test/content_scripts/prerendering/test.js:
// TODO(https://crbug.com/3731231): Add more tests for
// `match_origin_as_fallback`.
+1
Done
To view, visit change 3804051. To unsubscribe, or for help writing mail filters, visit settings.
Huanpo Lin (Gerrit)
Attention is currently required from: Takashi Toyoshima.
Patch set 16:Commit-Queue +2
Takashi Toyoshima (Gerrit)
Attention is currently required from: Huanpo Lin.
Patch set 16:Code-Review +1
1 comment:
Patchset:
Robert, this is ready for commit, isn't it?
To view, visit change 3804051. To unsubscribe, or for help writing mail filters, visit settings.
Takashi Toyoshima (Gerrit)
Attention is currently required from: Huanpo Lin.
1 comment:
Patchset:
Robert, this is ready for commit, isn't it?
Ah, sorry, please ignore my previous comment. It's already in CQ+2.
To view, visit change 3804051. To unsubscribe, or for help writing mail filters, visit settings.
Huanpo Lin (Gerrit)
Attention is currently required from: Huanpo Lin.
Patch set 16:Commit-Queue +2
To view, visit change 3804051. To unsubscribe, or for help writing mail filters, visit settings.
Huanpo Lin (Gerrit)
Attention is currently required from: Huanpo Lin.
Patch set 17:Commit-Queue +2
Chromium LUCI CQ (Gerrit)
Chromium LUCI CQ submitted this change.
16 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
prerender: Add manifest v3 tests for prerendering content script.
This CL add prerendering content script tests in manifest v3 to ensure
the tests run in v3 as well.
link to the v2 commits I9f15424e35529d800f7fee836fe7bd4d101a1b05
Iab51dca0c6bab738f1083ccb40987df84ee44736
Bug: 1278141
Change-Id: Iabcd4988705b3a78823f1a0fe440b42ac3a5a333
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3804051
Commit-Queue: Huanpo Lin <robe...@chromium.org>
Reviewed-by: Devlin Cronin <rdevlin...@chromium.org>
Reviewed-by: Takashi Toyoshima <toyo...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1032914}
---
M chrome/browser/extensions/content_script_apitest.cc
M chrome/test/data/extensions/api_test/content_scripts/prerendering/test.js
A chrome/test/data/extensions/api_test/content_scripts/prerendering_mv3/all_frames.js
A chrome/test/data/extensions/api_test/content_scripts/prerendering_mv3/manifest.json
A chrome/test/data/extensions/api_test/content_scripts/prerendering_mv3/test.js
A chrome/test/data/extensions/api_test/content_scripts/prerendering_mv3/top_frame_only.js
6 files changed, 259 insertions(+), 2 deletions(-)
Greg Thompson (Gerrit)
Greg Thompson has created a revert of this change.
To view, visit change 3804051. To unsubscribe, or for help writing mail filters, visit settings.