Remove dependency on ProfileManager from ash::AccessibilityManager [chromium/src : main]

0 views
Skip to first unread message

Jun Ishiguro (Gerrit)

unread,
Jan 13, 2026, 4:48:40 AM (yesterday) Jan 13
to Hidehiko Abe, Chromium LUCI CQ, chromium...@chromium.org, (Julie)Jeongeun Kim, abigailbk...@google.com, dtseng...@chromium.org, francisjp...@google.com, hirokisa...@chromium.org, josiah...@chromium.org, katie...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, yuzo+...@chromium.org
Attention needed from Hidehiko Abe

Jun Ishiguro added 1 comment

Patchset-level comments
File-level comment, Patchset 3 (Latest):
Jun Ishiguro . resolved

PTAL

Open in Gerrit

Related details

Attention is currently required from:
  • Hidehiko Abe
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I373cbf85eddb445f8b18976750cab093af074151
Gerrit-Change-Number: 7461988
Gerrit-PatchSet: 3
Gerrit-Owner: Jun Ishiguro <ju...@google.com>
Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>
Gerrit-Reviewer: Jun Ishiguro <ju...@google.com>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-Attention: Hidehiko Abe <hide...@chromium.org>
Gerrit-Comment-Date: Tue, 13 Jan 2026 09:48:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Hidehiko Abe (Gerrit)

unread,
Jan 13, 2026, 6:45:50 AM (22 hours ago) Jan 13
to Jun Ishiguro, Chromium LUCI CQ, chromium...@chromium.org, (Julie)Jeongeun Kim, abigailbk...@google.com, dtseng...@chromium.org, francisjp...@google.com, hirokisa...@chromium.org, josiah...@chromium.org, katie...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, yuzo+...@chromium.org
Attention needed from Jun Ishiguro

Hidehiko Abe added 3 comments

File chrome/browser/ash/accessibility/accessibility_manager.cc
Line 652, Patchset 3 (Latest):
auto is_any_a11y_feature_enabled = [](PrefService* prefs) -> bool {
return prefs->GetBoolean(prefs::kAccessibilityStickyKeysEnabled) ||
prefs->GetBoolean(prefs::kAccessibilityLargeCursorEnabled) ||
prefs->GetBoolean(::prefs::kLiveCaptionEnabled) ||
prefs->GetBoolean(prefs::kAccessibilitySpokenFeedbackEnabled) ||
prefs->GetBoolean(prefs::kAccessibilitySelectToSpeakEnabled) ||
prefs->GetBoolean(prefs::kAccessibilitySwitchAccessEnabled) ||
prefs->GetBoolean(prefs::kAccessibilityHighContrastEnabled) ||
prefs->GetBoolean(prefs::kAccessibilityAutoclickEnabled) ||
prefs->GetBoolean(prefs::kShouldAlwaysShowAccessibilityMenu) ||
prefs->GetBoolean(prefs::kAccessibilityScreenMagnifierEnabled) ||
prefs->GetBoolean(prefs::kAccessibilityVirtualKeyboardEnabled) ||
prefs->GetBoolean(prefs::kAccessibilityMonoAudioEnabled) ||
prefs->GetBoolean(prefs::kAccessibilityCaretHighlightEnabled) ||
prefs->GetBoolean(prefs::kAccessibilityCursorHighlightEnabled) ||
prefs->GetBoolean(prefs::kAccessibilityFocusHighlightEnabled) ||
prefs->GetBoolean(prefs::kAccessibilityDictationEnabled) ||
prefs->GetBoolean(prefs::kDockedMagnifierEnabled) ||
prefs->GetBoolean(prefs::kAccessibilityColorCorrectionEnabled) ||
prefs->GetBoolean(prefs::kAccessibilityBounceKeysEnabled) ||
prefs->GetBoolean(prefs::kAccessibilitySlowKeysEnabled);
};
Hidehiko Abe . unresolved

nit/style: nice to make a standalone function.

Line 676, Patchset 3 (Latest): Profile* signin_profile = Profile::FromBrowserContext(
Hidehiko Abe . unresolved
Line 679, Patchset 3 (Latest): if (is_any_a11y_feature_enabled(signin_profile->GetPrefs())) {
Hidehiko Abe . unresolved
Open in Gerrit

Related details

Attention is currently required from:
  • Jun Ishiguro
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I373cbf85eddb445f8b18976750cab093af074151
    Gerrit-Change-Number: 7461988
    Gerrit-PatchSet: 3
    Gerrit-Owner: Jun Ishiguro <ju...@google.com>
    Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>
    Gerrit-Reviewer: Jun Ishiguro <ju...@google.com>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    Gerrit-Attention: Jun Ishiguro <ju...@google.com>
    Gerrit-Comment-Date: Tue, 13 Jan 2026 11:45:16 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Jun Ishiguro (Gerrit)

    unread,
    12:29 AM (4 hours ago) 12:29 AM
    to Hidehiko Abe, Chromium LUCI CQ, chromium...@chromium.org, (Julie)Jeongeun Kim, abigailbk...@google.com, dtseng...@chromium.org, francisjp...@google.com, hirokisa...@chromium.org, josiah...@chromium.org, katie...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, yuzo+...@chromium.org
    Attention needed from Hidehiko Abe

    Jun Ishiguro added 3 comments

    File chrome/browser/ash/accessibility/accessibility_manager.cc

    auto is_any_a11y_feature_enabled = [](PrefService* prefs) -> bool {
    return prefs->GetBoolean(prefs::kAccessibilityStickyKeysEnabled) ||
    prefs->GetBoolean(prefs::kAccessibilityLargeCursorEnabled) ||
    prefs->GetBoolean(::prefs::kLiveCaptionEnabled) ||
    prefs->GetBoolean(prefs::kAccessibilitySpokenFeedbackEnabled) ||
    prefs->GetBoolean(prefs::kAccessibilitySelectToSpeakEnabled) ||
    prefs->GetBoolean(prefs::kAccessibilitySwitchAccessEnabled) ||
    prefs->GetBoolean(prefs::kAccessibilityHighContrastEnabled) ||
    prefs->GetBoolean(prefs::kAccessibilityAutoclickEnabled) ||
    prefs->GetBoolean(prefs::kShouldAlwaysShowAccessibilityMenu) ||
    prefs->GetBoolean(prefs::kAccessibilityScreenMagnifierEnabled) ||
    prefs->GetBoolean(prefs::kAccessibilityVirtualKeyboardEnabled) ||
    prefs->GetBoolean(prefs::kAccessibilityMonoAudioEnabled) ||
    prefs->GetBoolean(prefs::kAccessibilityCaretHighlightEnabled) ||
    prefs->GetBoolean(prefs::kAccessibilityCursorHighlightEnabled) ||
    prefs->GetBoolean(prefs::kAccessibilityFocusHighlightEnabled) ||
    prefs->GetBoolean(prefs::kAccessibilityDictationEnabled) ||
    prefs->GetBoolean(prefs::kDockedMagnifierEnabled) ||
    prefs->GetBoolean(prefs::kAccessibilityColorCorrectionEnabled) ||
    prefs->GetBoolean(prefs::kAccessibilityBounceKeysEnabled) ||
    prefs->GetBoolean(prefs::kAccessibilitySlowKeysEnabled);
    };
    Hidehiko Abe . resolved

    nit/style: nice to make a standalone function.

    Jun Ishiguro

    Done

    Line 676, Patchset 3: Profile* signin_profile = Profile::FromBrowserContext(
    Hidehiko Abe . resolved
    Jun Ishiguro

    Thank you for the suggestion. I didn't know this API. Done.

    Line 679, Patchset 3: if (is_any_a11y_feature_enabled(signin_profile->GetPrefs())) {
    Hidehiko Abe . unresolved

    Could you check if we do not need to handle other special profiles in ChromeOS system?
    https://source.chromium.org/chromium/chromium/src/+/main:chromeos/ash/components/browser_context_helper/browser_context_types.h;l=38

    Jun Ishiguro

    I confirmed that lock-screen browser context is not needed for this case.

    For shimless-rma, I think we can also ignore it unless `AccessibilityController::OnActiveUserPrefServiceChanged` is called with its prefs. Also, I manually confirmed that shelf and the quick settings are not displayed for Shimless RMA mode.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Hidehiko Abe
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I373cbf85eddb445f8b18976750cab093af074151
    Gerrit-Change-Number: 7461988
    Gerrit-PatchSet: 4
    Gerrit-Owner: Jun Ishiguro <ju...@google.com>
    Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>
    Gerrit-Reviewer: Jun Ishiguro <ju...@google.com>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    Gerrit-Attention: Hidehiko Abe <hide...@chromium.org>
    Gerrit-Comment-Date: Wed, 14 Jan 2026 05:29:32 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Hidehiko Abe <hide...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Hidehiko Abe (Gerrit)

    unread,
    12:54 AM (4 hours ago) 12:54 AM
    to Jun Ishiguro, Chromium LUCI CQ, chromium...@chromium.org, (Julie)Jeongeun Kim, abigailbk...@google.com, dtseng...@chromium.org, francisjp...@google.com, hirokisa...@chromium.org, josiah...@chromium.org, katie...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, yuzo+...@chromium.org
    Attention needed from Jun Ishiguro

    Hidehiko Abe voted and added 3 comments

    Votes added by Hidehiko Abe

    Code-Review+1

    3 comments

    Patchset-level comments
    File-level comment, Patchset 4 (Latest):
    Hidehiko Abe . resolved

    lgtm

    File chrome/browser/ash/accessibility/accessibility_manager.cc
    Line 379, Patchset 4 (Latest):bool IsAnyAccessibilityFeatureEnabled(PrefService* prefs) {
    Hidehiko Abe . unresolved

    Nit/optional: `PrefService& prefs` if this cannot be nullptr? (So CHECK_DEREF in the caller).

    Line 679, Patchset 3: if (is_any_a11y_feature_enabled(signin_profile->GetPrefs())) {
    Hidehiko Abe . resolved

    Could you check if we do not need to handle other special profiles in ChromeOS system?
    https://source.chromium.org/chromium/chromium/src/+/main:chromeos/ash/components/browser_context_helper/browser_context_types.h;l=38

    Jun Ishiguro

    I confirmed that lock-screen browser context is not needed for this case.

    For shimless-rma, I think we can also ignore it unless `AccessibilityController::OnActiveUserPrefServiceChanged` is called with its prefs. Also, I manually confirmed that shelf and the quick settings are not displayed for Shimless RMA mode.

    Hidehiko Abe

    Acknowledged

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Jun Ishiguro
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I373cbf85eddb445f8b18976750cab093af074151
    Gerrit-Change-Number: 7461988
    Gerrit-PatchSet: 4
    Gerrit-Owner: Jun Ishiguro <ju...@google.com>
    Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>
    Gerrit-Reviewer: Jun Ishiguro <ju...@google.com>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    Gerrit-Attention: Jun Ishiguro <ju...@google.com>
    Gerrit-Comment-Date: Wed, 14 Jan 2026 05:53:34 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    Comment-In-Reply-To: Jun Ishiguro <ju...@google.com>
    Comment-In-Reply-To: Hidehiko Abe <hide...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Jun Ishiguro (Gerrit)

    unread,
    1:04 AM (4 hours ago) 1:04 AM
    to Hidehiko Abe, Chromium LUCI CQ, chromium...@chromium.org, (Julie)Jeongeun Kim, abigailbk...@google.com, dtseng...@chromium.org, francisjp...@google.com, hirokisa...@chromium.org, josiah...@chromium.org, katie...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, yuzo+...@chromium.org

    Jun Ishiguro voted and added 2 comments

    Votes added by Jun Ishiguro

    Commit-Queue+2

    2 comments

    Patchset-level comments
    File-level comment, Patchset 6 (Latest):
    Jun Ishiguro . resolved

    Thank you for the review!

    File chrome/browser/ash/accessibility/accessibility_manager.cc
    Line 379, Patchset 4:bool IsAnyAccessibilityFeatureEnabled(PrefService* prefs) {
    Hidehiko Abe . resolved

    Nit/optional: `PrefService& prefs` if this cannot be nullptr? (So CHECK_DEREF in the caller).

    Jun Ishiguro

    Done

    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I373cbf85eddb445f8b18976750cab093af074151
      Gerrit-Change-Number: 7461988
      Gerrit-PatchSet: 6
      Gerrit-Owner: Jun Ishiguro <ju...@google.com>
      Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>
      Gerrit-Reviewer: Jun Ishiguro <ju...@google.com>
      Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
      Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
      Gerrit-Comment-Date: Wed, 14 Jan 2026 06:03:40 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      Comment-In-Reply-To: Hidehiko Abe <hide...@chromium.org>
      satisfied_requirement
      open
      diffy

      Chromium LUCI CQ (Gerrit)

      unread,
      1:34 AM (3 hours ago) 1:34 AM
      to Jun Ishiguro, Hidehiko Abe, Akihiro Ota, chromium...@chromium.org, (Julie)Jeongeun Kim, abigailbk...@google.com, dtseng...@chromium.org, francisjp...@google.com, hirokisa...@chromium.org, josiah...@chromium.org, katie...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, yuzo+...@chromium.org

      Chromium LUCI CQ submitted the change with unreviewed changes

      Unreviewed changes

      4 is the latest approved patch-set.
      The change was submitted with unreviewed changes in the following files:

      ```
      The name of the file: chrome/browser/ash/accessibility/accessibility_manager.cc
      Insertions: 25, Deletions: 25.

      @@ -376,28 +376,27 @@
         return data;
       }
       
      -bool IsAnyAccessibilityFeatureEnabled(PrefService* prefs) {
      -  CHECK(prefs);
      -  return prefs->GetBoolean(prefs::kAccessibilityStickyKeysEnabled) ||
      -         prefs->GetBoolean(prefs::kAccessibilityLargeCursorEnabled) ||
      -         prefs->GetBoolean(::prefs::kLiveCaptionEnabled) ||
      -         prefs->GetBoolean(prefs::kAccessibilitySpokenFeedbackEnabled) ||
      -         prefs->GetBoolean(prefs::kAccessibilitySelectToSpeakEnabled) ||
      -         prefs->GetBoolean(prefs::kAccessibilitySwitchAccessEnabled) ||
      -         prefs->GetBoolean(prefs::kAccessibilityHighContrastEnabled) ||
      -         prefs->GetBoolean(prefs::kAccessibilityAutoclickEnabled) ||
      -         prefs->GetBoolean(prefs::kShouldAlwaysShowAccessibilityMenu) ||
      -         prefs->GetBoolean(prefs::kAccessibilityScreenMagnifierEnabled) ||
      -         prefs->GetBoolean(prefs::kAccessibilityVirtualKeyboardEnabled) ||
      -         prefs->GetBoolean(prefs::kAccessibilityMonoAudioEnabled) ||
      -         prefs->GetBoolean(prefs::kAccessibilityCaretHighlightEnabled) ||
      -         prefs->GetBoolean(prefs::kAccessibilityCursorHighlightEnabled) ||
      -         prefs->GetBoolean(prefs::kAccessibilityFocusHighlightEnabled) ||
      -         prefs->GetBoolean(prefs::kAccessibilityDictationEnabled) ||
      -         prefs->GetBoolean(prefs::kDockedMagnifierEnabled) ||
      -         prefs->GetBoolean(prefs::kAccessibilityColorCorrectionEnabled) ||
      -         prefs->GetBoolean(prefs::kAccessibilityBounceKeysEnabled) ||
      -         prefs->GetBoolean(prefs::kAccessibilitySlowKeysEnabled);
      +bool IsAnyAccessibilityFeatureEnabled(const PrefService& prefs) {
      +  return prefs.GetBoolean(prefs::kAccessibilityStickyKeysEnabled) ||
      +         prefs.GetBoolean(prefs::kAccessibilityLargeCursorEnabled) ||
      +         prefs.GetBoolean(::prefs::kLiveCaptionEnabled) ||
      +         prefs.GetBoolean(prefs::kAccessibilitySpokenFeedbackEnabled) ||
      +         prefs.GetBoolean(prefs::kAccessibilitySelectToSpeakEnabled) ||
      +         prefs.GetBoolean(prefs::kAccessibilitySwitchAccessEnabled) ||
      +         prefs.GetBoolean(prefs::kAccessibilityHighContrastEnabled) ||
      +         prefs.GetBoolean(prefs::kAccessibilityAutoclickEnabled) ||
      +         prefs.GetBoolean(prefs::kShouldAlwaysShowAccessibilityMenu) ||
      +         prefs.GetBoolean(prefs::kAccessibilityScreenMagnifierEnabled) ||
      +         prefs.GetBoolean(prefs::kAccessibilityVirtualKeyboardEnabled) ||
      +         prefs.GetBoolean(prefs::kAccessibilityMonoAudioEnabled) ||
      +         prefs.GetBoolean(prefs::kAccessibilityCaretHighlightEnabled) ||
      +         prefs.GetBoolean(prefs::kAccessibilityCursorHighlightEnabled) ||
      +         prefs.GetBoolean(prefs::kAccessibilityFocusHighlightEnabled) ||
      +         prefs.GetBoolean(prefs::kAccessibilityDictationEnabled) ||
      +         prefs.GetBoolean(prefs::kDockedMagnifierEnabled) ||
      +         prefs.GetBoolean(prefs::kAccessibilityColorCorrectionEnabled) ||
      +         prefs.GetBoolean(prefs::kAccessibilityBounceKeysEnabled) ||
      +         prefs.GetBoolean(prefs::kAccessibilitySlowKeysEnabled);
       }
       
       }  // namespace
      @@ -675,14 +674,15 @@
         // at the login screen the menu will show even if the user has no features
         // enabled inside the session. http://crbug.com/755631
       
      -  if (IsAnyAccessibilityFeatureEnabled(user_prefs::UserPrefs::Get(
      -          BrowserContextHelper::Get()->GetSigninBrowserContext()))) {
      +  if (IsAnyAccessibilityFeatureEnabled(CHECK_DEREF(user_prefs::UserPrefs::Get(
      +          BrowserContextHelper::Get()->GetSigninBrowserContext())))) {
           return true;
         }
       
         for (const auto& user :
              user_manager::UserManager::Get()->GetLoggedInUsers()) {
      -    if (IsAnyAccessibilityFeatureEnabled(user->GetProfilePrefs())) {
      +    if (IsAnyAccessibilityFeatureEnabled(
      +            CHECK_DEREF(user->GetProfilePrefs()))) {
             return true;
           }
         }
      ```

      Change information

      Commit message:
      Remove dependency on ProfileManager from ash::AccessibilityManager

      This CL replaces a ProfileManager::GetLoadedProfiles() call with
      UserManager::GetLoggedInUsers() in
      AccessibilityManager::ShouldShowAccessibilityMenu.

      The method also depends on the sign-in profile prefs, so the new
      implementation explicitly checks both the sign-in profile prefs and all
      of signed-in users' prefs.
      Fixed: b:404128705
      Change-Id: I373cbf85eddb445f8b18976750cab093af074151
      Reviewed-by: Hidehiko Abe <hide...@chromium.org>
      Commit-Queue: Jun Ishiguro <ju...@google.com>
      Cr-Commit-Position: refs/heads/main@{#1568932}
      Files:
      • M chrome/browser/ash/accessibility/BUILD.gn
      • M chrome/browser/ash/accessibility/DEPS
      • M chrome/browser/ash/accessibility/accessibility_manager.cc
      Change size: M
      Delta: 3 files changed, 38 insertions(+), 27 deletions(-)
      Branch: refs/heads/main
      Submit Requirements:
      • requirement satisfiedCode-Review: +1 by Hidehiko Abe
      Open in Gerrit
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: merged
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I373cbf85eddb445f8b18976750cab093af074151
      Gerrit-Change-Number: 7461988
      Gerrit-PatchSet: 7
      Gerrit-Owner: Jun Ishiguro <ju...@google.com>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>
      Gerrit-Reviewer: Jun Ishiguro <ju...@google.com>
      Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
      Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
      open
      diffy
      satisfied_requirement
      Reply all
      Reply to author
      Forward
      0 new messages