Add a flag to Show download scanning UI on ddownload home [chromium/src : main]

2 views

Skip to first unread message

Min Qin (Gerrit)

unread,

Dec 23, 2025, 2:46:28 PM (3 days ago) Dec 23

to Shakti Sahu, Wenyu Fu, Chromium LUCI CQ, chromium...@chromium.org, dtraino...@chromium.org, srahim...@chromium.org

Attention needed from Shakti Sahu and Wenyu Fu

Min Qin added 1 comment

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Min Qin . resolved

PTAL

Open in Gerrit

Related details

Attention is currently required from:

Shakti Sahu
Wenyu Fu

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Wenyu Fu (Gerrit)

unread,

Dec 23, 2025, 4:17:43 PM (3 days ago) Dec 23

to Min Qin, Shakti Sahu, Chromium LUCI CQ, chromium...@chromium.org, dtraino...@chromium.org, srahim...@chromium.org

Attention needed from Min Qin and Shakti Sahu

Wenyu Fu added 2 comments

File chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/ChromeFeatureList.java

Line 160, Patchset 3 (Latest):

    public static final String ABORT_NAVIGATIONS_FROM_TAB_CLOSURES =
            "AbortNavigationsFromTabClosures";
    public static final String ACCOUNT_FOR_SUPPRESSED_KEYBOARD_INSETS =
            "AccountForSuppressedKeyboardInsets";
    public static final String ADAPTIVE_BUTTON_IN_TOP_TOOLBAR_CUSTOMIZATION_V2 =
            "AdaptiveButtonInTopToolbarCustomizationV2";
    public static final String ADAPTIVE_BUTTON_IN_TOP_TOOLBAR_PAGE_SUMMARY =
            "AdaptiveButtonInTopToolbarPageSummary";
    public static final String ANDROID_ANIMATED_PROGRESS_BAR_IN_BROWSER =
            "AndroidAnimatedProgressBarInBrowser";
    public static final String ANDROID_ANIMATED_PROGRESS_BAR_IN_VIZ =
            "AndroidAnimatedProgressBarInViz";
    public static final String ANDROID_APPEARANCE_SETTINGS = "AndroidAppearanceSettings";
    public static final String ANDROID_APP_INTEGRATION_MODULE = "AndroidAppIntegrationModule";
    public static final String ANDROID_APP_INTEGRATION_MULTI_DATA_SOURCE =
            "AndroidAppIntegrationMultiDataSource";
    public static final String ANDROID_AUTOFILL_SUPPORT_FOR_HTTP_AUTH =
            "AndroidAutofillSupportForHttpAuth";
    public static final String ANDROID_AUTO_MINTED_TWA = "AndroidAutoMintedTWA";
    public static final String ANDROID_BOOKMARK_BAR = "AndroidBookmarkBar";
    public static final String ANDROID_BOOKMARK_BAR_FAST_FOLLOW = "AndroidBookmarkBarFastFollow";
    public static final String ANDROID_BOTTOM_TOOLBAR_V2 = "AndroidBottomToolbarV2";
    public static final String ANDROID_COMPOSEPLATE = "AndroidComposeplate";
    public static final String ANDROID_COMPOSEPLATE_LFF = "AndroidComposeplateLFF";
    public static final String ANDROID_CONTEXT_MENU_DUPLICATE_TABS =
            "AndroidContextMenuDuplicateTabs";
    public static final String ANDROID_DATA_IMPORTER_SERVICE = "AndroidDataImporterService";
    public static final String ANDROID_DESKTOP_DENSITY = "AndroidDesktopDensity";
    public static final String ANDROID_ELEGANT_TEXT_HEIGHT = "AndroidElegantTextHeight";
    public static final String ANDROID_FIRST_RUN_LAUNCH_BOUNDS = "AndroidFirstRunLaunchBounds";
    public static final String ANDROID_LOGO_VIEW_REFACTOR = "AndroidLogoViewRefactor";
    public static final String ANDROID_NEW_MEDIA_PICKER = "AndroidNewMediaPicker";
    public static final String ANDROID_NO_VISIBLE_HINT_FOR_DIFFERENT_TLD =
            "AndroidNoVisibleHintForDifferentTLD";
    public static final String ANDROID_OMNIBOX_FOCUSED_NEW_TAB_PAGE =
            "AndroidOmniboxFocusedNewTabPage";
    public static final String ANDROID_OPEN_INCOGNITO_AS_WINDOW = "AndroidOpenIncognitoAsWindow";
    public static final String ANDROID_PB_DISABLE_PULSE_ANIMATION =
            "AndroidPbDisablePulseAnimation";
    public static final String ANDROID_PB_DISABLE_SMOOTH_ANIMATION =
            "AndroidPbDisableSmoothAnimation";
    public static final String ANDROID_PINNED_TABS = "AndroidPinnedTabs";
    public static final String ANDROID_PINNED_TABS_TABLET_TAB_STRIP =
            "AndroidPinnedTabsTabletTabStrip";
    public static final String ANDROID_PROGRESS_BAR_VISUAL_UPDATE =
            "AndroidProgressBarVisualUpdate";
    public static final String ANDROID_SETTINGS_CONTAINMENT = "AndroidSettingsContainment";
    public static final String ANDROID_SETUP_LIST = "AndroidSetupList";
    public static final String ANDROID_SURFACE_COLOR_UPDATE = "AndroidSurfaceColorUpdate";
    public static final String ANDROID_TAB_DECLUTTER_DEDUPE_TAB_IDS_KILL_SWITCH =
            "AndroidTabDeclutterDedupeTabIdsKillSwitch";
    public static final String ANDROID_TAB_HIGHLIGHTING = "AndroidTabHighlighting";
    public static final String ANDROID_TAB_SKIP_SAVE_TABS_TASK_KILLSWITCH =
            "AndroidTabSkipSaveTabsTaskKillswitch";
    public static final String ANDROID_THEME_MODULE = "AndroidThemeModule";
    public static final String ANDROID_THEME_RESOURCE_PROVIDER = "AndroidThemeResourceProvider";
    public static final String ANDROID_TIPS_NOTIFICATIONS = "AndroidTipsNotifications";
    public static final String ANDROID_TWA_ORIGIN_DISPLAY = "AndroidTWAOriginDisplay";
    public static final String ANDROID_USE_ADMINS_FOR_ENTERPRISE_INFO =
            "AndroidUseAdminsForEnterpriseInfo";
    public static final String ANDROID_WEB_APP_HEADER_FOR_STANDALONE_MODE =
            "AndroidWebAppHeaderForStandaloneMode";
    public static final String ANDROID_WEB_APP_LAUNCH_HANDLER = "AndroidWebAppLaunchHandler";
    public static final String ANDROID_WEB_APP_MENU_BUTTON = "AndroidWebAppMenuButton";
    public static final String ANDROID_WINDOW_CONTROLS_OVERLAY = "AndroidWindowControlsOverlay";
    public static final String ANDROID_WINDOW_MANAGEMENT_WEB_API = "AndroidWindowManagementWebApi";
    public static final String ANDROID_WINDOW_POPUP_CUSTOM_TAB_UI = "AndroidWindowPopupCustomTabUi";
    public static final String ANDROID_WINDOW_POPUP_LARGE_SCREEN = "AndroidWindowPopupLargeScreen";
    public static final String ANDROID_WINDOW_POPUP_PREDICT_FINAL_BOUNDS =
            "AndroidWindowPopupPredictFinalBounds";
    public static final String ANDROID_WINDOW_POPUP_RESIZE_AFTER_SPAWN =
            "AndroidWindowPopupResizeAfterSpawn";
    public static final String ANDROID_XR_USES_SURFACE_CONTROL = "AndroidXRUsesSurfaceControl";
    public static final String ANIMATED_GIF_REFACTOR = "AnimatedGifRefactor";
    public static final String ANIMATED_IMAGE_DRAG_SHADOW = "AnimatedImageDragShadow";
    public static final String ANNOTATED_PAGE_CONTENTS_VIRTUAL_STRUCTURE =
            "AnnotatedPageContentsVirtualStructure";
    public static final String APP_SPECIFIC_HISTORY = "AppSpecificHistory";
    public static final String APP_SPECIFIC_HISTORY_VIEW_INTENT = "AppSpecificHistoryViewIntent";
    public static final String ASYNC_NOTIFICATION_MANAGER = "AsyncNotificationManager";
    public static final String ASYNC_NOTIFICATION_MANAGER_FOR_DOWNLOAD =
            "AsyncNotificationManagerForDownload";
    public static final String AUTOFILL_ALLOW_NON_HTTP_ACTIVATION =
            "AutofillAllowNonHttpActivation";
    public static final String AUTOFILL_ANDROID_DESKTOP_KEYBOARD_ACCESSORY_REVAMP =
            "AutofillAndroidDesktopKeyboardAccessoryRevamp";
    public static final String AUTOFILL_ANDROID_DESKTOP_SUPPRESS_ACCESSORY_ON_EMPTY =
            "AutofillAndroidDesktopSuppressAccessoryOnEmpty";
    public static final String AUTOFILL_ANDROID_KEYBOARD_ACCESSORY_DYNAMIC_POSITIONING =
            "AutofillAndroidKeyboardAccessoryDynamicPositioning";
    public static final String AUTOFILL_DEEP_LINK_AUTOFILL_OPTIONS =
            "AutofillDeepLinkAutofillOptions";
    public static final String AUTOFILL_ENABLE_BUY_NOW_PAY_LATER = "AutofillEnableBuyNowPayLater";
    public static final String AUTOFILL_ENABLE_CARD_BENEFITS_FOR_AMERICAN_EXPRESS =
            "AutofillEnableCardBenefitsForAmericanExpress";
    public static final String AUTOFILL_ENABLE_CARD_BENEFITS_FOR_BMO =
            "AutofillEnableCardBenefitsForBmo";
    public static final String AUTOFILL_ENABLE_CVC_STORAGE = "AutofillEnableCvcStorageAndFilling";
    public static final String AUTOFILL_ENABLE_FLAT_RATE_CARD_BENEFITS_FROM_CURINOS =
            "AutofillEnableFlatRateCardBenefitsFromCurinos";
    public static final String AUTOFILL_ENABLE_KEYBOARD_ACCESSORY_CHIP_REDESIGN =
            "AutofillEnableKeyboardAccessoryChipRedesign";
    public static final String AUTOFILL_ENABLE_KEYBOARD_ACCESSORY_CHIP_WIDTH_ADJUSTMENT =
            "AutofillEnableKeyboardAccessoryChipWidthAdjustment";
    public static final String AUTOFILL_ENABLE_LOCAL_IBAN = "AutofillEnableLocalIban";
    public static final String AUTOFILL_ENABLE_LOYALTY_CARDS_FILLING =
            "AutofillEnableLoyaltyCardsFilling";
    public static final String AUTOFILL_ENABLE_NEW_CARD_BENEFITS_TOGGLE_TEXT =
            "AutofillEnableNewCardBenefitsToggleText";
    public static final String AUTOFILL_ENABLE_NEW_FOP_DISPLAY_ANDROID =
            "AutofillEnableNewFopDisplayAndroid";
    public static final String AUTOFILL_ENABLE_SECURITY_TOUCH_EVENT_FILTERING_ANDROID =
            "AutofillEnableSecurityTouchEventFilteringAndroid";
    public static final String AUTOFILL_ENABLE_SEPARATE_PIX_PREFERENCE_ITEM =
            "AutofillEnableSeparatePixPreferenceItem";
    public static final String AUTOFILL_ENABLE_SERVER_IBAN = "AutofillEnableServerIban";
    public static final String AUTOFILL_ENABLE_SUPPORT_FOR_HOME_AND_WORK =
            "AutofillEnableSupportForHomeAndWork";
    public static final String AUTOFILL_RETRY_IMAGE_FETCH_ON_FAILURE =
            "AutofillRetryImageFetchOnFailure";
    public static final String AUTOFILL_SYNC_EWALLET_ACCOUNTS = "AutofillSyncEwalletAccounts";
    public static final String AUTOFILL_THIRD_PARTY_MODE_CONTENT_PROVIDER =
            "AutofillThirdPartyModeContentProvider";
    public static final String AUTOMOTIVE_BACK_BUTTON_BAR_STREAMLINE =
            "AutomotiveBackButtonBarStreamline";
    public static final String AUTO_DOC_PIP_PERMISSION_PROMPT_ANDROID =
            "AutoDocPiPPermissionPromptAndroid";
    public static final String AUTO_PICTURE_IN_PICTURE_ANDROID = "AutoPictureInPictureAndroid";
    public static final String AUTO_REVOKE_SUSPICIOUS_NOTIFICATION =
            "AutoRevokeSuspiciousNotification";
    public static final String AVOID_DOUBLE_MULTIWINDOW_CHANGES = "AvoidDoubleMultiwindowChanges";
    public static final String AVOID_RELAYOUT_DURING_FOCUS_ANIMATION =
            "AvoidRelayoutDuringFocusAnimation";
    public static final String BACKGROUND_THREAD_POOL_FIELD_TRIAL =
            "BackgroundThreadPoolFieldTrial";
    public static final String BACK_FORWARD_CACHE = "BackForwardCache";
    public static final String BCIV_BOTTOM_CONTROLS = "AndroidBcivBottomControls";
    public static final String BLOCK_INTENTS_WHILE_LOCKED = "BlockIntentsWhileLocked";
    public static final String BOARDING_PASS_DETECTOR = "BoardingPassDetector";
    public static final String BOOKMARK_PANE_ANDROID = "BookmarkPaneAndroid";
    public static final String BROWSER_CONTROLS_DEBUGGING = "BrowserControlsDebugging";
    public static final String BROWSER_CONTROLS_EARLY_RESIZE = "BrowserControlsEarlyResize";
    public static final String BROWSER_CONTROLS_IN_VIZ = "AndroidBrowserControlsInViz";
    public static final String BROWSER_CONTROLS_RENDER_DRIVEN_SHOW_CONSTRAINT =
            "BrowserControlsRenderDrivenShowConstraint";
    public static final String BROWSING_DATA_MODEL = "BrowsingDataModel";
    public static final String CACHE_ACTIVITY_TASKID = "CacheActivityTaskID";
    public static final String CACHE_IS_MULTI_INSTANCE_API_31_ENABLED =
            "CacheIsMultiInstanceApi31Enabled";
    public static final String CAPTIVE_PORTAL_CERTIFICATE_LIST = "CaptivePortalCertificateList";
    public static final String CCT_ADAPTIVE_BUTTON = "CCTAdaptiveButton";
    public static final String CCT_ADAPTIVE_BUTTON_TEST_SWITCH = "CCTAdaptiveButtonTestSwitch";
    public static final String CCT_AUTH_TAB = "CCTAuthTab";
    public static final String CCT_AUTH_TAB_DISABLE_ALL_EXTERNAL_INTENTS =
            "CCTAuthTabDisableAllExternalIntents";
    public static final String CCT_AUTH_TAB_ENABLE_HTTPS_REDIRECTS =
            "CCTAuthTabEnableHttpsRedirects";
    public static final String CCT_AUTO_TRANSLATE = "CCTAutoTranslate";
    public static final String CCT_BLOCK_TOUCHES_DURING_ENTER_ANIMATION =
            "CCTBlockTouchesDuringEnterAnimation";
    public static final String CCT_CLIENT_DATA_HEADER = "CCTClientDataHeader";
    public static final String CCT_CONTEXTUAL_MENU_ITEMS = "CCTContextualMenuItems";
    public static final String CCT_DESTROY_TAB_WHEN_MODEL_IS_EMPTY =
            "CCTDestroyTabWhenModelIsEmpty";
    public static final String CCT_EXTEND_TRUSTED_CDN_PUBLISHER = "CCTExtendTrustedCdnPublisher";
    public static final String CCT_FIX_WARMUP = "CCTFixWarmup";
    public static final String CCT_FRE_IN_SAME_TASK = "CCTFreInSameTask";
    public static final String CCT_GOOGLE_BOTTOM_BAR = "CCTGoogleBottomBar";
    public static final String CCT_GOOGLE_BOTTOM_BAR_VARIANT_LAYOUTS =
            "CCTGoogleBottomBarVariantLayouts";
    public static final String CCT_INCOGNITO_AVAILABLE_TO_THIRD_PARTY =
            "CCTIncognitoAvailableToThirdParty";
    public static final String CCT_MINIMIZED_ENABLED_BY_DEFAULT = "CCTMinimizedEnabledByDefault";
    public static final String CCT_MULTIPLE_PARALLEL_REQUESTS = "CCTMultipleParallelRequests";
    public static final String CCT_NAVIGATIONAL_PREFETCH = "CCTNavigationalPrefetch";
    public static final String CCT_NAVIGATION_METRICS = "CCTNavigationMetrics";
    public static final String CCT_NESTED_SECURITY_ICON = "CCTNestedSecurityIcon";
    public static final String CCT_OPEN_IN_BROWSER_BUTTON_IF_ALLOWED_BY_EMBEDDER =
            "CCTOpenInBrowserButtonIfAllowedByEmbedder";
    public static final String CCT_OPEN_IN_BROWSER_BUTTON_IF_ENABLED_BY_EMBEDDER =
            "CCTOpenInBrowserButtonIfEnabledByEmbedder";
    public static final String CCT_REALTIME_ENGAGEMENT_EVENTS_IN_BACKGROUND =
            "CCTRealtimeEngagementEventsInBackground";
    public static final String CCT_REPORT_PARALLEL_REQUEST_STATUS =
            "CCTReportParallelRequestStatus";
    public static final String CCT_REPORT_PRERENDER_EVENTS = "CCTReportPrerenderEvents";
    public static final String CCT_RESET_TIMEOUT_ENABLED = "CCTResetTimeoutEnabled";
    public static final String CCT_RESIZABLE_FOR_THIRD_PARTIES = "CCTResizableForThirdParties";
    public static final String CCT_SHOW_TAB_FIX = "CCTShowTabFix";
    public static final String CCT_TAB_MODAL_DIALOG = "CCTTabModalDialog";
    public static final String CCT_TOOLBAR_REFACTOR = "CCTToolbarRefactor";
    public static final String CHANGE_UNFOCUSED_PRIORITY = "ChangeUnfocusedPriority";
    public static final String CHROME_ITEM_PICKER_UI = "ChromeItemPickerUi";
    public static final String CHROME_NATIVE_URL_OVERRIDING = "ChromeNativeUrlOverriding";
    public static final String CHROME_SURVEY_NEXT_ANDROID = "ChromeSurveyNextAndroid";
    public static final String CLAMP_AUTOMOTIVE_SCALING = "ClampAutomotiveScaling";
    public static final String CLANK_STARTUP_LATENCY_INJECTION = "ClankStartupLatencyInjection";
    public static final String CLANK_WHATS_NEW = "ClankWhatsNew";
    public static final String CLEAR_INSTANCE_INFO_WHEN_CLOSED_INTENTIONALLY =
            "ClearInstanceInfoWhenClosedIntentionally";
    public static final String CLEAR_INTENT_WHEN_RECREATED = "ClearIntentWhenRecreated";
    public static final String COMMAND_LINE_ON_NON_ROOTED = "CommandLineOnNonRooted";
    public static final String COMMERCE_MERCHANT_VIEWER = "CommerceMerchantViewer";
    public static final String CONTENT_CAPTURE_SEND_METADATA_FOR_DATA_SHARE =
            "ContentCaptureSendMetadataForDataShare";
    public static final String CONTEXTUAL_PAGE_ACTIONS = "ContextualPageActions";
    public static final String CONTEXTUAL_PAGE_ACTION_READER_MODE =
            "ContextualPageActionReaderMode";
    public static final String CONTEXTUAL_PAGE_ACTION_TAB_GROUPING =
            "ContextualPageActionTabGrouping";
    public static final String CONTEXTUAL_SEARCH_DISABLE_ONLINE_DETECTION =
            "ContextualSearchDisableOnlineDetection";
    public static final String CONTEXTUAL_SEARCH_SUPPRESS_SHORT_VIEW =
            "ContextualSearchSuppressShortView";
    public static final String CONTEXT_MENU_EMPTY_SPACE = "ContextMenuEmptySpace";
    public static final String CONTEXT_MENU_PICTURE_IN_PICTURE_ANDROID =
            "ContextMenuPictureInPictureAndroid";
    public static final String CONTEXT_MENU_TRANSLATE_WITH_GOOGLE_LENS =
            "ContextMenuTranslateWithGoogleLens";
    public static final String CONTROLS_VISIBILITY_FROM_NAVIGATIONS =
            "ControlsVisibilityFromNavigations";
    public static final String CORMORANT = "Cormorant";
    public static final String CPA_SPEC_UPDATE = "CpaSpecUpdate";
    public static final String CROSS_DEVICE_TAB_PANE_ANDROID = "CrossDeviceTabPaneAndroid";
    public static final String DARKEN_WEBSITES_CHECKBOX_IN_THEMES_SETTING =
            "DarkenWebsitesCheckboxInThemesSetting";
    public static final String DATA_SHARING = "DataSharing";
    public static final String DATA_SHARING_ENABLE_UPDATE_CHROME_UI =
            "DataSharingEnableUpdateChromeUI";
    public static final String DATA_SHARING_JOIN_ONLY = "DataSharingJoinOnly";
    public static final String DATA_SHARING_NON_PRODUCTION_ENVIRONMENT =
            "DataSharingNonProductionEnvironment";
    public static final String DEFAULT_BROWSER_PROMO_ANDROID2 = "DefaultBrowserPromoAndroid2";
    public static final String DESKTOP_UA_ON_CONNECTED_DISPLAY = "DesktopUAOnConnectedDisplay";
    public static final String DETAILED_LANGUAGE_SETTINGS = "DetailedLanguageSettings";
    public static final String DEVICE_AUTHENTICATOR_ANDROIDX = "DeviceAuthenticatorAndroidx";
    public static final String DISABLE_INSTANCE_LIMIT = "DisableInstanceLimit";
    public static final String DISCO_FEED_ENDPOINT = "DiscoFeedEndpoint";
    public static final String DISPLAY_EDGE_TO_EDGE_FULLSCREEN = "DisplayEdgeToEdgeFullscreen";
    public static final String DISPLAY_WILDCARD_CONTENT_SETTINGS =
            "DisplayWildcardInContentSettings";
    public static final String DOCUMENT_PICTURE_IN_PICTURE_API = "DocumentPictureInPictureAPI";
    public static final String DRAW_CHROME_PAGES_EDGE_TO_EDGE = "DrawChromePagesEdgeToEdge";
    public static final String DRAW_CUTOUT_EDGE_TO_EDGE = "DrawCutoutEdgeToEdge";
    public static final String EDGE_TO_EDGE_BOTTOM_CHIN = "EdgeToEdgeBottomChin";
    public static final String EDGE_TO_EDGE_EVERYWHERE = "EdgeToEdgeEverywhere";
    public static final String EDGE_TO_EDGE_MONITOR_CONFIGURATIONS =
            "EdgeToEdgeMonitorConfigurations";
    public static final String EDGE_TO_EDGE_TABLET = "EdgeToEdgeTablet";
    public static final String EDGE_TO_EDGE_USE_BACKUP_NAVBAR_INSETS =
            "EdgeToEdgeUseBackupNavbarInsets";
    public static final String EDUCATIONAL_TIP_DEFAULT_BROWSER_PROMO_CARD =
            "EducationalTipDefaultBrowserPromoCard";
    public static final String EDUCATIONAL_TIP_MODULE = "EducationalTipModule";
    public static final String EMPTY_TAB_LIST_ANIMATION_KILL_SWITCH =
            "EmptyTabListAnimationKillSwitch";
    public static final String ENABLE_CLIPBOARD_DATA_CONTROLS_ANDROID =
            "EnableClipboardDataControlsAndroid";
    public static final String ENABLE_DISCOUNT_INFO_API = "EnableDiscountInfoApi";
    public static final String ENABLE_ESCAPE_HANDLING_FOR_SECONDARY_ACTIVITIES =
            "EnableEscapeHandlingForSecondaryActivities";
    public static final String ENABLE_EXCLUSIVE_ACCESS_MANAGER = "EnableExclusiveAccessManager";
    public static final String ENABLE_FULLSCREEN_TO_ANY_SCREEN_ANDROID =
            "EnableFullscreenToAnyScreenAndroid";
    public static final String ENABLE_SAVE_PACKAGE_FOR_OFF_THE_RECORD =
            "EnableSavePackageForOffTheRecord";
    public static final String ENABLE_SWIPE_TO_SWITCH_PANE = "EnableSwipeToSwitchPane";
    public static final String ENABLE_X_AXIS_ACTIVITY_TRANSITION = "EnableXAxisActivityTransition";
    public static final String ESC_CANCEL_DRAG = "EscCancelDrag";
    public static final String FACILITATED_PAYMENTS_ENABLE_A2A_PAYMENT =
            "FacilitatedPaymentsEnableA2APayment";
    public static final String FEED_AUDIO_OVERVIEWS = "FeedAudioOverviews";
    public static final String FEED_CONTAINMENT = "FeedContainment";
    public static final String FEED_FOLLOW_UI_UPDATE = "FeedFollowUiUpdate";
    public static final String FEED_HEADER_REMOVAL = "FeedHeaderRemoval";
    public static final String FEED_IMAGE_MEMORY_CACHE_SIZE_PERCENTAGE =
            "FeedImageMemoryCacheSizePercentage";
    public static final String FEED_LOADING_PLACEHOLDER = "FeedLoadingPlaceholder";
    public static final String FILLING_PASSWORDS_FROM_ANY_ORIGIN = "FillingPasswordsFromAnyOrigin";
    public static final String FLOATING_SNACKBAR = "FloatingSnackbar";
    public static final String FLUID_RESIZE = "FluidResize";
    public static final String FORCE_LIST_TAB_SWITCHER = "ForceListTabSwitcher";
    public static final String FORCE_TRANSLUCENT_NOTIFICATION_TRAMPOLINE =
            "ForceTranslucentNotificationTrampoline";
    public static final String FORCE_WEB_CONTENTS_DARK_MODE = "WebContentsForceDark";
    public static final String FULLSCREEN_INSETS_API_MIGRATION = "FullscreenInsetsApiMigration";
    public static final String FULLSCREEN_INSETS_API_MIGRATION_ON_AUTOMOTIVE =
            "FullscreenInsetsApiMigrationOnAutomotive";
    public static final String GRID_TAB_SWITCHER_SURFACE_COLOR_UPDATE =
            "GridTabSwitcherSurfaceColorUpdate";
    public static final String GRID_TAB_SWITCHER_UPDATE = "GridTabSwitcherUpdate";
    public static final String GROUP_NEW_TAB_WITH_PARENT = "GroupNewTabWithParent";
    public static final String GROUP_SUGGESTION_SERVICE = "GroupSuggestionService";
    public static final String HASH_PREFIX_REAL_TIME_LOOKUPS =
            "SafeBrowsingHashPrefixRealTimeLookups";
    public static final String HEADLESS_TAB_MODEL = "HeadlessTabModel";
    public static final String HISTORY_JOURNEYS = "Journeys";
    public static final String HISTORY_PANE_ANDROID = "HistoryPaneAndroid";
    public static final String HOME_MODULE_PREF_REFACTOR = "HomeModulePrefRefactor";
    public static final String HTTPS_FIRST_BALANCED_MODE = "HttpsFirstBalancedMode";
    public static final String HUB_BACK_BUTTON = "HubBackButton";
    public static final String INCOGNITO_NTP_SMALL_ICON = "IncognitoNtpSmallIcon";
    public static final String INCOGNITO_SCREENSHOT = "IncognitoScreenshot";
    public static final String INCOGNITO_THEME_OVERLAY_TESTING = "IncognitoThemeOverlayTesting";
    public static final String INSTANCE_SWITCHER_V2 = "InstanceSwitcherV2";
    public static final String KEYBOARD_ESC_BACK_NAVIGATION = "KeyboardEscBackNavigation";
    public static final String LENS_ON_QUICK_ACTION_SEARCH_WIDGET = "LensOnQuickActionSearchWidget";
    public static final String LINK_HOVER_STATUS_BAR = "LinkHoverStatusBar";
    public static final String LOADING_PREDICTOR_LIMIT_PRECONNECT_SOCKET_COUNT =
            "LoadingPredictorLimitPreconnectSocketCount";
    public static final String LOAD_ALL_TABS_AT_STARTUP = "LoadAllTabsAtStartup";
    public static final String LOAD_NATIVE_EARLY = "LoadNativeEarly";
    public static final String LOCAL_NETWORK_ACCESS = "LocalNetworkAccessChecks";
    public static final String LOCAL_NETWORK_ACCESS_SPLIT_PERMISSIONS =
            "LocalNetworkAccessChecksSplitPermissions";
    public static final String LOCK_BACK_PRESS_HANDLER_AT_START = "LockBackPressHandlerAtStart";
    public static final String LOCK_TOP_CONTROLS_ON_LARGE_TABLETS = "LockTopControlsOnLargeTablets";
    public static final String LOCK_TOP_CONTROLS_ON_LARGE_TABLETS_V2 =
            "LockTopControlsOnLargeTabletsV2";
    public static final String LOOKALIKE_NAVIGATION_URL_SUGGESTIONS_UI =
            "LookalikeUrlNavigationSuggestionsUI";
    public static final String LOW_END_MEMORY_EXPERIMENT = BaseFeatures.LOW_END_MEMORY_EXPERIMENT;
    public static final String MAGIC_STACK_ANDROID = "MagicStackAndroid";
    public static final String MALICIOUS_APK_DOWNLOAD_CHECK = "MaliciousApkDownloadCheck";
    public static final String MAYLAUNCHURL_USES_SEPARATE_STORAGE_PARTITION =
            "MayLaunchUrlUsesSeparateStoragePartition";
    public static final String MEDIA_INDICATORS_ANDROID = "MediaIndicatorsAndroid";
    public static final String MOST_VISITED_TILES_CUSTOMIZATION = "MostVisitedTilesCustomization";
    public static final String MOST_VISITED_TILES_RESELECT = "MostVisitedTilesReselect";
    public static final String MULTI_INSTANCE_APPLICATION_STATUS_CLEANUP =
            "MultiInstanceApplicationStatusCleanup";
    public static final String MVC_UPDATE_VIEW_WHEN_MODEL_CHANGED = "MvcUpdateViewWhenModelChanged";
    public static final String NAV_BAR_COLOR_ANIMATION = "NavBarColorAnimation";
    public static final String NEW_TAB_PAGE_CUSTOMIZATION = "NewTabPageCustomization";
    public static final String NEW_TAB_PAGE_CUSTOMIZATION_FOR_MVT = "NewTabPageCustomizationForMvt";
    public static final String NEW_TAB_PAGE_CUSTOMIZATION_TOOLBAR_BUTTON =
            "NewTabPageCustomizationToolbarButton";
    public static final String NEW_TAB_PAGE_CUSTOMIZATION_V2 = "NewTabPageCustomizationV2";
    public static final String NOTIFICATION_PERMISSION_BOTTOM_SHEET =
            "NotificationPermissionBottomSheet";
    public static final String NOTIFICATION_PERMISSION_VARIANT = "NotificationPermissionVariant";
    public static final String NOTIFICATION_TRAMPOLINE = "NotificationTrampoline";
    public static final String OMAHA_MIN_SDK_VERSION_ANDROID = "OmahaMinSdkVersionAndroid";
    public static final String OMNIBOX_AUTOFOCUS_ON_INCOGNITO_NTP =
            "OmniboxAutofocusOnIncognitoNtp";
    public static final String OMNIBOX_CACHE_SUGGESTION_RESOURCES =
            "OmniboxCacheSuggestionResources";
    public static final String PAGE_CONTENT_PROVIDER = "PageContentProvider";
    public static final String PAGE_INFO_ABOUT_THIS_SITE_MORE_LANGS =
            "PageInfoAboutThisSiteMoreLangs";
    public static final String PAINT_PREVIEW_DEMO = "PaintPreviewDemo";
    public static final String PARTNER_CUSTOMIZATIONS_UMA = "PartnerCustomizationsUma";
    public static final String PASSWORD_FORM_GROUPED_AFFILIATIONS =
            "PasswordFormGroupedAffiliations";
    public static final String PCCT_MINIMUM_HEIGHT = "PCCTMinimumHeight";
    public static final String PERMISSION_DEDICATED_CPSS_SETTING_ANDROID =
            "PermissionDedicatedCpssSettingAndroid";
    public static final String PERMISSION_SITE_SETTING_RADIO_BUTTON =
            "PermissionSiteSettingsRadioButton";
    public static final String PERSIST_ACROSS_REBOOTS = "PersistAcrossReboots";
    public static final String PLUS_ADDRESSES_ENABLED = "PlusAddressesEnabled";
    public static final String PLUS_ADDRESS_ANDROID_OPEN_GMS_CORE_MANAGEMENT_PAGE =
            "PlusAddressAndroidOpenGmsCoreManagementPage";
    public static final String POST_GET_MEMORY_PRESSURE_TO_BACKGROUND =
            BaseFeatures.POST_GET_MY_MEMORY_STATE_TO_BACKGROUND;
    public static final String POWER_SAVING_MODE_BROADCAST_RECEIVER_IN_BACKGROUND =
            "PowerSavingModeBroadcastReceiverInBackground";
    public static final String PRECONNECT_ON_TAB_CREATION = "PreconnectOnTabCreation";
    public static final String PRERENDER2 = "Prerender2";
    public static final String PRICE_ANNOTATIONS = "PriceAnnotations";
    public static final String PRICE_CHANGE_MODULE = "PriceChangeModule";
    public static final String PRIVACY_SANDBOX_ACTIVITY_TYPE_STORAGE =
            "PrivacySandboxActivityTypeStorage";
    public static final String PRIVACY_SANDBOX_ADS_API_UX_ENHANCEMENTS =
            "PrivacySandboxAdsApiUxEnhancements";
    public static final String PRIVACY_SANDBOX_ADS_NOTICE_CCT = "PrivacySandboxAdsNoticeCCT";
    public static final String PRIVACY_SANDBOX_AD_TOPICS_CONTENT_PARITY =
            "PrivacySandboxAdTopicsContentParity";
    public static final String PRIVACY_SANDBOX_SENTIMENT_SURVEY = "PrivacySandboxSentimentSurvey";
    public static final String PRIVACY_SANDBOX_SETTINGS_4 = "PrivacySandboxSettings4";
    public static final String PROCESS_RANK_POLICY_ANDROID = "ProcessRankPolicyAndroid";
    // Do not access directly, use SupervisedUserService::IsLocallySupervised() or
    // supervised_user::UseLocalSupervision() instead. Exposed only for testing.
    public static final String PROPAGATE_DEVICE_CONTENT_FILTERS_TO_SUPERVISED_USER =
            "PropagateDeviceContentFiltersToSupervisedUser";
    public static final String PROTECT_RECENTLY_VISIBLE_TAB = "ProtectRecentlyVisibleTab";
    public static final String PUSH_MESSAGING_DISALLOW_SENDER_IDS =
            "PushMessagingDisallowSenderIDs";
    public static final String PWA_RESTORE_UI = "PwaRestoreUi";
    public static final String PWA_RESTORE_UI_AT_STARTUP = "PwaRestoreUiAtStartup";
    public static final String PWA_UPDATE_DIALOG_FOR_ICON = "PwaUpdateDialogForIcon";
    public static final String QUIET_NOTIFICATION_PROMPTS = "QuietNotificationPrompts";
    public static final String READALOUD = "ReadAloud";
    public static final String READALOUD_AUDIO_OVERVIEWS = "ReadAloudAudioOverviews";
    public static final String READALOUD_AUDIO_OVERVIEWS_FEEDBACK =
            "ReadAloudAudioOverviewsFeedback";
    public static final String READALOUD_AUDIO_OVERVIEWS_SKIP_DISCLAIMER_WHEN_POSSIBLE =
            "ReadAloudAudioOverviewsSkipDisclaimerWhenPossible";
    public static final String READALOUD_BACKGROUND_PLAYBACK = "ReadAloudBackgroundPlayback";
    public static final String READALOUD_IN_MULTI_WINDOW = "ReadAloudInMultiWindow";
    public static final String READALOUD_IN_OVERFLOW_MENU_IN_CCT = "ReadAloudInOverflowMenuInCCT";
    public static final String READALOUD_IPH_MENU_BUTTON_HIGHLIGHT_CCT =
            "ReadAloudIPHMenuButtonHighlightCCT";
    public static final String READALOUD_PLAYBACK = "ReadAloudPlayback";
    public static final String READALOUD_TAP_TO_SEEK = "ReadAloudTapToSeek";
    public static final String RECENTLY_CLOSED_TABS_AND_WINDOWS = "RecentlyClosedTabsAndWindows";
    public static final String RECORD_INCOGNITO_NTP_TIME_TO_FIRST_NAVIGATION_METRIC =
            "RecordIncognitoNtpTimeToFirstNavigationMetric";
    public static final String RECORD_SUPPRESSION_METRICS = "RecordSuppressionMetrics";
    public static final String REENGAGEMENT_NOTIFICATION = "ReengagementNotification";
    public static final String RELATED_SEARCHES_ALL_LANGUAGE = "RelatedSearchesAllLanguage";
    public static final String RELATED_SEARCHES_SWITCH = "RelatedSearchesSwitch";
    public static final String RELATED_WEBSITE_SETS_UI = "RelatedWebsiteSetsUi";
    public static final String REMOVE_TAB_FOCUS_ON_SHOWING_AND_SELECT =
            "RemoveTabFocusOnShowingAndSelect";
    public static final String RENAME_JOURNEYS = "RenameJourneys";
    public static final String REPORT_NOTIFICATION_CONTENT_DETECTION_DATA =
            "ReportNotificationContentDetectionData";
    public static final String RESTRICT_LEGACY_SEARCH_ENGINE_PROMO_ON_FORM_FACTORS =
            "RestrictLegacySearchEnginePromoOnFormFactors";
    public static final String RIGHT_EDGE_GOES_FORWARD_GESTURE_NAV =
            "RightEdgeGoesForwardGestureNav";
    public static final String ROBUST_WINDOW_MANAGEMENT = "RobustWindowManagement";
    public static final String ROBUST_WINDOW_MANAGEMENT_EXPERIMENTAL =
            "RobustWindowManagementExperimental";
    public static final String ROLL_BACK_MODE_B = "RollBackModeB";
    public static final String SAFETY_HUB = "SafetyHub";
    public static final String SAFETY_HUB_DISRUPTIVE_NOTIFICATION_REVOCATION =
            "SafetyHubDisruptiveNotificationRevocation";
    public static final String SAFETY_HUB_LOCAL_PASSWORDS_MODULE = "SafetyHubLocalPasswordsModule";
    public static final String SAFETY_HUB_UNIFIED_PASSWORDS_MODULE =
            "SafetyHubUnifiedPasswordsModule";
    public static final String SAFETY_HUB_WEAK_AND_REUSED_PASSWORDS =
            "SafetyHubWeakAndReusedPasswords";
    public static final String SAFE_BROWSING_DELAYED_WARNINGS = "SafeBrowsingDelayedWarnings";
    public static final String SAFE_BROWSING_EXTENDED_REPORTING_REMOVE_PREF_DEPENDENCY =
            "ExtendedReportingRemovePrefDependency";
    public static final String SEARCH_IN_CCT = "SearchInCCT";
    public static final String SEARCH_IN_CCT_ALTERNATE_TAP_HANDLING =
            "SearchInCCTAlternateTapHandling";
    public static final String SEARCH_IN_CCT_ALTERNATE_TAP_HANDLING_IF_ENABLED_BY_EMBEDDER =
            "SearchInCCTAlternateTapHandlingIfEnabledByEmbedder";
    public static final String SEARCH_IN_CCT_IF_ENABLED_BY_EMBEDDER =
            "SearchInCCTIfEnabledByEmbedder";
    public static final String SEARCH_IN_SETTINGS = "SearchInSettings";
    public static final String SEARCH_RESUMPTION_MODULE_ANDROID = "SearchResumptionModuleAndroid";
    public static final String SEED_ACCOUNTS_REVAMP = "SeedAccountsRevamp";
    public static final String SEGMENTATION_PLATFORM_ANDROID_HOME_MODULE_RANKER =
            "SegmentationPlatformAndroidHomeModuleRanker";
    public static final String SEGMENTATION_PLATFORM_ANDROID_HOME_MODULE_RANKER_V2 =
            "SegmentationPlatformAndroidHomeModuleRankerV2";
    public static final String SEGMENTATION_PLATFORM_EPHEMERAL_CARD_RANKER =
            "SegmentationPlatformEphemeralCardRanker";
    public static final String SENSITIVE_CONTENT = "SensitiveContent";
    public static final String SENSITIVE_CONTENT_WHILE_SWITCHING_TABS =
            "SensitiveContentWhileSwitchingTabs";
    public static final String SETTINGS_MULTI_COLUMN = "SettingsMultiColumn";
    public static final String SETTINGS_SINGLE_ACTIVITY = "SettingsSingleActivity";
    public static final String SHARED_DATA_TYPES_KILL_SWITCH = "SharedDataTypesKillSwitch";
    public static final String SHARE_CUSTOM_ACTIONS_IN_CCT = "ShareCustomActionsInCCT";
    public static final String SHOW_BLOCKED_SENSITIVE_DOWNLOAD = "ShowBlockedSensitiveDownload";
    public static final String SHOW_DOWNLOAD_SCANNING_STATE = "ShowDownloadScanningState";
    public static final String SHOW_CLOSE_ALL_INCOGNITO_TABS_BUTTON =
            "ShowCloseAllIncognitoTabsButton";
    public static final String SHOW_NEW_TAB_ANIMATIONS = "ShowNewTabAnimations";
    public static final String SHOW_TAB_LIST_ANIMATIONS = "ShowTabListAnimations";
    public static final String SHOW_WARNINGS_FOR_SUSPICIOUS_NOTIFICATIONS =
            "ShowWarningsForSuspiciousNotifications";
    public static final String SMALLER_TAB_STRIP_TITLE_LIMIT = "SmallerTabStripTitleLimit";
    public static final String SMART_SUGGESTION_FOR_LARGE_DOWNLOADS =
            "SmartSuggestionForLargeDownloads";
    public static final String SPLIT_CACHE_BY_NETWORK_ISOLATION_KEY =
            "SplitCacheByNetworkIsolationKey";
    public static final String START_SURFACE_RETURN_TIME = "StartSurfaceReturnTime";
    public static final String STOP_APP_INDEXING_REPORT = "StopAppIndexingReport";
    public static final String SUBMENUS_IN_APP_MENU = "SubmenusInAppMenu";
    public static final String SUBMENUS_TAB_CONTEXT_MENU_LFF_TAB_STRIP =
            "SubmenusTabContextMenuLffTabStrip";
    public static final String SUGGESTION_ANSWERS_COLOR_REVERSE = "SuggestionAnswersColorReverse";
    public static final String SUPPRESS_TOOLBAR_CAPTURES_AT_GESTURE_END =
            "SuppressToolbarCapturesAtGestureEnd";
    public static final String SYNC_ENABLE_NEW_SYNC_DASHBOARD_URL = "SyncEnableNewSyncDashboardUrl";
    public static final String SYNC_ENABLE_PASSWORDS_SYNC_ERROR_MESSAGE_ALTERNATIVE =
            "SyncEnablePasswordsSyncErrorMessageAlternative";
    public static final String TAB_CLOSURE_METHOD_REFACTOR = "TabClosureMethodRefactor";
    public static final String TAB_FREEZING_USES_DISCARD = "TabFreezingUsesDiscard";
    public static final String TAB_MODEL_INIT_FIXES = "TabModelInitFixes";
    public static final String TAB_STORAGE_SQLITE_PROTOTYPE = "TabStorageSqlitePrototype";
    public static final String TAB_STRIP_AUTO_SELECT_ON_CLOSE_CHANGE =
            "TabStripAutoSelectOnCloseChange";
    public static final String TAB_STRIP_DENSITY_CHANGE_ANDROID = "TabStripDensityChangeAndroid";
    public static final String TAB_STRIP_INCOGNITO_MIGRATION = "TabStripIncognitoMigration";
    public static final String TAB_SWITCHER_DRAG_DROP_ANDROID = "TabSwitcherDragDropAndroid";
    public static final String TAB_SWITCHER_GROUP_SUGGESTIONS_ANDROID =
            "TabSwitcherGroupSuggestionsAndroid";
    public static final String TAB_SWITCHER_GROUP_SUGGESTIONS_TEST_MODE_ANDROID =
            "TabSwitcherGroupSuggestionsTestModeAndroid";
    public static final String TAB_WINDOW_MANAGER_REPORT_INDICES_MISMATCH =
            "TabWindowManagerReportIndicesMismatch";
    public static final String TASK_MANAGER_CLANK = "TaskManagerClank";
    public static final String TEST_DEFAULT_DISABLED = "TestDefaultDisabled";
    public static final String TEST_DEFAULT_ENABLED = "TestDefaultEnabled";
    public static final String TINKER_TANK_BOTTOM_SHEET = "TinkerTankBottomSheet";
    public static final String TOOLBAR_PHONE_ANIMATION_REFACTOR = "ToolbarPhoneAnimationRefactor";
    public static final String TOOLBAR_SCROLL_ABLATION = "AndroidToolbarScrollAblation";
    public static final String TOOLBAR_SNAPSHOT_REFACTOR = "ToolbarSnapshotRefactor";
    public static final String TOOLBAR_STALE_CAPTURE_BUG_FIX = "ToolbarStaleCaptureBugFix";
    public static final String TOOLBAR_TABLET_RESIZE_REFACTOR = "ToolbarTabletResizeRefactor";
    public static final String TOP_CONTROLS_REFACTOR = "TopControlsRefactor";
    public static final String TOP_CONTROLS_REFACTOR_V2 = "TopControlsRefactorV2";
    public static final String TOUCH_TO_SEARCH_CALLOUT = "TouchToSearchCallout";
    public static final String TRACKING_PROTECTION_3PCD = "TrackingProtection3pcd";
    public static final String TRANSLATE_MESSAGE_UI = "TranslateMessageUI";
    public static final String TRANSLATE_TFLITE = "TFLiteLanguageDetectionEnabled";
    public static final String TRUSTED_WEB_ACTIVITY_CONTACTS_DELEGATION =
            "TrustedWebActivityContactsDelegation";
    public static final String UMA_SESSION_CORRECTNESS_FIXES = "UmaSessionCorrectnessFixes";
    public static final String UNO_PHASE_2_FOLLOW_UP = "UnoPhase2FollowUp";
    public static final String UPDATE_COMPOSTIROR_FOR_SURFACE_CONTROL =
            "UpdateCompositorForSurfaceControl";
    public static final String USE_ACTIVITY_MANAGER_FOR_TAB_ACTIVATION =
            "UseActivityManagerForTabActivation";
    public static final String USE_ALTERNATE_HISTORY_SYNC_ILLUSTRATION =
            "UseAlternateHistorySyncIllustration";
    public static final String USE_CHIME_ANDROID_SDK = "UseChimeAndroidSdk";
    public static final String USE_INITIAL_NETWORK_STATE_AT_STARTUP =
            "UseInitialNetworkStateAtStartup";
    public static final String USE_LIBUNWINDSTACK_NATIVE_UNWINDER_ANDROID =
            "UseLibunwindstackNativeUnwinderAndroid";
    public static final String VERIFY_QWACS = "VerifyQWACs";
    public static final String VISITED_URL_RANKING_SERVICE = "VisitedURLRankingService";
    public static final String WEB_APK_BACKUP_AND_RESTORE_BACKEND = "WebApkBackupAndRestoreBackend";
    public static final String WEB_APK_INSTALL_FAILURE_NOTIFICATION =
            "WebApkInstallFailureNotification";
    public static final String WEB_APK_MIN_SHELL_APK_VERSION = "WebApkMinShellVersion";
    public static final String WEB_FEED_AWARENESS = "WebFeedAwareness";
    public static final String WEB_FEED_ONBOARDING = "WebFeedOnboarding";
    public static final String WEB_FEED_SORT = "WebFeedSort";
    public static final String WEB_OTP_CROSS_DEVICE_SIMPLE_STRING = "WebOtpCrossDeviceSimpleString";
    public static final String XPLAT_SYNCED_SETUP = "XplatSyncedSetup";
    public static final String XSURFACE_METRICS_REPORTING = "XsurfaceMetricsReporting";

Wenyu Fu . unresolved

Please fix this ERROR reported by Keep Sorted: These lines are out of order.

These lines are out of order.

File components/browser_ui/styles/android/java/res/drawable/ic_business_36dp.xml

Line 16, Patchset 3 (Latest):

        android:pathData="M80,840L80,120L473.33,120L473.33,283.33L880,283.33L880,840L80,840ZM146.67,773.33L243.33,773.33L243.33,676.67L146.67,676.67L146.67,773.33ZM146.67,610L243.33,610L243.33,513.33L146.67,513.33L146.67,610ZM146.67,446.67L243.33,446.67L243.33,350L146.67,350L146.67,446.67ZM146.67,283.33L243.33,283.33L243.33,186.67L146.67,186.67L146.67,283.33ZM310,773.33L406.67,773.33L406.67,676.67L310,676.67L310,773.33ZM310,610L406.67,610L406.67,513.33L310,513.33L310,610ZM310,446.67L406.67,446.67L406.67,350L310,350L310,446.67ZM310,283.33L406.67,283.33L406.67,186.67L310,186.67L310,283.33ZM473.33,773.33L813.33,773.33L813.33,350L473.33,350L473.33,446.67L553.33,446.67L553.33,513.33L473.33,513.33L473.33,610L553.33,610L553.33,676.67L473.33,676.67L473.33,773.33ZM650,513.33L650,446.67L716.67,446.67L716.67,513.33L650,513.33ZM650,676.67L650,610L716.67,610L716.67,676.67L650,676.67Z"/>

Wenyu Fu . unresolved

nit: Side Q, I can't seem to load this path data when using Android studio.
Can you please use the icon that's available on go/icons?

Also this icon is called "Domain" in the material icon library. Let's name it as ic_domain_36dp.xml.

The old icon name should have been updated.

Open in Gerrit

Related details

Attention is currently required from:

Min Qin
Shakti Sahu

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

No-Unresolved-Comments

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Min Qin (Gerrit)

unread,

6:38 PM (5 hours ago) 6:38 PM

to Mark Schillaci, (Julie)Jeongeun Kim, AyeAye, Shakti Sahu, Wenyu Fu, Chromium LUCI CQ, chromium...@chromium.org, francisjp...@google.com, yuzo+...@chromium.org, abigailbk...@google.com, dtseng...@chromium.org, josiah...@chromium.org, nektar...@chromium.org, kyungjunle...@google.com, dtraino...@chromium.org, srahim...@chromium.org

Attention needed from Shakti Sahu and Wenyu Fu

Min Qin added 2 comments

File chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/ChromeFeatureList.java

Line 160, Patchset 3: public static final String ABORT_NAVIGATIONS_FROM_TAB_CLOSURES =

Wenyu Fu . resolved

Please fix this ERROR reported by Keep Sorted: These lines are out of order.
These lines are out of order.

Min Qin

Done

File components/browser_ui/styles/android/java/res/drawable/ic_business_36dp.xml

Line 16, Patchset 3:

        android:pathData="M80,840L80,120L473.33,120L473.33,283.33L880,283.33L880,840L80,840ZM146.67,773.33L243.33,773.33L243.33,676.67L146.67,676.67L146.67,773.33ZM146.67,610L243.33,610L243.33,513.33L146.67,513.33L146.67,610ZM146.67,446.67L243.33,446.67L243.33,350L146.67,350L146.67,446.67ZM146.67,283.33L243.33,283.33L243.33,186.67L146.67,186.67L146.67,283.33ZM310,773.33L406.67,773.33L406.67,676.67L310,676.67L310,773.33ZM310,610L406.67,610L406.67,513.33L310,513.33L310,610ZM310,446.67L406.67,446.67L406.67,350L310,350L310,446.67ZM310,283.33L406.67,283.33L406.67,186.67L310,186.67L310,283.33ZM473.33,773.33L813.33,773.33L813.33,350L473.33,350L473.33,446.67L553.33,446.67L553.33,513.33L473.33,513.33L473.33,610L553.33,610L553.33,676.67L473.33,676.67L473.33,773.33ZM650,513.33L650,446.67L716.67,446.67L716.67,513.33L650,513.33ZM650,676.67L650,610L716.67,610L716.67,676.67L650,676.67Z"/>

Wenyu Fu . resolved

nit: Side Q, I can't seem to load this path data when using Android studio.
Can you please use the icon that's available on go/icons?
Also this icon is called "Domain" in the material icon library. Let's name it as ic_domain_36dp.xml.
The old icon name should have been updated.

Min Qin

Done renaming all resources to ic_domains and ic_domain_36dp.
This is actually copied from go/icons.
For example, the 24 px version is here: https://fonts.gstatic.com/s/i/short-term/release/googlesymbols/domain/default/24px.xml, The path data is the same as the 40 px version. While I was copying this from go/icons, Android changed the pathData to the ones you were seeing in Android studio. However, the new data doesn't render for me either on Download page. So the new patchset will use the same old data from ic_business.xml.

Open in Gerrit

Related details

Attention is currently required from:

Shakti Sahu
Wenyu Fu

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Wenyu Fu (Gerrit)

unread,

8:32 PM (3 hours ago) 8:32 PM

to Min Qin, Mark Schillaci, (Julie)Jeongeun Kim, AyeAye, Shakti Sahu, Chromium LUCI CQ, chromium...@chromium.org, francisjp...@google.com, yuzo+...@chromium.org, abigailbk...@google.com, dtseng...@chromium.org, josiah...@chromium.org, nektar...@chromium.org, kyungjunle...@google.com, dtraino...@chromium.org, srahim...@chromium.org

Attention needed from Min Qin and Shakti Sahu

Wenyu Fu voted and added 1 comment

Votes added by Wenyu Fu

Code-Review

1 comment

File components/browser_ui/styles/android/java/res/drawable/ic_business_36dp.xml

Line 16, Patchset 3:

        android:pathData="M80,840L80,120L473.33,120L473.33,283.33L880,283.33L880,840L80,840ZM146.67,773.33L243.33,773.33L243.33,676.67L146.67,676.67L146.67,773.33ZM146.67,610L243.33,610L243.33,513.33L146.67,513.33L146.67,610ZM146.67,446.67L243.33,446.67L243.33,350L146.67,350L146.67,446.67ZM146.67,283.33L243.33,283.33L243.33,186.67L146.67,186.67L146.67,283.33ZM310,773.33L406.67,773.33L406.67,676.67L310,676.67L310,773.33ZM310,610L406.67,610L406.67,513.33L310,513.33L310,610ZM310,446.67L406.67,446.67L406.67,350L310,350L310,446.67ZM310,283.33L406.67,283.33L406.67,186.67L310,186.67L310,283.33ZM473.33,773.33L813.33,773.33L813.33,350L473.33,350L473.33,446.67L553.33,446.67L553.33,513.33L473.33,513.33L473.33,610L553.33,610L553.33,676.67L473.33,676.67L473.33,773.33ZM650,513.33L650,446.67L716.67,446.67L716.67,513.33L650,513.33ZM650,676.67L650,610L716.67,610L716.67,676.67L650,676.67Z"/>

Wenyu Fu . unresolved

nit: Side Q, I can't seem to load this path data when using Android studio.
Can you please use the icon that's available on go/icons?
Also this icon is called "Domain" in the material icon library. Let's name it as ic_domain_36dp.xml.
The old icon name should have been updated.

Min Qin

Done renaming all resources to ic_domains and ic_domain_36dp.
This is actually copied from go/icons.
For example, the 24 px version is here: https://fonts.gstatic.com/s/i/short-term/release/googlesymbols/domain/default/24px.xml, The path data is the same as the 40 px version. While I was copying this from go/icons, Android changed the pathData to the ones you were seeing in Android studio. However, the new data doesn't render for me either on Download page. So the new patchset will use the same old data from ic_business.xml.

Wenyu Fu

Thanks for checking the go/icons :)

You'd need to update the entire file, including `android:viewportWidth` too. since the path is made based on the viewport coordinates.

Also, we should name these `ic_domain_24dp` and `ic_domain_36dp`... but I wouldn't mind if you do that in a follow up, to unblock this CL from landing

Open in Gerrit

Related details

Attention is currently required from:

Min Qin
Shakti Sahu

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages